devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] Fix remaining TI K3 CHECK_DTBS warnings
@ 2025-04-21 21:46 Andrew Davis
  2025-04-21 21:46 ` [PATCH 1/3] dt-bindings: mfd: ti,j721e-system-controller: Add compatible string for AM654 Andrew Davis
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Andrew Davis @ 2025-04-21 21:46 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Nishanth Menon,
	Vignesh Raghavendra, Tero Kristo, Jan Kiszka
  Cc: devicetree, linux-arm-kernel, linux-kernel, Andrew Davis

Hello all,

Until we resolve this thread[0] we do not have a set direction for
modeling our device's controller devices. For now as the AM654 MAIN
domain controller region is already one of the messy combination
syscon + child device containing nodes, no harm in silencing this last
DT check warning in the meantime.

Depending on the outcome of [0], this series can be safely unwound in
a couple ways without any backwards nor forwards compatibility breaks.
So no need to wait on the outcome there to take this series.

The last patch should take care of the last CHECK_DTBS warning for K3.

Thanks,
Andrew

[0] https://lore.kernel.org/lkml/6241ff00-27e6-45ab-808e-f04e39854753@ti.com/

Andrew Davis (2):
  dt-bindings: mfd: ti,j721e-system-controller: Add compatible string
    for AM654
  arm64: dts: ti: am65x: Add missing power-supply for Rocktech-rk101
    panel

Jan Kiszka (1):
  arm64: dts: ti: k3-am65-main: add system controller compatible

 .../bindings/soc/ti/ti,j721e-system-controller.yaml | 13 +++++++++++++
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi            |  2 +-
 .../k3-am654-base-board-rocktech-rk101-panel.dtso   | 12 ++++++++++++
 3 files changed, 26 insertions(+), 1 deletion(-)

-- 
2.39.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/3] dt-bindings: mfd: ti,j721e-system-controller: Add compatible string for AM654
  2025-04-21 21:46 [PATCH 0/3] Fix remaining TI K3 CHECK_DTBS warnings Andrew Davis
@ 2025-04-21 21:46 ` Andrew Davis
  2025-04-25 19:36   ` Rob Herring (Arm)
  2025-04-21 21:46 ` [PATCH 2/3] arm64: dts: ti: k3-am65-main: add system controller compatible Andrew Davis
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Andrew Davis @ 2025-04-21 21:46 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Nishanth Menon,
	Vignesh Raghavendra, Tero Kristo, Jan Kiszka
  Cc: devicetree, linux-arm-kernel, linux-kernel, Andrew Davis

Add the child nodes that can be found under this node. Then as done for
other similar devices (J7200 and J721s2) add support for the AM654 system
controller to this binding.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 .../bindings/soc/ti/ti,j721e-system-controller.yaml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
index 13b6b6fa5dee7..f3bd0be3b279f 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
@@ -26,6 +26,7 @@ properties:
   compatible:
     items:
       - enum:
+          - ti,am654-system-controller
           - ti,j7200-system-controller
           - ti,j721e-system-controller
           - ti,j721s2-system-controller
@@ -73,6 +74,18 @@ patternProperties:
     description:
       The node corresponding to PCIe control register.
 
+  "^clock@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml#
+    description:
+      This is the Serdes Control region.
+
+  "^dss-oldi-io-ctrl@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/mfd/syscon.yaml#
+    description:
+      This is the DSS OLDI CTRL region.
+
 required:
   - compatible
   - reg
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] arm64: dts: ti: k3-am65-main: add system controller compatible
  2025-04-21 21:46 [PATCH 0/3] Fix remaining TI K3 CHECK_DTBS warnings Andrew Davis
  2025-04-21 21:46 ` [PATCH 1/3] dt-bindings: mfd: ti,j721e-system-controller: Add compatible string for AM654 Andrew Davis
@ 2025-04-21 21:46 ` Andrew Davis
  2025-04-21 21:46 ` [PATCH 3/3] arm64: dts: ti: am65x: Add missing power-supply for Rocktech-rk101 panel Andrew Davis
  2025-04-25 21:09 ` [PATCH 0/3] Fix remaining TI K3 CHECK_DTBS warnings Nishanth Menon
  3 siblings, 0 replies; 6+ messages in thread
From: Andrew Davis @ 2025-04-21 21:46 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Nishanth Menon,
	Vignesh Raghavendra, Tero Kristo, Jan Kiszka
  Cc: devicetree, linux-arm-kernel, linux-kernel, Andrew Davis

From: Jan Kiszka <jan.kiszka@siemens.com>

Now that the TI K3 AM654 system controller bindings also cover the usage
in the main domain, add its compatible to address dtbs_check complaints:

  k3-am654-base-board.dtb: scm-conf@100000: compatible: ['syscon', 'simple-mfd'] is too short

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Andrew Davis <afd@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 94a812a1355ba..6d3c467d7038c 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -479,7 +479,7 @@ sdhci1: mmc@4fa0000 {
 	};
 
 	scm_conf: scm-conf@100000 {
-		compatible = "syscon", "simple-mfd";
+		compatible = "ti,am654-system-controller", "syscon", "simple-mfd";
 		reg = <0 0x00100000 0 0x1c000>;
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/3] arm64: dts: ti: am65x: Add missing power-supply for Rocktech-rk101 panel
  2025-04-21 21:46 [PATCH 0/3] Fix remaining TI K3 CHECK_DTBS warnings Andrew Davis
  2025-04-21 21:46 ` [PATCH 1/3] dt-bindings: mfd: ti,j721e-system-controller: Add compatible string for AM654 Andrew Davis
  2025-04-21 21:46 ` [PATCH 2/3] arm64: dts: ti: k3-am65-main: add system controller compatible Andrew Davis
@ 2025-04-21 21:46 ` Andrew Davis
  2025-04-25 21:09 ` [PATCH 0/3] Fix remaining TI K3 CHECK_DTBS warnings Nishanth Menon
  3 siblings, 0 replies; 6+ messages in thread
From: Andrew Davis @ 2025-04-21 21:46 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Nishanth Menon,
	Vignesh Raghavendra, Tero Kristo, Jan Kiszka
  Cc: devicetree, linux-arm-kernel, linux-kernel, Andrew Davis

Add the 5v0 supply that is provided over the display panel cable and
used by the LCD. This is required by "simple panels" or we get the
following warning from DTBS_CHECK:

k3-am654-gp-evm.dtb: display0: 'power-supply' is a required property

Signed-off-by: Andrew Davis <afd@ti.com>
---
 .../ti/k3-am654-base-board-rocktech-rk101-panel.dtso | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board-rocktech-rk101-panel.dtso b/arch/arm64/boot/dts/ti/k3-am654-base-board-rocktech-rk101-panel.dtso
index 364c57b3b3a06..7a3953d64fd84 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board-rocktech-rk101-panel.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board-rocktech-rk101-panel.dtso
@@ -15,8 +15,20 @@
 #include <dt-bindings/interrupt-controller/irq.h>
 
 &{/} {
+	vcc_5v0: lcd-regulator {
+		/* Output of LM5140 */
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_5v0";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
+		regulator-boot-on;
+		vin-supply = <&evm_12v0>;
+	};
+
 	display0 {
 		compatible = "rocktech,rk101ii01d-ct";
+		power-supply = <&vcc_5v0>;
 		backlight = <&lcd_bl>;
 		enable-gpios = <&pca9555 8 GPIO_ACTIVE_HIGH>;
 		port {
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/3] dt-bindings: mfd: ti,j721e-system-controller: Add compatible string for AM654
  2025-04-21 21:46 ` [PATCH 1/3] dt-bindings: mfd: ti,j721e-system-controller: Add compatible string for AM654 Andrew Davis
@ 2025-04-25 19:36   ` Rob Herring (Arm)
  0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2025-04-25 19:36 UTC (permalink / raw)
  To: Andrew Davis
  Cc: Vignesh Raghavendra, Jan Kiszka, Conor Dooley,
	Krzysztof Kozlowski, Tero Kristo, Nishanth Menon, devicetree,
	linux-arm-kernel, linux-kernel


On Mon, 21 Apr 2025 16:46:18 -0500, Andrew Davis wrote:
> Add the child nodes that can be found under this node. Then as done for
> other similar devices (J7200 and J721s2) add support for the AM654 system
> controller to this binding.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  .../bindings/soc/ti/ti,j721e-system-controller.yaml | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/3] Fix remaining TI K3 CHECK_DTBS warnings
  2025-04-21 21:46 [PATCH 0/3] Fix remaining TI K3 CHECK_DTBS warnings Andrew Davis
                   ` (2 preceding siblings ...)
  2025-04-21 21:46 ` [PATCH 3/3] arm64: dts: ti: am65x: Add missing power-supply for Rocktech-rk101 panel Andrew Davis
@ 2025-04-25 21:09 ` Nishanth Menon
  3 siblings, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2025-04-25 21:09 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Vignesh Raghavendra, Tero Kristo, Jan Kiszka, Andrew Davis
  Cc: Nishanth Menon, devicetree, linux-arm-kernel, linux-kernel

Hi Andrew Davis,

On Mon, 21 Apr 2025 16:46:17 -0500, Andrew Davis wrote:
> Until we resolve this thread[0] we do not have a set direction for
> modeling our device's controller devices. For now as the AM654 MAIN
> domain controller region is already one of the messy combination
> syscon + child device containing nodes, no harm in silencing this last
> DT check warning in the meantime.
> 
> Depending on the outcome of [0], this series can be safely unwound in
> a couple ways without any backwards nor forwards compatibility breaks.
> So no need to wait on the outcome there to take this series.
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/3] dt-bindings: mfd: ti,j721e-system-controller: Add compatible string for AM654
      commit: 5959618631fec502ec0963f4082d565f7fbfff04
[2/3] arm64: dts: ti: k3-am65-main: add system controller compatible
      commit: 4765253055cc8ab3fdc5f9eb5b121d867e209fb1
[3/3] arm64: dts: ti: am65x: Add missing power-supply for Rocktech-rk101 panel
      commit: ae3ac9ffd59acf46b8934f4e7a5fa7a6803ac959

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-04-25 21:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-21 21:46 [PATCH 0/3] Fix remaining TI K3 CHECK_DTBS warnings Andrew Davis
2025-04-21 21:46 ` [PATCH 1/3] dt-bindings: mfd: ti,j721e-system-controller: Add compatible string for AM654 Andrew Davis
2025-04-25 19:36   ` Rob Herring (Arm)
2025-04-21 21:46 ` [PATCH 2/3] arm64: dts: ti: k3-am65-main: add system controller compatible Andrew Davis
2025-04-21 21:46 ` [PATCH 3/3] arm64: dts: ti: am65x: Add missing power-supply for Rocktech-rk101 panel Andrew Davis
2025-04-25 21:09 ` [PATCH 0/3] Fix remaining TI K3 CHECK_DTBS warnings Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).