From: Rob Herring <robh@kernel.org>
To: Grzegorz Jaszczyk <jaszczyk@chromium.org>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
saravanak@google.com, dmaluka@chromium.org, bgrzesik@google.com,
jaszczyk@google.com, ilpo.jarvinen@linux.intel.com,
usamaarif642@gmail.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, tnowicki@google.com,
mazurekm@google.com, vineethrp@google.com
Subject: Re: [PATCH v2 2/2] x86/of: add support for reserved memory defined by DT
Date: Wed, 23 Apr 2025 09:09:13 -0500 [thread overview]
Message-ID: <20250423140913.GA360030-robh@kernel.org> (raw)
In-Reply-To: <20250418124718.1009563-3-jaszczyk@chromium.org>
On Fri, Apr 18, 2025 at 12:47:18PM +0000, Grzegorz Jaszczyk wrote:
> From: Grzegorz Jaszczyk <jaszczyk@google.com>
>
> The DT reserved-memory nodes can be present in DT as described in
> Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml.
> Similar to other architecture, which supports DT, there is a need to
> create reserved memory regions for such nodes.
>
> Additionally, the x86 architecture builds its memory map based on E820
> description passed by bootloader and not on DT. Since x86 already has
> some DT support and allows booting with both ACPI and DT at the same
> time, let's register an arch specific hook which will validate if a
> reserved-memory region passed by DT is valid (covered by E820 reserved
> region entry).
>
> Without this check, the reserved memory from DT could be successfully
> registered, even though such a region could conflict with e820
> description e.g. it could be described as E820_RAM and could be already
> used at early x86 boot stage for memblock initialization (which happens
> before DT parsing).
Sorry, I don't get how it conflicts. Wouldn't the E820_RAM be registered
with memblock and memblock then handles the conflict (or should).
Rob
next prev parent reply other threads:[~2025-04-23 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 12:47 [PATCH v2 0/2] x86: add support for reserved memory defined by DT Grzegorz Jaszczyk
2025-04-18 12:47 ` [PATCH v2 1/2] of: fdt: allow to register arch specific hook validating reserved region Grzegorz Jaszczyk
2025-04-18 12:47 ` [PATCH v2 2/2] x86/of: add support for reserved memory defined by DT Grzegorz Jaszczyk
2025-04-23 14:09 ` Rob Herring [this message]
2025-04-24 18:06 ` Grzegorz Jaszczyk
2025-04-25 19:18 ` Rob Herring
2025-04-30 8:55 ` Grzegorz Jaszczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423140913.GA360030-robh@kernel.org \
--to=robh@kernel.org \
--cc=bgrzesik@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaluka@chromium.org \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jaszczyk@chromium.org \
--cc=jaszczyk@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mazurekm@google.com \
--cc=mingo@redhat.com \
--cc=saravanak@google.com \
--cc=tglx@linutronix.de \
--cc=tnowicki@google.com \
--cc=usamaarif642@gmail.com \
--cc=vineethrp@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).