From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3737718035; Thu, 24 Apr 2025 00:47:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745455672; cv=none; b=u5oCY2PzP375h89BPxoXNDWJ9/WYpXPXJQ0Wa0bD/DonlxUQ+CKkZJqtKYxvk0DxkyPIWKChUspN5k/DTbAVs902Lwvgj7RerZ8nWORLRUkUpB90Y4V3H6ttrt0fD6bQejRDdCVKrEfXiXfL92EGAqE4SmfE9NX1pLEGEfUPDWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745455672; c=relaxed/simple; bh=ok6GdHj13IWtzTTZmP7tdotz1A+I8om9d4rsjicjIIY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jiRStp2ie2oRz4okKeBQt3ZIQpG9M8aVA3OHT8b6LxUsUZOaJ4pnpt1iIDhYf/3TwKslNKPxUYJs8a9cy16tJzM3CvVXQUrgnYLN7H5LTSPzvDLJCUYOR0srLkJ0LzCEa+C9/M4WRfaEbV7t6eAuPVG6hBrb14KhlCAB9hNmC9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AED101063; Wed, 23 Apr 2025 17:47:42 -0700 (PDT) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4F07A3F59E; Wed, 23 Apr 2025 17:47:45 -0700 (PDT) Date: Thu, 24 Apr 2025 01:46:41 +0100 From: Andre Przywara To: Yixun Lan Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/5] dt-bindings: sram: sunxi-sram: Add A523 compatible Message-ID: <20250424014641.50c15efc@minigeek.lan> In-Reply-To: <20250423-01-sun55i-emac0-v1-1-46ee4c855e0a@gentoo.org> References: <20250423-01-sun55i-emac0-v1-0-46ee4c855e0a@gentoo.org> <20250423-01-sun55i-emac0-v1-1-46ee4c855e0a@gentoo.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 23 Apr 2025 22:03:22 +0800 Yixun Lan wrote: Hi, > Add new compatible for A527/T527 chips which using same die > as the A523 SoC. this reads a bit confusing, what about: The Allwinner A523 family of SoCs have their "system control" registers compatible to the A64 SoC, so just add the new SoC specific compatible string. Regardless: Reviewed-by: Andre Przywara Cheers, Andre > > Signed-off-by: Yixun Lan > --- > .../devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > index a7236f7db4ec34d44c4e2268f76281ef8ed83189..e7f7cf72719ea884d48fff69620467ff2834913b 100644 > --- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > +++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > @@ -50,6 +50,7 @@ properties: > - enum: > - allwinner,sun50i-a100-system-control > - allwinner,sun50i-h6-system-control > + - allwinner,sun55i-a523-system-control > - const: allwinner,sun50i-a64-system-control > > reg: >