Re: [PATCH v2 10/17] mfd: adp5585: add support for key events

[Lee Jones <lee@kernel.org>]

On Mon, 21 Apr 2025, Laurent Pinchart wrote:

> Hi Nuno,
> 
> Thank you for the patch.
> 
> On Tue, Apr 15, 2025 at 03:49:26PM +0100, Nuno Sá via B4 Relay wrote:
> > From: Nuno Sá <nuno.sa@analog.com>
> > 
> > This adds support for key events. Basically, it adds support for all the
> > FW parsing and configuration of the keys (also making sure there's no
> > overlaps). They can either be part of a matrix keymap (in which case
> > events will be handled by an input device) or they can be gpi's (in which
> > case events will be handled by the gpiochip device via gpio_keys). There's
> > also support for unlock keys as for reset keys.
> 
> There's lots of code below specific to matrix keypad handling. Please
> move it to the keypad driver, and keep this driver as lean as possible.

Exactly this.  MFD shouldn't need to contain anything that should be
handed in the leaf drivers.  Keypad handling should be processed by
keypad driver, etc.  If the GPIO driver needs to have visibility into
keypad API, add some exported helpers in the Keyoad driver.

-- 
Lee Jones [李琼斯]