Re: [PATCH v2 06/17] mfd: adp5585: add support for adp5589

[Lee Jones <lee@kernel.org>]

On Tue, 15 Apr 2025, Nuno Sá via B4 Relay wrote:

> From: Nuno Sá <nuno.sa@analog.com>
> 
> The ADP5589 is a 19 I/O port expander with built-in keypad matrix decoder,
> programmable logic, reset generator, and PWM generator.
> 
> This patch adds the foundation to add support for the adp5589 gpio and pwm
> drivers. Most importantly, we need to differentiate between some
> registers addresses. It also hints to future keymap support.
> 
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
>  drivers/mfd/adp5585.c       | 223 +++++++++++++++++++++++++++++++++++++++++---
>  include/linux/mfd/adp5585.h |  57 ++++++++++-
>  2 files changed, 268 insertions(+), 12 deletions(-)

[...]

> + * Bank 0 covers pins "GPIO 1/R0" to "GPIO 8/R7", numbered 0 to 7 by the
> + * driver, bank 1 covers pins "GPIO 9/C0" to "GPIO 16/C7", numbered 8 to
> + * 15 and bank 3 covers pins "GPIO 17/C8" to "GPIO 19/C10", numbered 16 to 18.
> + */
> +#define ADP5589_BANK(n)			((n) >> 3)
> +#define ADP5589_BIT(n)			BIT((n) & 0x7)
> +
> +struct adp5585_regs {
> +	unsigned int debounce_dis_a;
> +	unsigned int rpull_cfg_a;
> +	unsigned int gpo_data_a;
> +	unsigned int gpo_out_a;
> +	unsigned int gpio_dir_a;
> +	unsigned int gpi_stat_a;
> +	unsigned int pwm_cfg;
> +	unsigned int pwm_offt_low;
> +	unsigned int pwm_ont_low;
> +	unsigned int gen_cfg;
> +	unsigned int ext_cfg;
> +};
> +
> +struct adp5585_info {
> +	const struct mfd_cell *adp5585_devs;

Okay, we are never doing this.  Either use OF for platform registration
or use MFD (or ACPI or PCI), but please do not pass MFD data through OF.

> +	const struct regmap_config *regmap_config;
> +	const struct adp5585_regs *regs;
> +	unsigned int n_devs;
> +	unsigned int id;

What ID is this?  We already have platform IDs and MFD cell IDs.

> +	u8 max_rows;
> +	u8 max_cols;
> +};
> +
>  struct regmap;
>  
>  struct adp5585_dev {
>  	struct regmap *regmap;
> +	const struct adp5585_info *info;
>  };
>  
>  #endif
> 
> -- 
> 2.49.0
> 
> 

-- 
Lee Jones [李琼斯]