From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19B4F22D7A7; Fri, 25 Apr 2025 07:48:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745567303; cv=none; b=GvLgh+B78PVgV5BPexddGZ6t6K7PeFviZenJnHsZNCH0WZpbPFfr6m+ueZZRfp4K/LiJh4jETUXH9ahtbIC8bebVft4KXgPf9Sov5wHjr+tGRoUhPM6dvorAvGs/H3IxT6Ud8KdS4vCaJkWFeot/eHrCE+qOc2cQycTVbl8KIDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745567303; c=relaxed/simple; bh=jpBGvqF1vhLelKCM+qa40XIBkSN7Xd7BZS/mEIX6rmg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kEms8tvoouxBRvjMkNZAg7h61pLiMKdMJL5VElUsRDGBT6XOl4qHPMxIVBhtEPJmmOf+jKCghEkcHP091nxatyqNEtesiWh2fr+4veaoRWOvyPwhT49FA4mar/DpnPbbtFfd2gmzgcotk27xfgZJUq8hezp2+3y4A4E+5zvtpgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q1Z9LDOL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q1Z9LDOL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3F0AC4CEE4; Fri, 25 Apr 2025 07:48:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745567302; bh=jpBGvqF1vhLelKCM+qa40XIBkSN7Xd7BZS/mEIX6rmg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q1Z9LDOLe8KEKfAKnMyLYXFqw1Ao+8PnjVcu3u87fGhcykICD0LzaBHMw792sdjnQ 9CkZFsnFkTUWmFtbtrvpqHuo7CSVX5YXJBASK5avvKhaZTUHLxW3KEkMwDOf/mQI9Y RtLwSlTKnd/jtQ4xPsby2lOx47vi1I2BYPsrZj6dKAuzQ8apes2/Zlp1BAEkWlAEs/ tA/mexzcFSn8NDWQ7+GeysL9OAyqOfGYRY+UVBZZV1Lpctq+zeNQ6PQcYsj33FUDvC OYwdFfPpnWWSghVEkpekzvxikVSWK1KRaAQ6pxXEEYrEVV3vXPsmNhoXw5sCgZ8d5v 5mPZKjd7ucYkA== Date: Fri, 25 Apr 2025 09:48:19 +0200 From: Krzysztof Kozlowski To: Judith Mendez Cc: Ulf Hansson , Nishanth Menon , Adrian Hunter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vignesh Raghavendra , Tero Kristo , Josua Mayer , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Francesco Dolcini , Hiago De Franco , Moteen Shah , stable@vger.kernel.org Subject: Re: [PATCH RESEND v3 1/3] dt-bindings: mmc: sdhci-am654: Add ti,suppress-v1p8-ena Message-ID: <20250425-agile-imported-inchworm-6ae257@kuoka> References: <20250422220512.297396-1-jm@ti.com> <20250422220512.297396-2-jm@ti.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250422220512.297396-2-jm@ti.com> On Tue, Apr 22, 2025 at 05:05:10PM GMT, Judith Mendez wrote: > Some Microcenter/Patriot SD cards and Kingston eMMC are failing init > across Sitara K3 boards. Init failure is due to the sequence when > V1P8_SIGNAL_ENA is set. The V1P8_SIGNAL_ENA has a timing component tied > to it where if set, switch to full-cycle timing happens. The failing > cards do not like change to full-cycle timing before changing bus > width, so add flag to sdhci-am654 binding to suppress V1P8_SIGNAL_ENA > before changing bus width. The switch to full-cycle timing should happen > with HIGH_SPEED_ENA after change of bus width. > > Signed-off-by: Judith Mendez > --- > Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml > index 676a74695389..0f92bbf8e13b 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml > +++ b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml > @@ -201,6 +201,11 @@ properties: > and the controller is required to be forced into Test mode > to set the TESTCD bit. > > + ti,suppress-v1p8-ena: Do not tell what the drivers should do, but tell what is the issue with the hardware, e.g. some cards do not like full-cycle.... and this will also hint you that it should be most likely generic, not specific to this device. > + $ref: /schemas/types.yaml#/definitions/flag > + description: Best regards, Krzysztof