Re: [PATCH v4 1/2] dt-bindings: arm: vt8500: Add VIA APC Rock/Paper boards

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1927 bytes --]

On Fri, Apr 25, 2025 at 06:34:13PM +0400, Alexey Charkov wrote:
> APC Rock is a development board based on WonderMedia WM8950 SoC
> released around 2013. Paper is the same as Rock but lacking a
> VGA port and shipped with a recycled cardboard case.
> 
> While at that, put myself as the maintainer, given that Tony is
> unavailable as of lately.
> 
> Signed-off-by: Alexey Charkov <alchark@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/vt8500.yaml | 23 ++++++++++++++---------
>  1 file changed, 14 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/vt8500.yaml b/Documentation/devicetree/bindings/arm/vt8500.yaml
> index 5d5ad5a60451f569e6ef30c924a1964d02e1aa82..f2164144a7af29ca77761bc58fe7f4558e7d101c 100644
> --- a/Documentation/devicetree/bindings/arm/vt8500.yaml
> +++ b/Documentation/devicetree/bindings/arm/vt8500.yaml
> @@ -7,19 +7,24 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>  title: VIA/Wondermedia VT8500 Platforms
>  
>  maintainers:
> -  - Tony Prisk <linux@prisktech.co.nz>
> -description: test
> +  - Alexey Charkov <alchark@gmail.com>
>  
>  properties:
>    $nodename:
>      const: '/'
>    compatible:
> -    items:
> -      - enum:
> -          - via,vt8500
> -          - wm,wm8505
> -          - wm,wm8650
> -          - wm,wm8750
> -          - wm,wm8850
> +    oneOf:
> +      - items:
> +          - enum:

This should just simplify from "items: - enum:" to "enum:".
With that,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

> +              - via,vt8500
> +              - wm,wm8505
> +              - wm,wm8650
> +              - wm,wm8750
> +              - wm,wm8850
> +
> +      - description: VIA APC Rock and Paper boards
> +        items:
> +          - const: via,apc-rock
> +          - const: wm,wm8950
>  
>  additionalProperties: true
> 
> -- 
> 2.49.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]