[PATCH 0/4] Add vcc-supply to SPI flash on Pine64 devices + Rock 5B

[PATCH 0/4] Add vcc-supply to SPI flash on Pine64 devices + Rock 5B

[Diederik de Haas]

The vcc-supply property was added to "jedec,spi-nor" binding in commit:
e7f4e924f46d ("dt-bindings: mtd: jedec,spi-nor: add optional vcc-supply")

which resulted in the following warning:
  spi-nor spiN.0: supply vcc not found, using dummy regulator

Fix that by specifying the vcc-supply property.

Diederik de Haas (4):
  arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3328-rock64
  arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3399-rockpro64
  arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3566-pinetab2
  arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3588-rock-5b

 arch/arm64/boot/dts/rockchip/rk3328-rock64.dts     | 1 +
 arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 1 +
 arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi  | 1 +
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts    | 1 +
 4 files changed, 4 insertions(+)

-- 
2.49.0

[PATCH 1/4] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3328-rock64

[Diederik de Haas]

As described on page 6 of the Rock64 schematics for both v2.0 and v3.0
the SPI Flash's VCC connector is connected to the VCC_IO power source.

This fixes the following warning:

  spi-nor spi0.0: supply vcc not found, using dummy regulator

Fixes: e7f4e924f46d ("dt-bindings: mtd: jedec,spi-nor: add optional vcc-supply")
Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
 arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index e550b6eeeff3..5367e5fa9232 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -343,6 +343,7 @@ flash@0 {
 
 		/* maximum speed for Rockchip SPI */
 		spi-max-frequency = <50000000>;
+		vcc-supply = <&vcc_io>;
 	};
 };
 
-- 
2.49.0

[PATCH 2/4] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3399-rockpro64

[Diederik de Haas]

As described on page 16 of the RockPro64 schematics for both v2.0 and
v2.1, the SPI Flash's VCC connector is connected to the VCC_3V0 power
source.

This fixes the following warning:

  spi-nor spi1.0: supply vcc not found, using dummy regulator

Fixes: e7f4e924f46d ("dt-bindings: mtd: jedec,spi-nor: add optional vcc-supply")
Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
 arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
index 51c6aa26d828..a7e4adf87e7a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
@@ -850,6 +850,7 @@ flash@0 {
 		compatible = "jedec,spi-nor";
 		reg = <0>;
 		spi-max-frequency = <10000000>;
+		vcc-supply = <&vcc_3v0>;
 	};
 };
 
-- 
2.49.0

[PATCH 3/4] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3566-pinetab2

[Diederik de Haas]

As described on page 37 of PineTab2 Schematic-20230417, the SPI Flash's
VCC connector is connected to VCCIO_FLASH and according to page 6 of
that same schematic, that belongs to the VCC_1V8 power source.

This fixes the following warning:

  spi-nor spi4.0: supply vcc not found, using dummy regulator

Fixes: e7f4e924f46d ("dt-bindings: mtd: jedec,spi-nor: add optional vcc-supply")
Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
 arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
index 26cf765a7297..3473b1eef5cd 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
@@ -867,6 +867,7 @@ flash@0 {
 		spi-max-frequency = <100000000>;
 		spi-rx-bus-width = <2>;
 		spi-tx-bus-width = <1>;
+		vcc-supply = <&vcc_1v8>;
 	};
 };
 
-- 
2.49.0

[PATCH 4/4] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3588-rock-5b

[Diederik de Haas]

The Radxa Rock 5B component placement document identifies the SPI Nor
Flash chip as 'U4300' which is described on page 25 of the Schematic
v1.45. There we can see that the VCC connector is connected to the
VCC_3V3_S3 power source.

This fixes the following warning:

  spi-nor spi5.0: supply vcc not found, using dummy regulator

Fixes: e7f4e924f46d ("dt-bindings: mtd: jedec,spi-nor: add optional vcc-supply")
Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index d22068475c5d..17f4fd054cd3 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -562,6 +562,7 @@ flash@0 {
 		spi-max-frequency = <104000000>;
 		spi-rx-bus-width = <4>;
 		spi-tx-bus-width = <1>;
+		vcc-supply = <&vcc_3v3_s3>;
 	};
 };
 
-- 
2.49.0

Re: [PATCH 0/4] Add vcc-supply to SPI flash on Pine64 devices + Rock 5B

[Heiko Stuebner]

On Fri, 25 Apr 2025 10:44:40 +0200, Diederik de Haas wrote:
> The vcc-supply property was added to "jedec,spi-nor" binding in commit:
> e7f4e924f46d ("dt-bindings: mtd: jedec,spi-nor: add optional vcc-supply")
> 
> which resulted in the following warning:
>   spi-nor spiN.0: supply vcc not found, using dummy regulator
> 
> Fix that by specifying the vcc-supply property.
> 
> [...]

Applied, thanks!

[1/4] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3328-rock64
      commit: 4ed658ebd7b506d468c0e28b724390b31abe1875
[2/4] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3399-rockpro64
      commit: b630cf92dd49f6a4df06508969a2eeeba6fd946f
[3/4] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3566-pinetab2
      commit: 4754eea38f5df6ad03cd93a4fa800d017cc5be82
[4/4] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3588-rock-5b
      commit: 67beb6b123187eaddb954fa9b070932452246d29

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>