Re: [PATCH v4 3/5] PCI: cadence: Add header support for PCIe HPA controller

[kernel test robot <lkp@intel.com>]

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on fc96b232f8e7c0a6c282f47726b2ff6a5fb341d2]

url:    https://github.com/intel-lab-lkp/linux/commits/hans-zhang-cixtech-com/dt-bindings-pci-cadence-Extend-compatible-for-new-RP-configuration/20250424-090651
base:   fc96b232f8e7c0a6c282f47726b2ff6a5fb341d2
patch link:    https://lore.kernel.org/r/20250424010445.2260090-4-hans.zhang%40cixtech.com
patch subject: [PATCH v4 3/5] PCI: cadence: Add header support for PCIe HPA controller
config: i386-buildonly-randconfig-003-20250425 (https://download.01.org/0day-ci/archive/20250425/202504251214.ngJwGxvn-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250425/202504251214.ngJwGxvn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504251214.ngJwGxvn-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/pci/controller/cadence/pcie-cadence.c:9:
>> drivers/pci/controller/cadence/pcie-cadence.h:851:8: error: expected ')'
     851 |                                                  int where)
         |                                                  ^
   drivers/pci/controller/cadence/pcie-cadence.h:850:49: note: to match this '('
     850 | static inline void __iomem *cdns_pci_hpa_map_bus(struct pci_bus *bus, unsigned int devfn
         |                                                 ^
   1 error generated.


vim +851 drivers/pci/controller/cadence/pcie-cadence.h

   811	
   812	#ifdef CONFIG_PCIE_CADENCE_HOST
   813	int cdns_pcie_host_link_setup(struct cdns_pcie_rc *rc);
   814	int cdns_pcie_host_init(struct cdns_pcie_rc *rc);
   815	int cdns_pcie_host_setup(struct cdns_pcie_rc *rc);
   816	void __iomem *cdns_pci_map_bus(struct pci_bus *bus, unsigned int devfn,
   817				       int where);
   818	int cdns_pcie_host_init_root_port(struct cdns_pcie_rc *rc);
   819	int cdns_pcie_host_bar_ib_config(struct cdns_pcie_rc *rc,
   820					 enum cdns_pcie_rp_bar bar,
   821					 u64 cpu_addr, u64 size,
   822					 unsigned long flags);
   823	int cdns_pcie_host_init_address_translation(struct cdns_pcie_rc *rc);
   824	void __iomem *cdns_pci_hpa_map_bus(struct pci_bus *bus, unsigned int devfn, int where);
   825	int cdns_pcie_hpa_host_init_root_port(struct cdns_pcie_rc *rc);
   826	int cdns_pcie_hpa_host_bar_ib_config(struct cdns_pcie_rc *rc,
   827					     enum cdns_pcie_rp_bar bar,
   828					     u64 cpu_addr, u64 size,
   829					     unsigned long flags);
   830	int cdns_pcie_hpa_host_init_address_translation(struct cdns_pcie_rc *rc);
   831	int cdns_pcie_hpa_host_init(struct cdns_pcie_rc *rc);
   832	#else
   833	static inline int cdns_pcie_host_link_setup(struct cdns_pcie_rc *rc)
   834	{
   835		return 0;
   836	}
   837	static inline int cdns_pcie_host_init(struct cdns_pcie_rc *rc)
   838	{
   839		return 0;
   840	}
   841	static inline int cdns_pcie_host_setup(struct cdns_pcie_rc *rc)
   842	{
   843		return 0;
   844	}
   845	static inline void __iomem *cdns_pci_map_bus(struct pci_bus *bus, unsigned int devfn,
   846						     int where)
   847	{
   848		return NULL;
   849	}
   850	static inline void __iomem *cdns_pci_hpa_map_bus(struct pci_bus *bus, unsigned int devfn
 > 851							 int where)
   852	{
   853		return NULL;
   854	}
   855	static inline int cdns_pcie_hpa_host_init_root_port(struct cdns_pcie_rc *rc)
   856	{
   857		return 0;
   858	}
   859	static inline int cdns_pcie_hpa_host_bar_ib_config(struct cdns_pcie_rc *rc,
   860							   enum cdns_pcie_rp_bar bar,
   861							   u64 cpu_addr, u64 size,
   862							   unsigned long flags)
   863	{
   864		return 0;
   865	}
   866	static inline int cdns_pcie_hpa_host_init_address_translation(struct cdns_pcie_rc *rc)
   867	{
   868		return 0;
   869	}
   870	#endif
   871	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki