From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: Sayyad Abid <sayyad.abid16@gmail.com>,
linux-iio@vger.kernel.org, lars@metafoo.de, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, nuno.sa@analog.com,
javier.carrasco.cruz@gmail.com, olivier.moysan@foss.st.com,
gstols@baylibre.com, tgamblin@baylibre.com,
alisadariana@gmail.com, eblanc@baylibre.com,
antoniu.miclaus@analog.com, andriy.shevchenko@linux.intel.com,
stefan.popa@analog.com, ramona.gradinariu@analog.com,
herve.codina@bootlin.com, tobias.sperling@softing.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/5] iio: adc: Kconfig: add Kconfig entry for TI ADS1262 driver
Date: Sun, 4 May 2025 16:55:20 +0100 [thread overview]
Message-ID: <20250504165520.4fc0920d@jic23-huawei> (raw)
In-Reply-To: <213ae3d3-b6d1-4808-9af3-36a8cc1f1335@baylibre.com>
On Thu, 1 May 2025 12:37:35 -0500
David Lechner <dlechner@baylibre.com> wrote:
> On 5/1/25 5:00 AM, Sayyad Abid wrote:
> > Adds the Kconfig option `CONFIG_TI_ADS1262` under the IIO ADC menu.
> > This allows users to select the TI ADS1262 driver for compilation
> > during kernel configuration.
> >
> > Signed-off-by: Sayyad Abid <sayyad.abid16@gmail.com>
> > ---
> This can be in the same patch as the driver. Same with the makefile - it doesn't
> need to be a separate patch.
Change that from can to should / must. There are some bits of the kernel
that run a different approach for complex multi patch drivers but for
IIO we want everything to be building at each step of the series.
Personally I see that as good practice and I don't know of any part of the
kernel where the maintainers reject that approach, just some where they
don't mind as much if a complex driver is built up and only compiled in
the final patch
Thanks,
Jonathan
next prev parent reply other threads:[~2025-05-04 15:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 10:00 [RFC PATCH 0/5] iio: adc: Add initial support for TI ADS1262 Sayyad Abid
2025-05-01 10:00 ` [RFC PATCH 1/5] iio: adc: ti-ads1262.c: add initial driver for TI ADS1262 ADC Sayyad Abid
2025-05-01 17:37 ` David Lechner
2025-05-02 10:07 ` Andy Shevchenko
2025-05-04 16:20 ` Jonathan Cameron
2025-05-01 10:00 ` [RFC PATCH 2/5] iio: adc: Kconfig: add Kconfig entry for TI ADS1262 driver Sayyad Abid
2025-05-01 17:37 ` David Lechner
2025-05-04 15:55 ` Jonathan Cameron [this message]
2025-05-01 10:00 ` [RFC PATCH 3/5] iio: adc: Makefile: add compile support " Sayyad Abid
2025-05-01 10:00 ` [RFC PATCH 4/5] MAINTAINERS: add entry for TI ADS1262 ADC driver Sayyad Abid
2025-05-04 16:02 ` Jonathan Cameron
2025-05-01 10:00 ` [RFC PATCH 5/5] dt-bindings: iio: adc: add bindings for TI ADS1262 Sayyad Abid
2025-05-01 14:51 ` Conor Dooley
2025-05-01 17:37 ` David Lechner
2025-05-04 16:01 ` Jonathan Cameron
2025-05-01 18:20 ` [RFC PATCH 0/5] iio: adc: Add initial support " David Lechner
2025-05-02 9:52 ` Andy Shevchenko
2025-05-04 16:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250504165520.4fc0920d@jic23-huawei \
--to=jic23@kernel.org \
--cc=alisadariana@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=eblanc@baylibre.com \
--cc=gstols@baylibre.com \
--cc=herve.codina@bootlin.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=ramona.gradinariu@analog.com \
--cc=robh@kernel.org \
--cc=sayyad.abid16@gmail.com \
--cc=stefan.popa@analog.com \
--cc=tgamblin@baylibre.com \
--cc=tobias.sperling@softing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox