[PATCH] dt-bindings: interrupt-controller: Convert marvell,orion-bridge-intc to DT schema

[PATCH] dt-bindings: interrupt-controller: Convert marvell,orion-bridge-intc to DT schema

[Rob Herring (Arm)]

Convert the Marvell Orion bridge interrupt controller binding to schema
format.

marvell,orion-intc is already covered by mrvl,intc.yaml schema, so it
can be dropped.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../marvell,orion-bridge-intc.yaml            | 53 +++++++++++++++++++
 .../marvell,orion-intc.txt                    | 48 -----------------
 2 files changed, 53 insertions(+), 48 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml
 delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,orion-intc.txt

diff --git a/Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml
new file mode 100644
index 000000000000..d71ae877f488
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+---
+$id: http://devicetree.org/schemas/interrupt-controller/marvell,orion-bridge-intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell Orion SoC Bridge Interrupt Controller
+
+maintainers:
+  - Andrew Lunn <andrew@lunn.ch>
+  - Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
+  - Gregory Clement <gregory.clement@bootlin.com>
+
+properties:
+  compatible:
+    const: marvell,orion-bridge-intc
+
+  reg:
+    minItems: 1
+    maxItems: 2
+
+  interrupt-controller: true
+
+  '#interrupt-cells':
+    const: 1
+
+  interrupts:
+    description: Bridge interrupt of the main interrupt controller
+
+  marvell,#interrupts:
+    description: Number of interrupts provided by bridge interrupt controller.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    default: 32
+
+required:
+  - compatible
+  - reg
+  - interrupt-controller
+  - '#interrupt-cells'
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    interrupt-controller@20110 {
+        compatible = "marvell,orion-bridge-intc";
+        reg = <0x20110 0x8>;
+        interrupt-controller;
+        #interrupt-cells = <1>;
+        interrupts = <0>;
+        /* Dove bridge provides 5 interrupts */
+        marvell,#interrupts = <5>;
+    };
diff --git a/Documentation/devicetree/bindings/interrupt-controller/marvell,orion-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/marvell,orion-intc.txt
deleted file mode 100644
index 2c11ac76fac9..000000000000
--- a/Documentation/devicetree/bindings/interrupt-controller/marvell,orion-intc.txt
+++ /dev/null
@@ -1,48 +0,0 @@
-Marvell Orion SoC interrupt controllers
-
-* Main interrupt controller
-
-Required properties:
-- compatible: shall be "marvell,orion-intc"
-- reg: base address(es) of interrupt registers starting with CAUSE register
-- interrupt-controller: identifies the node as an interrupt controller
-- #interrupt-cells: number of cells to encode an interrupt source, shall be 1
-
-The interrupt sources map to the corresponding bits in the interrupt
-registers, i.e.
-- 0 maps to bit 0 of first base address,
-- 1 maps to bit 1 of first base address,
-- 32 maps to bit 0 of second base address, and so on.
-
-Example:
-	intc: interrupt-controller {
-		compatible = "marvell,orion-intc";
-		interrupt-controller;
-		#interrupt-cells = <1>;
-		 /* Dove has 64 first level interrupts */
-		reg = <0x20200 0x10>, <0x20210 0x10>;
-	};
-
-* Bridge interrupt controller
-
-Required properties:
-- compatible: shall be "marvell,orion-bridge-intc"
-- reg: base address of bridge interrupt registers starting with CAUSE register
-- interrupts: bridge interrupt of the main interrupt controller
-- interrupt-controller: identifies the node as an interrupt controller
-- #interrupt-cells: number of cells to encode an interrupt source, shall be 1
-
-Optional properties:
-- marvell,#interrupts: number of interrupts provided by bridge interrupt
-      controller, defaults to 32 if not set
-
-Example:
-	bridge_intc: interrupt-controller {
-		compatible = "marvell,orion-bridge-intc";
-		interrupt-controller;
-		#interrupt-cells = <1>;
-		reg = <0x20110 0x8>;
-		interrupts = <0>;
-		/* Dove bridge provides 5 interrupts */
-		marvell,#interrupts = <5>;
-	};
-- 
2.47.2

Re: [PATCH] dt-bindings: interrupt-controller: Convert marvell,orion-bridge-intc to DT schema

[Andrew Lunn]

> +++ b/Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/marvell,orion-bridge-intc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Orion SoC Bridge Interrupt Controller
> +
> +maintainers:
> +  - Andrew Lunn <andrew@lunn.ch>
> +  - Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>

You should probably drop Sebastian. I've not heard from him in years.

Apart from that:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH] dt-bindings: interrupt-controller: Convert marvell,orion-bridge-intc to DT schema

[Rob Herring]

On Mon, May 5, 2025 at 10:09 AM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml
> > @@ -0,0 +1,53 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +---
> > +$id: http://devicetree.org/schemas/interrupt-controller/marvell,orion-bridge-intc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell Orion SoC Bridge Interrupt Controller
> > +
> > +maintainers:
> > +  - Andrew Lunn <andrew@lunn.ch>
> > +  - Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>
> You should probably drop Sebastian. I've not heard from him in years.

Okay. I would have (probably) if he was not still listed in
MAINTAINERS. Perhaps should be dropped from there too?

Note that the lists here were all generated from what MAINTAINERS said
(if anything) or the author(s) of the original .txt binding.

Rob

Re: [PATCH] dt-bindings: interrupt-controller: Convert marvell,orion-bridge-intc to DT schema

[Andrew Lunn]

On Mon, May 05, 2025 at 11:01:27AM -0500, Rob Herring wrote:
> On Mon, May 5, 2025 at 10:09 AM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > > +++ b/Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml
> > > @@ -0,0 +1,53 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +---
> > > +$id: http://devicetree.org/schemas/interrupt-controller/marvell,orion-bridge-intc.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Marvell Orion SoC Bridge Interrupt Controller
> > > +
> > > +maintainers:
> > > +  - Andrew Lunn <andrew@lunn.ch>
> > > +  - Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> >
> > You should probably drop Sebastian. I've not heard from him in years.
> 
> Okay. I would have (probably) if he was not still listed in
> MAINTAINERS. Perhaps should be dropped from there too?

Yes.

Jakub Kicinski has a script he runs about once a year which compares
MAINTAINER entries for networking against activity on the netdev
list. Any email address which has not been active for a few years gets
a patch to remove it from MAINTAINERS and sometimes add an entry to
CREDITs. Maybe this can be generalised, run it against all the lore
archive?

	Andrew