From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Santos <Jonathan.Santos@analog.com>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<andy@kernel.org>, <nuno.sa@analog.com>,
<Michael.Hennerich@analog.com>, <marcelo.schmitt@analog.com>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<marcelo.schmitt1@gmail.com>, <linus.walleij@linaro.org>,
<brgl@bgdev.pl>, <lgirdwood@gmail.com>, <broonie@kernel.org>,
<jonath4nns@gmail.com>, <dlechner@baylibre.com>
Subject: Re: [PATCH v6 01/11] dt-bindings: trigger-source: add generic GPIO trigger source
Date: Mon, 5 May 2025 16:44:01 +0100 [thread overview]
Message-ID: <20250505164401.64cd3da7@jic23-huawei> (raw)
In-Reply-To: <f76579f8aa040125568c044c86761211a2e2f5ae.1745605382.git.Jonathan.Santos@analog.com>
On Sun, 27 Apr 2025 21:12:02 -0300
Jonathan Santos <Jonathan.Santos@analog.com> wrote:
> Inspired by pwm-trigger, create a new binding for using a GPIO
> line as a trigger source.
>
> Link: https://lore.kernel.org/linux-iio/20250207-dlech-mainline-spi-engine-offload-2-v8-3-e48a489be48c@baylibre.com/
David, given you did the pwm one, maybe give this a quick look.
Maybe it's worth generalising to cover all trigger sources in MAINTAINERS?
Thanks. Otherwise I obviously need a DT review before taking this and maybe the GPIO
element suggests Linus W or Bartosz might be other good reviewers?
Jonathan
> Signed-off-by: Jonathan Santos <Jonathan.Santos@analog.com>
> ---
> v6 Changes:
> * Changed description.
> * Fixed typos and replaced GPIO pin with GPIO line.
> * Added link reference for pwm-trigger.
>
> v5 Changes:
> * New patch in v5.
> ---
> .../bindings/trigger-source/gpio-trigger.yaml | 40 +++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/trigger-source/gpio-trigger.yaml
>
> diff --git a/Documentation/devicetree/bindings/trigger-source/gpio-trigger.yaml b/Documentation/devicetree/bindings/trigger-source/gpio-trigger.yaml
> new file mode 100644
> index 000000000000..1331d153ee82
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/trigger-source/gpio-trigger.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/trigger-source/gpio-trigger.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Generic trigger source using GPIO
> +
> +description: A GPIO used as a trigger source.
> +
> +maintainers:
> + - Jonathan Santos <Jonathan.Santos@analog.com>
> +
> +properties:
> + compatible:
> + const: gpio-trigger
> +
> + '#trigger-source-cells':
> + const: 0
> +
> + gpios:
> + maxItems: 1
> + description: GPIO to be used as a trigger source.
> +
> +required:
> + - compatible
> + - '#trigger-source-cells'
> + - gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + trigger {
> + compatible = "gpio-trigger";
> + #trigger-source-cells = <0>;
> + gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
> + };
next prev parent reply other threads:[~2025-05-05 15:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 0:11 [PATCH v6 00/11] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-04-28 0:12 ` [PATCH v6 01/11] dt-bindings: trigger-source: add generic GPIO trigger source Jonathan Santos
2025-05-05 15:44 ` Jonathan Cameron [this message]
2025-05-05 15:56 ` David Lechner
2025-05-13 9:32 ` Linus Walleij
2025-04-28 0:12 ` [PATCH v6 02/11] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-04-30 18:46 ` David Lechner
2025-05-05 15:39 ` Jonathan Cameron
2025-05-06 19:16 ` Jonathan Santos
2025-05-07 19:50 ` Jonathan Cameron
2025-04-28 0:12 ` [PATCH v6 03/11] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-04-28 0:12 ` [PATCH v6 04/11] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-04-28 0:13 ` [PATCH v6 05/11] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-04-28 6:42 ` Andy Shevchenko
2025-04-30 23:24 ` Jonathan Santos
2025-04-30 18:43 ` David Lechner
2025-04-28 0:13 ` [PATCH v6 06/11] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-04-28 6:50 ` Andy Shevchenko
2025-04-30 23:37 ` Jonathan Santos
2025-04-28 0:13 ` [PATCH v6 07/11] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-04-28 6:55 ` Andy Shevchenko
2025-05-05 15:52 ` Jonathan Cameron
2025-05-02 14:30 ` Marcelo Schmitt
2025-04-28 0:13 ` [PATCH v6 08/11] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-04-28 7:04 ` Andy Shevchenko
2025-05-01 0:03 ` Jonathan Santos
2025-04-30 19:07 ` David Lechner
2025-05-05 15:59 ` Jonathan Cameron
2025-04-28 0:14 ` [PATCH v6 09/11] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-04-28 7:10 ` Andy Shevchenko
2025-04-28 0:14 ` [PATCH v6 10/11] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-04-29 22:40 ` Andy Shevchenko
2025-05-05 16:09 ` Jonathan Cameron
2025-05-06 19:03 ` Jonathan Santos
2025-05-06 19:10 ` David Lechner
2025-04-28 0:14 ` [PATCH v6 11/11] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505164401.64cd3da7@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Santos@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jonath4nns@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).