From: Conor Dooley <conor@kernel.org>
To: Pankit Garg <pankit.garg@nxp.com>
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, conor+dt@kernel.org,
robh@kernel.org, alexandre.belloni@bootlin.com,
vikash.bansal@nxp.com, priyanka.jain@nxp.com,
daniel.aguirre@nxp.com, shashank.rebbapragada@nxp.com,
aman.kumarpandey@nxp.com
Subject: Re: [PATCH v2 1/2] dt-bindings: rtc: Add pcf85053a support
Date: Tue, 6 May 2025 16:48:42 +0100 [thread overview]
Message-ID: <20250506-durable-cryptic-24119a6e7dbd@spud> (raw)
In-Reply-To: <20250506094815.3765598-1-pankit.garg@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]
On Tue, May 06, 2025 at 03:18:14PM +0530, Pankit Garg wrote:
> Add device tree bindings for NXP PCF85053a RTC chip.
>
> Signed-off-by: Pankit Garg <pankit.garg@nxp.com>
> ---
> V1 -> V2: Handled dt-bindings by trivial-rtc.yaml
>
> ---
> Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++
> MAINTAINERS | 5 +++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> index 7330a7200831..47be7bbbfedd 100644
> --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> @@ -65,6 +65,8 @@ properties:
> - microcrystal,rv8523
> # NXP LPC32xx SoC Real-time Clock
> - nxp,lpc3220-rtc
> + # NXP PCF85053A Real Time Clock Module with I2C-Bus
> + - nxp,pcf85053a
Acked-by: Conor Dooley <conor.dooley@microchip.com>
> # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
> - ricoh,r2025sd
> # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0737dcb2e411..d39fc05c6454 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17782,6 +17782,11 @@ S: Maintained
> F: Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> F: sound/soc/codecs/tfa989x.c
>
> +NXP RTC PCF85053A DRIVER
> +M: Pankit Garg<pankit.garg@nxp.com>
> +L: linux-kernel@vger.kernel.org
> +S: Maintained
This looks like a hang-over from your v1 and should really be moved
to the patch adding the driver.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-05-06 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 9:48 [PATCH v2 1/2] dt-bindings: rtc: Add pcf85053a support Pankit Garg
2025-05-06 9:48 ` [PATCH v2 2/2] rtc: Add NXP PCF85053A driver support Pankit Garg
2025-05-06 15:48 ` Conor Dooley [this message]
2025-05-07 7:31 ` [EXT] Re: [PATCH v2 1/2] dt-bindings: rtc: Add pcf85053a support Pankit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250506-durable-cryptic-24119a6e7dbd@spud \
--to=conor@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=aman.kumarpandey@nxp.com \
--cc=conor+dt@kernel.org \
--cc=daniel.aguirre@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=pankit.garg@nxp.com \
--cc=priyanka.jain@nxp.com \
--cc=robh@kernel.org \
--cc=shashank.rebbapragada@nxp.com \
--cc=vikash.bansal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox