[PATCH] dt-bindings: serial: Convert arm,sbsa-uart to DT schema

[PATCH] dt-bindings: serial: Convert arm,sbsa-uart to DT schema

[Rob Herring (Arm)]

Convert the Arm SBSA UART binding to DT schema. It is a straight-forward
conversion.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../bindings/serial/arm,sbsa-uart.yaml        | 38 +++++++++++++++++++
 .../bindings/serial/arm_sbsa_uart.txt         | 10 -----
 2 files changed, 38 insertions(+), 10 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
 delete mode 100644 Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt

diff --git a/Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml b/Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
new file mode 100644
index 000000000000..68e3fd64b1d8
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+---
+$id: http://devicetree.org/schemas/serial/arm,sbsa-uart.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ARM SBSA UART
+
+maintainers:
+  - Andre Przywara <andre.przywara@arm.com>
+
+description:
+  This UART uses a subset of the PL011 registers and consequently lives in the
+  PL011 driver. It's baudrate and other communication parameters cannot be
+  adjusted at runtime, so it lacks a clock specifier here.
+
+allOf:
+  - $ref: /schemas/serial/serial.yaml#
+
+properties:
+  compatible:
+    const: arm,sbsa-uart
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  current-speed:
+    description: fixed baud rate set by the firmware
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - current-speed
+
+unevaluatedProperties: false
diff --git a/Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt b/Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt
deleted file mode 100644
index 4163e7eb7763..000000000000
--- a/Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt
+++ /dev/null
@@ -1,10 +0,0 @@
-* ARM SBSA defined generic UART
-This UART uses a subset of the PL011 registers and consequently lives
-in the PL011 driver. It's baudrate and other communication parameters
-cannot be adjusted at runtime, so it lacks a clock specifier here.
-
-Required properties:
-- compatible: must be "arm,sbsa-uart"
-- reg: exactly one register range
-- interrupts: exactly one interrupt specifier
-- current-speed: the (fixed) baud rate set by the firmware
-- 
2.47.2

Re: [PATCH] dt-bindings: serial: Convert arm,sbsa-uart to DT schema

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

On Tue, May 06, 2025 at 05:00:15PM -0500, Rob Herring (Arm) wrote:
> Convert the Arm SBSA UART binding to DT schema. It is a straight-forward
> conversion.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../bindings/serial/arm,sbsa-uart.yaml        | 38 +++++++++++++++++++
>  .../bindings/serial/arm_sbsa_uart.txt         | 10 -----
>  2 files changed, 38 insertions(+), 10 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
>  delete mode 100644 Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] dt-bindings: serial: Convert arm,sbsa-uart to DT schema

[Andre Przywara]

On Tue,  6 May 2025 17:00:15 -0500
"Rob Herring (Arm)" <robh@kernel.org> wrote:

> Convert the Arm SBSA UART binding to DT schema. It is a straight-forward
> conversion.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> 
> ---
>  .../bindings/serial/arm,sbsa-uart.yaml        | 38 +++++++++++++++++++
>  .../bindings/serial/arm_sbsa_uart.txt         | 10 -----
>  2 files changed, 38 insertions(+), 10 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
>  delete mode 100644 Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt
> 
> diff --git a/Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml b/Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
> new file mode 100644
> index 000000000000..68e3fd64b1d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +---
> +$id: http://devicetree.org/schemas/serial/arm,sbsa-uart.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARM SBSA UART
> +
> +maintainers:
> +  - Andre Przywara <andre.przywara@arm.com>
> +
> +description:
> +  This UART uses a subset of the PL011 registers and consequently lives in the
> +  PL011 driver. It's baudrate and other communication parameters cannot be

He said "driver" in a binding document!! ;-) I think you can remove that
part, or maybe rephrase it to say it could be supported by the same driver
that supports a PL011.

Other than that it looks alright, thanks for the conversion!

With that fixed:

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> +  adjusted at runtime, so it lacks a clock specifier here.
> +
> +allOf:
> +  - $ref: /schemas/serial/serial.yaml#
> +
> +properties:
> +  compatible:
> +    const: arm,sbsa-uart
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  current-speed:
> +    description: fixed baud rate set by the firmware
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - current-speed
> +
> +unevaluatedProperties: false
> diff --git a/Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt b/Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt
> deleted file mode 100644
> index 4163e7eb7763..000000000000
> --- a/Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -* ARM SBSA defined generic UART
> -This UART uses a subset of the PL011 registers and consequently lives
> -in the PL011 driver. It's baudrate and other communication parameters
> -cannot be adjusted at runtime, so it lacks a clock specifier here.
> -
> -Required properties:
> -- compatible: must be "arm,sbsa-uart"
> -- reg: exactly one register range
> -- interrupts: exactly one interrupt specifier
> -- current-speed: the (fixed) baud rate set by the firmware

Re: [PATCH] dt-bindings: serial: Convert arm,sbsa-uart to DT schema

[Rob Herring]

On Wed, May 7, 2025 at 10:54 AM Andre Przywara <andre.przywara@arm.com> wrote:
>
> On Tue,  6 May 2025 17:00:15 -0500
> "Rob Herring (Arm)" <robh@kernel.org> wrote:
>
> > Convert the Arm SBSA UART binding to DT schema. It is a straight-forward
> > conversion.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> >
> > ---
> >  .../bindings/serial/arm,sbsa-uart.yaml        | 38 +++++++++++++++++++
> >  .../bindings/serial/arm_sbsa_uart.txt         | 10 -----
> >  2 files changed, 38 insertions(+), 10 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt
> >
> > diff --git a/Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml b/Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
> > new file mode 100644
> > index 000000000000..68e3fd64b1d8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
> > @@ -0,0 +1,38 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +---
> > +$id: http://devicetree.org/schemas/serial/arm,sbsa-uart.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ARM SBSA UART
> > +
> > +maintainers:
> > +  - Andre Przywara <andre.przywara@arm.com>
> > +
> > +description:
> > +  This UART uses a subset of the PL011 registers and consequently lives in the
> > +  PL011 driver. It's baudrate and other communication parameters cannot be
>
> He said "driver" in a binding document!! ;-) I think you can remove that
> part, or maybe rephrase it to say it could be supported by the same driver
> that supports a PL011.

I know that's 'the rule', but I kind of think that's relevant in this
case. If we're looking for improvements, defining SBSA here might be
the place to start... But I'm not really as this is 1 of 1100
remaining I've had chatgpt to convert and then I fix all the issues.

Rob