devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Morgan <macroalpha82@gmail.com>
To: linux-sunxi@lists.linux.dev
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	ryan@testtoast.com, macromorgan@hotmail.com,
	p.zabel@pengutronix.de, tzimmermann@suse.de,
	maarten.lankhorst@linux.intel.com, simona@ffwll.ch,
	airlied@gmail.com, mripard@kernel.org, samuel@sholland.org,
	jernej.skrabec@gmail.com, wens@csie.org, conor+dt@kernel.org,
	krzk+dt@kernel.org, robh@kernel.org
Subject: [PATCH V9 09/24] dt-bindings: allwinner: add H616 DE33 mixer binding
Date: Wed,  7 May 2025 15:19:28 -0500	[thread overview]
Message-ID: <20250507201943.330111-10-macroalpha82@gmail.com> (raw)
In-Reply-To: <20250507201943.330111-1-macroalpha82@gmail.com>

From: Chris Morgan <macromorgan@hotmail.com>

The Allwinner H616 and variants have a new display engine revision
(DE33).

The mixer configuration registers are significantly different to the DE3
and DE2 revisions, being split into separate top and display blocks,
therefore a fallback for the mixer compatible is not provided.

Add a display engine mixer binding for the DE33.

Signed-off-by: Ryan Walklin <ryan@testtoast.com>
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
Changelog v2..v3:
- Separate content into three patches for three separate subsystems

Changelog v5..v6:
- Increase reg maxItems to 3 and add conditional for h616-de33

Changelog v8..v9:
- Correct conditional logic for reg items as it was not working for me
  when using dtbs_check
- Add reg-names property and description for the registers used by the
  DE33 mixer
- Removed Acked and Reviewed tags so that change can be re-reviewed.
---
 .../allwinner,sun8i-a83t-de2-mixer.yaml       | 34 +++++++++++++++++--
 1 file changed, 32 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml
index b75c1ec686ad..cbd18fd83e52 100644
--- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml
+++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml
@@ -24,9 +24,11 @@ properties:
       - allwinner,sun50i-a64-de2-mixer-0
       - allwinner,sun50i-a64-de2-mixer-1
       - allwinner,sun50i-h6-de3-mixer-0
+      - allwinner,sun50i-h616-de33-mixer-0
 
-  reg:
-    maxItems: 1
+  reg: true
+
+  reg-names: true
 
   clocks:
     items:
@@ -61,6 +63,34 @@ properties:
     required:
       - port@1
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - allwinner,sun50i-h616-de33-mixer-0
+    then:
+      properties:
+        reg:
+          description: |
+            Registers for controlling individual layers of the display
+            engine (layers), global control (top), and display blending
+            control (display). Names are from Allwinner BSP kernel.
+          maxItems: 3
+        reg-names:
+          items:
+            - const: layers
+            - const: top
+            - const: display
+      required:
+        - reg-names
+
+    else:
+      properties:
+        reg:
+          maxItems: 1
+
 required:
   - compatible
   - reg
-- 
2.43.0


  parent reply	other threads:[~2025-05-07 20:22 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07 20:19 [PATCH V9 00/24] drm: sun4i: add Display Engine 3.3 (DE33) support Chris Morgan
2025-05-07 20:19 ` [PATCH V9 01/24] dt-bindings: clock: sun50i-h616-ccu: Add LVDS reset Chris Morgan
2025-05-09 14:12   ` Andre Przywara
2025-05-07 20:19 ` [PATCH V9 02/24] clk: sunxi-ng: h616: Add LVDS reset for LCD TCON Chris Morgan
2025-05-09 14:14   ` Andre Przywara
2025-05-09 14:29     ` Chen-Yu Tsai
2025-05-09 16:31       ` Andre Przywara
2025-05-09 20:05         ` Chris Morgan
2025-05-07 20:19 ` [PATCH V9 03/24] drm: sun4i: de2/de3: add mixer version enum Chris Morgan
2025-05-07 20:19 ` [PATCH V9 04/24] drm: sun4i: de2/de3: refactor mixer initialisation Chris Morgan
2025-05-07 20:19 ` [PATCH V9 05/24] drm: sun4i: de2/de3: add generic blender register reference function Chris Morgan
2025-05-07 20:19 ` [PATCH V9 06/24] drm: sun4i: de2/de3: use generic register reference function for layer configuration Chris Morgan
2025-05-07 20:19 ` [PATCH V9 07/24] dt-bindings: allwinner: add H616 DE33 bus binding Chris Morgan
2025-05-07 20:19 ` [PATCH V9 08/24] dt-bindings: allwinner: add H616 DE33 clock binding Chris Morgan
2025-05-07 20:19 ` Chris Morgan [this message]
2025-05-07 20:19 ` [PATCH V9 10/24] clk: sunxi-ng: ccu: add Display Engine 3.3 (DE33) support Chris Morgan
2025-05-07 20:19 ` [PATCH V9 11/24] drm: sun4i: de33: vi_scaler: " Chris Morgan
2025-05-07 20:19 ` [PATCH V9 12/24] drm: sun4i: de33: mixer: " Chris Morgan
2025-05-07 20:19 ` [PATCH V9 13/24] drm: sun4i: de33: mixer: add mixer configuration for the H616 Chris Morgan
2025-05-07 20:19 ` [PATCH V9 14/24] dt-bindings: allwinner: Add TCON_TOP and TCON_LCD clock/reset defines Chris Morgan
2025-05-07 20:19 ` [PATCH V9 15/24] dt-bindings: display: sun4i: Add compatible strings for H616 DE Chris Morgan
2025-05-07 20:19 ` [PATCH V9 16/24] dt-bindings: display: sun4i: Add compatible strings for H616 TCON TOP Chris Morgan
2025-05-07 20:19 ` [PATCH V9 17/24] dt-bindings: sram: sunxi-sram: Add H616 SRAM C compatible Chris Morgan
2025-05-07 20:19 ` [PATCH V9 18/24] dt-bindings: display: Add R40 and H616 display engine compatibles Chris Morgan
2025-05-07 20:19 ` [PATCH V9 19/24] drm/sun4i: tcon: Add support for R40 LCD Chris Morgan
2025-05-07 20:19 ` [PATCH V9 20/24] arm64: dts: allwinner: h616: add display engine, bus and mixer nodes Chris Morgan
2025-05-07 20:19 ` [PATCH V9 21/24] arm64: dts: allwinner: h616: Add TCON nodes to H616 DTSI Chris Morgan
2025-05-07 20:19 ` [PATCH V9 22/24] arm64: dts: allwinner: h616: add LCD and LVDS pins Chris Morgan
2025-05-07 20:19 ` [PATCH V9 23/24] arm64: dts: allwinner: rg35xx: Add GPIO backlight control Chris Morgan
2025-05-09 14:32   ` Andre Przywara
2025-05-09 20:02     ` Chris Morgan
2025-05-07 20:19 ` [PATCH V9 24/24] arm64: dts: allwinner: rg35xx: Enable LCD output Chris Morgan
2025-05-07 21:13 ` [PATCH V9 00/24] drm: sun4i: add Display Engine 3.3 (DE33) support Rob Herring
2025-05-08 18:34   ` Corentin Labbe
2025-05-08  7:26 ` Krzysztof Kozlowski
2025-05-09 13:08   ` Chris Morgan
2025-05-10  2:01 ` (subset) " Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250507201943.330111-10-macroalpha82@gmail.com \
    --to=macroalpha82@gmail.com \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=macromorgan@hotmail.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=ryan@testtoast.com \
    --cc=samuel@sholland.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).