devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Santos <jonath4nns@gmail.com>
Cc: 20250505163919.6d805db2@jic23-huawei,
	Jonathan Santos <Jonathan.Santos@analog.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	andy@kernel.org, nuno.sa@analog.com,
	Michael.Hennerich@analog.com, marcelo.schmitt@analog.com,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	marcelo.schmitt1@gmail.com, linus.walleij@linaro.org,
	brgl@bgdev.pl, lgirdwood@gmail.com, broonie@kernel.org,
	dlechner@baylibre.com
Subject: Re: [PATCH v6 02/11] dt-bindings: iio: adc: ad7768-1: add trigger-sources property
Date: Wed, 7 May 2025 20:50:40 +0100	[thread overview]
Message-ID: <20250507205040.3a1eec14@jic23-huawei> (raw)
In-Reply-To: <aBpgFQ+/KBXdvyWx@JSANTO12-L01.ad.analog.com>

On Tue, 6 May 2025 16:16:37 -0300
Jonathan Santos <jonath4nns@gmail.com> wrote:

> On 05/05, Jonathan Cameron wrote:
> > On Sun, 27 Apr 2025 21:12:16 -0300
> > Jonathan Santos <Jonathan.Santos@analog.com> wrote:
> >   
> ...
> > >  required:
> > >    - compatible
> > >    - reg
> > > @@ -65,7 +95,6 @@ required:
> > >    - vref-supply
> > >    - spi-cpol
> > >    - spi-cpha
> > > -  - adi,sync-in-gpios  
> > 
> > Maybe worth requiring oneOf adi,sync-in-gpios or trigger-sources? 
> >   
> 
> We cannot do that because we defined that self triggering is enabled
> when trigger-sources is omitted (is this case adi,sync-in-gpios is not
> present as well).
Ah. Fair enough.  More complex but we can constrain to never having
both adi,sync-in-gpios and trigger-sources at the same time.

> 
> > >  
> > >  patternProperties:
> > >    "^channel@([0-9]|1[0-5])$":
> > > diff --git a/include/dt-bindings/iio/adc/adi,ad7768-1.h b/include/dt-bindings/iio/adc/adi,ad7768-1.h
> > > new file mode 100644
> > > index 000000000000..34d92856a50b
> > > --- /dev/null
> > > +++ b/include/dt-bindings/iio/adc/adi,ad7768-1.h
> > > @@ -0,0 +1,10 @@
> > > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> > > +
> > > +#ifndef _DT_BINDINGS_ADI_AD7768_1_H
> > > +#define _DT_BINDINGS_ADI_AD7768_1_H
> > > +
> > > +#define AD7768_TRIGGER_SOURCE_SYNC_OUT  0
> > > +#define AD7768_TRIGGER_SOURCE_GPIO3     1
> > > +#define AD7768_TRIGGER_SOURCE_DRDY      2
> > > +
> > > +#endif /* _DT_BINDINGS_ADI_AD7768_1_H */  
> >   


  reply	other threads:[~2025-05-07 19:50 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-28  0:11 [PATCH v6 00/11] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-04-28  0:12 ` [PATCH v6 01/11] dt-bindings: trigger-source: add generic GPIO trigger source Jonathan Santos
2025-05-05 15:44   ` Jonathan Cameron
2025-05-05 15:56     ` David Lechner
2025-05-13  9:32   ` Linus Walleij
2025-04-28  0:12 ` [PATCH v6 02/11] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-04-30 18:46   ` David Lechner
2025-05-05 15:39   ` Jonathan Cameron
2025-05-06 19:16     ` Jonathan Santos
2025-05-07 19:50       ` Jonathan Cameron [this message]
2025-04-28  0:12 ` [PATCH v6 03/11] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-04-28  0:12 ` [PATCH v6 04/11] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-04-28  0:13 ` [PATCH v6 05/11] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-04-28  6:42   ` Andy Shevchenko
2025-04-30 23:24     ` Jonathan Santos
2025-04-30 18:43   ` David Lechner
2025-04-28  0:13 ` [PATCH v6 06/11] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-04-28  6:50   ` Andy Shevchenko
2025-04-30 23:37     ` Jonathan Santos
2025-04-28  0:13 ` [PATCH v6 07/11] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-04-28  6:55   ` Andy Shevchenko
2025-05-05 15:52     ` Jonathan Cameron
2025-05-02 14:30   ` Marcelo Schmitt
2025-04-28  0:13 ` [PATCH v6 08/11] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-04-28  7:04   ` Andy Shevchenko
2025-05-01  0:03     ` Jonathan Santos
2025-04-30 19:07   ` David Lechner
2025-05-05 15:59   ` Jonathan Cameron
2025-04-28  0:14 ` [PATCH v6 09/11] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-04-28  7:10   ` Andy Shevchenko
2025-04-28  0:14 ` [PATCH v6 10/11] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-04-29 22:40   ` Andy Shevchenko
2025-05-05 16:09   ` Jonathan Cameron
2025-05-06 19:03     ` Jonathan Santos
2025-05-06 19:10       ` David Lechner
2025-04-28  0:14 ` [PATCH v6 11/11] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250507205040.3a1eec14@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=20250505163919.6d805db2@jic23-huawei \
    --cc=Jonathan.Santos@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jonath4nns@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=marcelo.schmitt@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).