public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Akhil R <akhilrajeev@nvidia.com>
Cc: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, thierry.reding@gmail.com,
	jonathanh@nvidia.com, ldewangan@nvidia.com, digetx@gmail.com,
	p.zabel@pengutronix.de, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: i2c: Specify reset as optional
Date: Thu, 8 May 2025 16:09:56 +0100	[thread overview]
Message-ID: <20250508-atrocious-till-30aad5010c3e@spud> (raw)
In-Reply-To: <20250506095936.10687-1-akhilrajeev@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]

On Tue, May 06, 2025 at 03:29:33PM +0530, Akhil R wrote:
> Specify reset as optional in the description for controllers that has an
> internal software reset available

Optionality of properties is not determined by text. The property is not
marked required in the binding, and therefore is optionally on all
platforms. If some platforms require it, you should submit a patch making
it mandatory there (via the required keyword).

Cheers,
Conor.

> 
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
>  Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> index b57ae6963e62..19aefc022c8b 100644
> --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> @@ -97,7 +97,9 @@ properties:
>  
>    resets:
>      items:
> -      - description: module reset
> +      - description: |
> +          Module reset. This property is optional for controllers in Tegra194 and later
> +          chips where an internal software reset is available as an alternative.
>  
>    reset-names:
>      items:
> -- 
> 2.43.2
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2025-05-08 15:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06  9:59 [PATCH 1/4] dt-bindings: i2c: Specify reset as optional Akhil R
2025-05-06  9:59 ` [PATCH 2/4] i2c: tegra: make reset an optional property Akhil R
2025-05-06 10:14   ` Philipp Zabel
2025-05-06  9:59 ` [PATCH 3/4] i2c: tegra: Remove dma_sync_*() calls Akhil R
2025-05-06 10:04   ` Akhil R
2025-05-06  9:59 ` [PATCH 4/4] arm64: tegra: Add I2C aliases for Tegra234 Akhil R
2025-05-06 10:11 ` [PATCH 1/4] dt-bindings: i2c: Specify reset as optional Philipp Zabel
2025-05-08 15:09 ` Conor Dooley [this message]
2025-05-08 20:33 ` (subset) " Thierry Reding
2025-05-12 23:20 ` Andi Shyti
2025-05-13  4:24   ` Akhil R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250508-atrocious-till-30aad5010c3e@spud \
    --to=conor@kernel.org \
    --cc=akhilrajeev@nvidia.com \
    --cc=andi.shyti@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=ldewangan@nvidia.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox