From: Pawel Dembicki <paweldembicki@gmail.com>
To: linux-hwmon@vger.kernel.org
Cc: Pawel Dembicki <paweldembicki@gmail.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Noah Wang <noahwang.wang@outlook.com>,
Fabio Estevam <festevam@gmail.com>,
Naresh Solanki <naresh.solanki@9elements.com>,
Michal Simek <michal.simek@amd.com>,
Grant Peltier <grantpeltier93@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Peter Zijlstra <peterz@infradead.org>,
Shen Lichuan <shenlichuan@vivo.com>,
Greg KH <gregkh@linuxfoundation.org>,
Charles Hsu <ythsu0511@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: [PATCH v3 3/5] hwmon: pmbus: mpq8785: Implement VOUT feedback resistor divider ratio configuration
Date: Sat, 10 May 2025 11:18:46 +0200 [thread overview]
Message-ID: <20250510091937.2298256-4-paweldembicki@gmail.com> (raw)
In-Reply-To: <20250510091937.2298256-1-paweldembicki@gmail.com>
Implement support for setting the VOUT_SCALE_LOOP PMBus register
based on an optional device tree property
"mps,vout-fb-divider-ratio-permille".
This allows the driver to provide the correct VOUT value depending
on the feedback voltage divider configuration for chips where the
bootloader does not configure the VOUT_SCALE_LOOP register.
Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
---
v3:
- droped comments and indexed the table with enums instead
- use device_property_read_u32() instead of_property_read_u32()
v2:
- renamed property to mps,vout-fb-divider-ratio-permille
- added register value range checking
---
drivers/hwmon/pmbus/mpq8785.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/hwmon/pmbus/mpq8785.c b/drivers/hwmon/pmbus/mpq8785.c
index d0ac294b4bbc..2e7c0d0c3f81 100644
--- a/drivers/hwmon/pmbus/mpq8785.c
+++ b/drivers/hwmon/pmbus/mpq8785.c
@@ -5,11 +5,16 @@
#include <linux/i2c.h>
#include <linux/module.h>
+#include <linux/property.h>
#include <linux/of_device.h>
#include "pmbus.h"
enum chips { mpq8785 };
+static u16 voltage_scale_loop_max_val[] = {
+ [mpq8785] = GENMASK(10, 0),
+};
+
static int mpq8785_identify(struct i2c_client *client,
struct pmbus_driver_info *info)
{
@@ -74,6 +79,8 @@ static int mpq8785_probe(struct i2c_client *client)
struct device *dev = &client->dev;
struct pmbus_driver_info *info;
enum chips chip_id;
+ u32 voltage_scale;
+ int ret;
info = devm_kmemdup(dev, &mpq8785_info, sizeof(*info), GFP_KERNEL);
if (!info)
@@ -92,6 +99,17 @@ static int mpq8785_probe(struct i2c_client *client)
return -ENODEV;
}
+ if (!device_property_read_u32(dev, "mps,vout-fb-divider-ratio-permille",
+ &voltage_scale)) {
+ if (voltage_scale > voltage_scale_loop_max_val[chip_id])
+ return -EINVAL;
+
+ ret = i2c_smbus_write_word_data(client, PMBUS_VOUT_SCALE_LOOP,
+ voltage_scale);
+ if (ret)
+ return ret;
+ }
+
return pmbus_do_probe(client, info);
};
--
2.43.0
next prev parent reply other threads:[~2025-05-10 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-10 9:18 [PATCH v3 0/5] hwmon: pmbus: Add support for MPM82504 and MPM3695 family Pawel Dembicki
2025-05-10 9:18 ` [PATCH v3 1/5] dt-bindings: hwmon: Add bindings for mpq8785 driver Pawel Dembicki
2025-05-10 9:18 ` [PATCH v3 2/5] hwmon: pmbus: mpq8785: Prepare driver for multiple device support Pawel Dembicki
2025-05-10 9:18 ` Pawel Dembicki [this message]
2025-05-10 9:18 ` [PATCH v3 4/5] hwmon: pmbus: mpq8785: Add support for MPM82504 Pawel Dembicki
2025-05-10 14:37 ` Guenter Roeck
2025-05-10 9:18 ` [PATCH v3 5/5] hwmon: pmbus: mpq8785: Add support for MPM3695 family Pawel Dembicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250510091937.2298256-4-paweldembicki@gmail.com \
--to=paweldembicki@gmail.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=grantpeltier93@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michal.simek@amd.com \
--cc=naresh.solanki@9elements.com \
--cc=noahwang.wang@outlook.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=shenlichuan@vivo.com \
--cc=ythsu0511@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox