devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: dts: imx7s-warp: Improve the Bluetooth description
@ 2025-05-13 14:23 Fabio Estevam
  2025-05-13 14:23 ` [PATCH 2/3] ARM: dts: imx7s-warp: Improve the Wifi description Fabio Estevam
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2025-05-13 14:23 UTC (permalink / raw)
  To: shawnguo
  Cc: robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel, imx,
	Fabio Estevam

GPIO5_17 is connected to the BCM43455 BT_REG_ON pin.

Improve the Bluetooth devicetree description by using a more accurate
description of the hardware as per brcm,bluetooth.yaml.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/boot/dts/nxp/imx/imx7s-warp.dts | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
index af4acc311572..b66e612d3329 100644
--- a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
@@ -43,18 +43,6 @@ reg_brcm: regulator-brcm {
 		startup-delay-us = <200000>;
 	};
 
-	reg_bt: regulator-bt {
-		compatible = "regulator-fixed";
-		pinctrl-names = "default";
-		pinctrl-0 = <&pinctrl_bt_reg>;
-		enable-active-high;
-		gpio = <&gpio5 17 GPIO_ACTIVE_HIGH>;
-		regulator-name = "bt_reg";
-		regulator-min-microvolt = <3300000>;
-		regulator-max-microvolt = <3300000>;
-		regulator-always-on;
-	};
-
 	reg_peri_3p15v: regulator-peri-3p15v {
 		compatible = "regulator-fixed";
 		regulator-name = "peri_3p15v_reg";
@@ -288,6 +276,14 @@ &uart3  {
 	assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
 	uart-has-rtscts;
 	status = "okay";
+
+	bluetooth {
+		compatible = "brcm,bcm4345c5";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_bt_reg>;
+		shutdown-gpios = <&gpio5 17 GPIO_ACTIVE_HIGH>;
+		max-speed = <3000000>;
+	};
 };
 
 &uart6 {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] ARM: dts: imx7s-warp: Improve the Wifi description
  2025-05-13 14:23 [PATCH 1/3] ARM: dts: imx7s-warp: Improve the Bluetooth description Fabio Estevam
@ 2025-05-13 14:23 ` Fabio Estevam
  2025-05-13 14:23 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Select BT_HCIUART_BCM Fabio Estevam
  2025-06-13  1:46 ` [PATCH 1/3] ARM: dts: imx7s-warp: Improve the Bluetooth description Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2025-05-13 14:23 UTC (permalink / raw)
  To: shawnguo
  Cc: robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel, imx,
	Fabio Estevam

GPIO5_10 is connected to the BCM43455 WL_REG_ON pin and it is better
descrbed via mmc-pwrseq-simple.yaml.

Also improve the Wifi devicetree description by passing a compatible
string that describes the BCM43455 presence as per brcm,bcm4329-fmac.yaml.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/boot/dts/nxp/imx/imx7s-warp.dts | 29 +++++++++++++-----------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
index b66e612d3329..f2cd95e992e7 100644
--- a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
@@ -31,18 +31,6 @@ back {
 		};
 	};
 
-	reg_brcm: regulator-brcm {
-		compatible = "regulator-fixed";
-		enable-active-high;
-		gpio = <&gpio5 10 GPIO_ACTIVE_HIGH>;
-		pinctrl-names = "default";
-		pinctrl-0 = <&pinctrl_brcm_reg>;
-		regulator-name = "brcm_reg";
-		regulator-min-microvolt = <3300000>;
-		regulator-max-microvolt = <3300000>;
-		startup-delay-us = <200000>;
-	};
-
 	reg_peri_3p15v: regulator-peri-3p15v {
 		compatible = "regulator-fixed";
 		regulator-name = "peri_3p15v_reg";
@@ -51,6 +39,14 @@ reg_peri_3p15v: regulator-peri-3p15v {
 		regulator-always-on;
 	};
 
+	sdio_pwrseq: sdio-pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_brcm_reg>;
+		post-power-on-delay-ms = <200>;
+		reset-gpios = <&gpio5 10 GPIO_ACTIVE_LOW>;
+	};
+
 	sound {
 		compatible = "simple-audio-card";
 		simple-audio-card,name = "imx7-sgtl5000";
@@ -301,14 +297,21 @@ &usbotg1 {
 };
 
 &usdhc1 {
+	#address-cells = <1>;
+	#size-cells = <0>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usdhc1>;
 	bus-width = <4>;
 	keep-power-in-suspend;
 	no-1-8-v;
 	non-removable;
-	vmmc-supply = <&reg_brcm>;
+	mmc-pwrseq = <&sdio_pwrseq>;
 	status = "okay";
+
+	wifi@0 {
+		compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac";
+		reg = <0>;
+	};
 };
 
 &usdhc3 {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] ARM: imx_v6_v7_defconfig: Select BT_HCIUART_BCM
  2025-05-13 14:23 [PATCH 1/3] ARM: dts: imx7s-warp: Improve the Bluetooth description Fabio Estevam
  2025-05-13 14:23 ` [PATCH 2/3] ARM: dts: imx7s-warp: Improve the Wifi description Fabio Estevam
@ 2025-05-13 14:23 ` Fabio Estevam
  2025-06-13  1:46 ` [PATCH 1/3] ARM: dts: imx7s-warp: Improve the Bluetooth description Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2025-05-13 14:23 UTC (permalink / raw)
  To: shawnguo
  Cc: robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel, imx,
	Fabio Estevam

Select BT_HCIUART_BCM so that Bluetooth can work by default on a
imx7s-warp board with a BCM43455 Wifi/Bluetooth chip.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 062c1eb8dd60..6f62d2e96239 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -68,6 +68,7 @@ CONFIG_BT=y
 CONFIG_BT_BNEP=m
 CONFIG_BT_HCIUART=y
 CONFIG_BT_HCIUART_LL=y
+CONFIG_BT_HCIUART_BCM=y
 CONFIG_BT_NXPUART=m
 CONFIG_CFG80211=y
 CONFIG_CFG80211_WEXT=y
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] ARM: dts: imx7s-warp: Improve the Bluetooth description
  2025-05-13 14:23 [PATCH 1/3] ARM: dts: imx7s-warp: Improve the Bluetooth description Fabio Estevam
  2025-05-13 14:23 ` [PATCH 2/3] ARM: dts: imx7s-warp: Improve the Wifi description Fabio Estevam
  2025-05-13 14:23 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Select BT_HCIUART_BCM Fabio Estevam
@ 2025-06-13  1:46 ` Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2025-06-13  1:46 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: shawnguo, robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel,
	imx

On Tue, May 13, 2025 at 11:23:18AM -0300, Fabio Estevam wrote:
> GPIO5_17 is connected to the BCM43455 BT_REG_ON pin.
> 
> Improve the Bluetooth devicetree description by using a more accurate
> description of the hardware as per brcm,bluetooth.yaml.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Applied all, thanks!


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-06-13  1:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-13 14:23 [PATCH 1/3] ARM: dts: imx7s-warp: Improve the Bluetooth description Fabio Estevam
2025-05-13 14:23 ` [PATCH 2/3] ARM: dts: imx7s-warp: Improve the Wifi description Fabio Estevam
2025-05-13 14:23 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Select BT_HCIUART_BCM Fabio Estevam
2025-06-13  1:46 ` [PATCH 1/3] ARM: dts: imx7s-warp: Improve the Bluetooth description Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).