Re: [PATCH v2 4/6] arm64: dts: rockchip: add px30-cobra base dtsi and board variants

Heiko Stübner
2025-05-14T14:56:23Z

Am Mittwoch, 14. Mai 2025, 15:39:51 Mitteleuropäische Sommerzeit schrieb Rob Herring:
> On Tue, May 13, 2025 at 05:02:32PM +0200, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@cherry.de>
> >
> > Cobra are Touchscreen devices built around the PX30 SoC using
> > a variety of display options.
> >
> > The devices feature an EMMC, network port, usb host + OTG ports and
> > a 720x1280 display with a touchscreen.
> >
> > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
> > ---
> > arch/arm64/boot/dts/rockchip/Makefile | 4 +
> > .../rockchip/px30-cobra-ltk050h3146w-a2.dts | 39 ++
> > .../dts/rockchip/px30-cobra-ltk050h3146w.dts | 39 ++
> > .../dts/rockchip/px30-cobra-ltk050h3148w.dts | 39 ++
> > .../dts/rockchip/px30-cobra-ltk500hd1829.dts | 73 +++
> > arch/arm64/boot/dts/rockchip/px30-cobra.dtsi | 566 ++++++++++++++++++
> > 6 files changed, 760 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts
> > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w.dts
> > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3148w.dts
> > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk500hd1829.dts
> > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> > index 3e8771ef69ba..8151e8bb1cd3 100644
> > --- a/arch/arm64/boot/dts/rockchip/Makefile
> > +++ b/arch/arm64/boot/dts/rockchip/Makefile
> > @@ -1,4 +1,8 @@
> > # SPDX-License-Identifier: GPL-2.0
> > +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk050h3146w-a2.dtb
> > +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk050h3146w.dtb
> > +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk050h3148w.dtb
> > +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk500hd1829.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-evb.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2-of10.dtb
> > diff --git a/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts
> > new file mode 100644
> > index 000000000000..1d26164be7b8
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts
> > @@ -0,0 +1,39 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (c) 2025 Cherry Embedded Solutions GmbH
> > + */
> > +
> > +/dts-v1/;
> > +#include "px30-cobra.dtsi"
> > +
> > +/ {
> > + model = "Theobroma Systems Cobra with LTK050H3146W-A2 Display";
> > + compatible = "tsd,px30-cobra-ltk050h3146w-a2", "tsd,px30-cobra", "rockchip,px30";
> > +};
> > +
> > +&dsi {
> > + status = "okay";
> > +
> > + panel@0 {
> > + compatible = "leadtek,ltk050h3146w-a2";
> > + reg = <0>;
> > + backlight = <&backlight>;
> > + iovcc-supply = <&vcc_1v8>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&dsp_rst>;
> > + reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
> > + vci-supply = <&vcc_2v8>;
> > +
> > + port {
>
> 'port' is not allowed by this binding.

It is since last week [0], because the Leadtek displays got their port
property added.

[0] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=bf0636f4348e098e2338eebbe42d7780c58a1195