From: Rob Herring <robh@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/11] dt-bindings: mailbox: tegra-hsp: Properly sort compatible string list
Date: Wed, 14 May 2025 11:17:32 -0500 [thread overview]
Message-ID: <20250514161732.GA2492164-robh@kernel.org> (raw)
In-Reply-To: <20250506133118.1011777-4-thierry.reding@gmail.com>
On Tue, May 06, 2025 at 03:31:10PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> We want these strings to be sorted in order of release date of the
> chips, so the Tegra264 entry should go after the Tegra234 entry.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../devicetree/bindings/mailbox/nvidia,tegra186-hsp.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/nvidia,tegra186-hsp.yaml b/Documentation/devicetree/bindings/mailbox/nvidia,tegra186-hsp.yaml
> index df6784a7c96a..cbc02b2a156a 100644
> --- a/Documentation/devicetree/bindings/mailbox/nvidia,tegra186-hsp.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/nvidia,tegra186-hsp.yaml
> @@ -66,10 +66,10 @@ properties:
> oneOf:
> - const: nvidia,tegra186-hsp
> - const: nvidia,tegra194-hsp
> - - const: nvidia,tegra264-hsp
> - items:
> - const: nvidia,tegra234-hsp
> - const: nvidia,tegra194-hsp
> + - const: nvidia,tegra264-hsp
The preference here is really to put all the single entry cases into 1
enum. Order by release would be okay, but not something the DT
maintainers know or can remember which bindings do that. So alphanumeric
order is preferred.
Acked-by: Rob Herring (Arm) <robh@kernel.org>
Rob
next prev parent reply other threads:[~2025-05-14 16:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 13:31 [PATCH 00/11] Add Tegra264 support Thierry Reding
2025-05-06 13:31 ` [PATCH 01/11] dt-bindings: tegra: pmc: Add Tegra264 compatible Thierry Reding
2025-05-14 16:09 ` Rob Herring (Arm)
2025-07-07 10:20 ` Thierry Reding
2025-05-06 13:31 ` [PATCH 02/11] dt-bindings: mailbox: tegra-hsp: Bump number of shared interrupts Thierry Reding
2025-05-14 16:13 ` Rob Herring
2025-07-07 10:20 ` Thierry Reding
2025-05-06 13:31 ` [PATCH 03/11] dt-bindings: mailbox: tegra-hsp: Properly sort compatible string list Thierry Reding
2025-05-14 16:17 ` Rob Herring [this message]
2025-05-06 13:31 ` [PATCH 04/11] dt-bindings: firmware: Document Tegra264 BPMP Thierry Reding
2025-05-14 16:17 ` Rob Herring (Arm)
2025-05-06 13:31 ` [PATCH 05/11] dt-bindings: misc: Document Tegra264 APBMISC compatible Thierry Reding
2025-05-14 16:18 ` Rob Herring (Arm)
2025-05-06 13:31 ` [PATCH 06/11] soc/tegra: Enable support for Tegra264 Thierry Reding
2025-05-06 13:31 ` [PATCH 07/11] soc/tegra: pmc: Add Tegra264 support Thierry Reding
2025-05-07 11:03 ` Jon Hunter
2025-05-07 14:32 ` Thierry Reding
2025-05-06 13:31 ` [PATCH 08/11] soc/tegra: Add Tegra264 APBMISC compatible string Thierry Reding
2025-05-06 13:31 ` [PATCH 09/11] firmware: tegra: Fix IVC dependency problems Thierry Reding
2025-05-06 13:31 ` [PATCH 10/11] firmware: tegra: bpmp: Add support on Tegra264 Thierry Reding
2025-05-06 13:31 ` [PATCH 11/11] arm64: defconfig: Enable Tegra HSP and BPMP Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514161732.GA2492164-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).