From: Conor Dooley <conor@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Julien Massot <julien.massot@collabora.com>,
kernel@collabora.com, Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Garmin Chang <garmin.chang@mediatek.com>,
Friday Yang <friday.yang@mediatek.com>,
Conor Dooley <conor.dooley@microchip.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: mediatek: Add #reset-cells property for MT8188
Date: Thu, 15 May 2025 17:17:11 +0100 [thread overview]
Message-ID: <20250515-deploy-wiring-5829acc3d82e@spud> (raw)
In-Reply-To: <cbd170a3-cbfe-4b4f-a059-efe33fed0e5d@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On Thu, May 15, 2025 at 05:11:13PM +0200, AngeloGioacchino Del Regno wrote:
> Il 15/05/25 17:03, Conor Dooley ha scritto:
> > On Thu, May 15, 2025 at 03:31:43PM +0200, Julien Massot wrote:
> > > The '#reset-cells' property is required for some of the MT8188
> > > clock controllers, but not listed as a valid property.
> >
> > "required for some" but not marked required on those platforms.
> > Why not?
> >
>
> Yeah now that I read that for the third time, the wording is a bit incorrect.
>
> It's not "required", some clock controllers do have reset controllers, but it
> is facultative to actually use the latter.
I don't think I've ever seen this word before.
> I'm not sure if the ones that do have reset controllers inside should have the
> #reset-cells property as required...
>
> Conor, what do you think?
If "required for some" in the OP was meant as "permitted for some",
change the wording to that and it is fine.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-05-15 16:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 13:31 [PATCH 0/3] mt8188: Fix missing reset and clock-names DT properties Julien Massot
2025-05-15 13:31 ` [PATCH 1/3] dt-bindings: clock: mediatek: Add #reset-cells property for MT8188 Julien Massot
2025-05-15 14:52 ` AngeloGioacchino Del Regno
2025-05-15 15:03 ` Conor Dooley
2025-05-15 15:11 ` AngeloGioacchino Del Regno
2025-05-15 16:17 ` Conor Dooley [this message]
2025-05-16 14:14 ` Julien Massot
2025-05-15 13:31 ` [PATCH 2/3] arm64: dts: mediatek: mt8188: Add missing #reset-cells property Julien Massot
2025-05-15 14:53 ` AngeloGioacchino Del Regno
2025-05-16 14:13 ` Julien Massot
2025-05-15 13:31 ` [PATCH 3/3] arm64: dts: mediatek: mt8188: gce: add missing 'clock-names' Julien Massot
2025-05-15 14:52 ` AngeloGioacchino Del Regno
2025-05-16 14:16 ` Julien Massot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515-deploy-wiring-5829acc3d82e@spud \
--to=conor@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=friday.yang@mediatek.com \
--cc=garmin.chang@mediatek.com \
--cc=julien.massot@collabora.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).