* [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for ipq5018
2025-05-12 14:36 [PATCH 0/2] Add the download mode support for IPQ5018 George Moussalem via B4 Relay
@ 2025-05-12 14:36 ` George Moussalem via B4 Relay
2025-05-14 21:55 ` Rob Herring (Arm)
2025-05-15 6:59 ` (subset) " Lee Jones
2025-05-12 14:36 ` [PATCH 2/2] arm64: dts: qcom: ipq5018: enable the download mode support George Moussalem via B4 Relay
2025-05-14 21:03 ` (subset) [PATCH 0/2] Add the download mode support for IPQ5018 Bjorn Andersson
2 siblings, 2 replies; 9+ messages in thread
From: George Moussalem via B4 Relay @ 2025-05-12 14:36 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, devicetree, linux-kernel, George Moussalem
From: George Moussalem <george.moussalem@outlook.com>
Document the qcom,tcsr-ipq5018 compatible.
Signed-off-by: George Moussalem <george.moussalem@outlook.com>
---
Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
index 7e7225aadae3285f59ec303294cf1515772a629b..14ae3f00ef7e00e607bba93f49f03bb244253b0e 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
@@ -41,6 +41,7 @@ properties:
- qcom,sm8450-tcsr
- qcom,tcsr-apq8064
- qcom,tcsr-apq8084
+ - qcom,tcsr-ipq5018
- qcom,tcsr-ipq5332
- qcom,tcsr-ipq5424
- qcom,tcsr-ipq6018
--
2.49.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for ipq5018
2025-05-12 14:36 ` [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for ipq5018 George Moussalem via B4 Relay
@ 2025-05-14 21:55 ` Rob Herring (Arm)
2025-05-15 6:59 ` (subset) " Lee Jones
1 sibling, 0 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2025-05-14 21:55 UTC (permalink / raw)
To: George Moussalem
Cc: Konrad Dybcio, Bjorn Andersson, Krzysztof Kozlowski,
linux-arm-msm, Conor Dooley, devicetree, linux-kernel, Lee Jones
On Mon, 12 May 2025 18:36:46 +0400, George Moussalem wrote:
> Document the qcom,tcsr-ipq5018 compatible.
>
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> ---
> Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: (subset) [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for ipq5018
2025-05-12 14:36 ` [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for ipq5018 George Moussalem via B4 Relay
2025-05-14 21:55 ` Rob Herring (Arm)
@ 2025-05-15 6:59 ` Lee Jones
1 sibling, 0 replies; 9+ messages in thread
From: Lee Jones @ 2025-05-15 6:59 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, George Moussalem
Cc: linux-arm-msm, devicetree, linux-kernel
On Mon, 12 May 2025 18:36:46 +0400, George Moussalem wrote:
> Document the qcom,tcsr-ipq5018 compatible.
>
>
Applied, thanks!
[1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for ipq5018
commit: a49b7d3746fe6e0b3eaf1da065be111fe2299c5b
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: ipq5018: enable the download mode support
2025-05-12 14:36 [PATCH 0/2] Add the download mode support for IPQ5018 George Moussalem via B4 Relay
2025-05-12 14:36 ` [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for ipq5018 George Moussalem via B4 Relay
@ 2025-05-12 14:36 ` George Moussalem via B4 Relay
2025-05-12 14:43 ` Konrad Dybcio
2025-05-14 21:03 ` (subset) [PATCH 0/2] Add the download mode support for IPQ5018 Bjorn Andersson
2 siblings, 1 reply; 9+ messages in thread
From: George Moussalem via B4 Relay @ 2025-05-12 14:36 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, devicetree, linux-kernel, George Moussalem
From: George Moussalem <george.moussalem@outlook.com>
Enable support for download mode to collect RAM dumps in case of a
system crash, allowing post mortem analysis.
Signed-off-by: George Moussalem <george.moussalem@outlook.com>
---
arch/arm64/boot/dts/qcom/ipq5018.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
index 8914f2ef0bc47fda243b19174f77ce73fc10757d..0abb00cfe4ce2f9bdea73deebedad8297f56322c 100644
--- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
@@ -79,6 +79,7 @@ opp-1008000000 {
firmware {
scm {
compatible = "qcom,scm-ipq5018", "qcom,scm";
+ qcom,dload-mode = <&tcsr 0x6100>;
qcom,sdi-enabled;
};
};
@@ -187,6 +188,11 @@ tcsr_mutex: hwlock@1905000 {
#hwlock-cells = <1>;
};
+ tcsr: syscon@1937000 {
+ compatible = "qcom,tcsr-ipq5018", "syscon";
+ reg = <0x01937000 0x21000>;
+ };
+
sdhc_1: mmc@7804000 {
compatible = "qcom,ipq5018-sdhci", "qcom,sdhci-msm-v5";
reg = <0x7804000 0x1000>;
--
2.49.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: enable the download mode support
2025-05-12 14:36 ` [PATCH 2/2] arm64: dts: qcom: ipq5018: enable the download mode support George Moussalem via B4 Relay
@ 2025-05-12 14:43 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2025-05-12 14:43 UTC (permalink / raw)
To: george.moussalem, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, devicetree, linux-kernel
On 5/12/25 4:36 PM, George Moussalem via B4 Relay wrote:
> From: George Moussalem <george.moussalem@outlook.com>
>
> Enable support for download mode to collect RAM dumps in case of a
> system crash, allowing post mortem analysis.
>
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: (subset) [PATCH 0/2] Add the download mode support for IPQ5018
2025-05-12 14:36 [PATCH 0/2] Add the download mode support for IPQ5018 George Moussalem via B4 Relay
2025-05-12 14:36 ` [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for ipq5018 George Moussalem via B4 Relay
2025-05-12 14:36 ` [PATCH 2/2] arm64: dts: qcom: ipq5018: enable the download mode support George Moussalem via B4 Relay
@ 2025-05-14 21:03 ` Bjorn Andersson
2025-05-14 21:54 ` Rob Herring
2 siblings, 1 reply; 9+ messages in thread
From: Bjorn Andersson @ 2025-05-14 21:03 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Konrad Dybcio, George Moussalem
Cc: linux-arm-msm, devicetree, linux-kernel
On Mon, 12 May 2025 18:36:45 +0400, George Moussalem wrote:
> Enable support for download mode to collect the RAM dumps in case of
> system crashes, to perform post mortem analysis.
>
>
Applied, thanks!
[2/2] arm64: dts: qcom: ipq5018: enable the download mode support
commit: 43fefd6c71291b5793e7c4052b6e3e54d1d87715
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: (subset) [PATCH 0/2] Add the download mode support for IPQ5018
2025-05-14 21:03 ` (subset) [PATCH 0/2] Add the download mode support for IPQ5018 Bjorn Andersson
@ 2025-05-14 21:54 ` Rob Herring
2025-05-15 7:00 ` Lee Jones
0 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2025-05-14 21:54 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Lee Jones, Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio,
George Moussalem, linux-arm-msm, devicetree, linux-kernel
On Wed, May 14, 2025 at 10:03:45PM +0100, Bjorn Andersson wrote:
>
> On Mon, 12 May 2025 18:36:45 +0400, George Moussalem wrote:
> > Enable support for download mode to collect the RAM dumps in case of
> > system crashes, to perform post mortem analysis.
> >
> >
>
> Applied, thanks!
>
> [2/2] arm64: dts: qcom: ipq5018: enable the download mode support
> commit: 43fefd6c71291b5793e7c4052b6e3e54d1d87715
You should really either wait a bit for the binding to be applied or
just take the binding patch when it is trivial. Then we're not getting
temporary warnings added which seems to happen a lot on QCom platforms.
Rob
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: (subset) [PATCH 0/2] Add the download mode support for IPQ5018
2025-05-14 21:54 ` Rob Herring
@ 2025-05-15 7:00 ` Lee Jones
0 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2025-05-15 7:00 UTC (permalink / raw)
To: Rob Herring
Cc: Bjorn Andersson, Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio,
George Moussalem, linux-arm-msm, devicetree, linux-kernel
On Wed, 14 May 2025, Rob Herring wrote:
> On Wed, May 14, 2025 at 10:03:45PM +0100, Bjorn Andersson wrote:
> >
> > On Mon, 12 May 2025 18:36:45 +0400, George Moussalem wrote:
> > > Enable support for download mode to collect the RAM dumps in case of
> > > system crashes, to perform post mortem analysis.
> > >
> > >
> >
> > Applied, thanks!
> >
> > [2/2] arm64: dts: qcom: ipq5018: enable the download mode support
> > commit: 43fefd6c71291b5793e7c4052b6e3e54d1d87715
>
> You should really either wait a bit for the binding to be applied or
> just take the binding patch when it is trivial. Then we're not getting
> temporary warnings added which seems to happen a lot on QCom platforms.
First option is fine, but please don't apply the bindings, since it'll
cause annoying conflicts.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 9+ messages in thread