public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Santos <Jonathan.Santos@analog.com>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
	<andy@kernel.org>, <nuno.sa@analog.com>,
	<Michael.Hennerich@analog.com>, <marcelo.schmitt@analog.com>,
	<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<marcelo.schmitt1@gmail.com>, <linus.walleij@linaro.org>,
	<brgl@bgdev.pl>, <lgirdwood@gmail.com>, <broonie@kernel.org>,
	<jonath4nns@gmail.com>, <dlechner@baylibre.com>,
	"Pop Paul" <paul.pop@analog.com>
Subject: Re: [PATCH v8 10/11] iio: adc: ad7768-1: add filter type and oversampling ratio attributes
Date: Sun, 18 May 2025 18:03:49 +0100	[thread overview]
Message-ID: <20250518180349.6fb308be@jic23-huawei> (raw)
In-Reply-To: <1aff0f813bb3fee55c5483be860b6885abdb81e5.1747175187.git.Jonathan.Santos@analog.com>


>  	 * DMA (thus cache coherency maintenance) may require the
> @@ -326,11 +337,37 @@ static int ad7768_send_sync_pulse(struct ad7768_state *st)
>  
>  static void ad7768_fill_samp_freq_tbl(struct ad7768_state *st)
>  {
> -	unsigned int i;
> +	unsigned int i, samp_freq_avail, freq_filtered, len = 0;

If you are spinning again, please split the len = 0 onto it's own
unsigned int len = 0;
to avoid mixing assigning and non assigning declarations
as they are a little hard to spot when mixed up!

> +
> +	freq_filtered = DIV_ROUND_CLOSEST(st->mclk_freq, st->oversampling_ratio);
> +	for (i = 0; i < ARRAY_SIZE(ad7768_mclk_div_rates); i++) {
> +		samp_freq_avail = DIV_ROUND_CLOSEST(freq_filtered, ad7768_mclk_div_rates[i]);
> +		/* Sampling frequency cannot be lower than the minimum of 50 SPS */
> +		if (samp_freq_avail < 50)
> +			continue;
> +
> +		st->samp_freq_avail[len++] = samp_freq_avail;
> +	}
> +
> +	st->samp_freq_avail_len = len;
> +}


  parent reply	other threads:[~2025-05-18 17:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-15 21:11 [PATCH v8 00/11] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-05-15 21:12 ` [PATCH v8 01/11] dt-bindings: trigger-source: add generic GPIO trigger source Jonathan Santos
2025-05-15 21:12 ` [PATCH v8 02/11] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-05-15 21:12 ` [PATCH v8 03/11] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-05-15 21:13 ` [PATCH v8 04/11] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-05-15 21:13 ` [PATCH v8 05/11] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-05-15 21:13 ` [PATCH v8 06/11] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-05-15 21:13 ` [PATCH v8 07/11] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-05-16  9:24   ` Andy Shevchenko
2025-05-15 21:13 ` [PATCH v8 08/11] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-05-15 22:46   ` David Lechner
2025-05-16  9:29   ` Andy Shevchenko
2025-05-18 16:58     ` Jonathan Cameron
2025-05-24  0:00       ` Jonathan Santos
2025-05-25  9:41         ` Jonathan Cameron
2025-05-15 21:14 ` [PATCH v8 09/11] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-05-15 21:14 ` [PATCH v8 10/11] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-05-16  9:34   ` Andy Shevchenko
2025-05-18 17:03   ` Jonathan Cameron [this message]
2025-05-19 17:13   ` Jonathan Santos
2025-05-19 20:15     ` David Lechner
2025-05-19 22:31       ` Jonathan Santos
2025-05-25  9:44         ` Jonathan Cameron
2025-05-15 21:14 ` [PATCH v8 11/11] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos
2025-05-16  9:38   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250518180349.6fb308be@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Santos@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jonath4nns@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=marcelo.schmitt@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=paul.pop@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox