From: Jonathan Cameron <jic23@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: <robh@kernel.org>, <conor+dt@kernel.org>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 09/10] iio: adc: ad4080: add driver support
Date: Sun, 18 May 2025 18:14:24 +0100 [thread overview]
Message-ID: <20250518181424.15a2187b@jic23-huawei> (raw)
In-Reply-To: <20250516082630.8236-10-antoniu.miclaus@analog.com>
On Fri, 16 May 2025 11:26:29 +0300
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> Add support for AD4080 high-speed, low noise, low distortion,
> 20-bit, Easy Drive, successive approximation register (SAR)
> analog-to-digital converter (ADC).
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
I'm not sure why by the patch I got from b4 for this was subtly corrupted
at the end. I just deleted the non patch part and it was fine.
One other issue below that I fixed up.
> +static ssize_t ad4080_get_filter_type(struct iio_dev *dev,
should return an int.
> + const struct iio_chan_spec *chan)
> +{
> + struct ad4080_state *st = iio_priv(dev);
> + unsigned int data;
> + int ret;
> +
> + ret = regmap_read(st->regmap, AD4080_REG_FILTER_CONFIG, &data);
> + if (ret)
> + return ret;
> +
> + return FIELD_GET(AD4080_FILTER_CONFIG_FILTER_SEL_MSK, data);
> +}
next prev parent reply other threads:[~2025-05-18 17:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 8:26 [PATCH v6 00/10] Add support for AD4080 ADC Antoniu Miclaus
2025-05-16 8:26 ` [PATCH v6 01/10] iio: backend: add support for filter config Antoniu Miclaus
2025-05-16 8:26 ` [PATCH v6 02/10] iio: backend: add support for data alignment Antoniu Miclaus
2025-05-18 17:08 ` Jonathan Cameron
2025-05-16 8:26 ` [PATCH v6 03/10] iio: backend: add support for number of lanes Antoniu Miclaus
2025-05-16 8:26 ` [PATCH v6 04/10] dt-bindings: iio: adc: add ad408x axi variant Antoniu Miclaus
2025-05-16 8:26 ` [PATCH v6 05/10] iio: adc: adi-axi-adc: add filter type config Antoniu Miclaus
2025-05-16 8:26 ` [PATCH v6 06/10] iio: adc: adi-axi-adc: add data align process Antoniu Miclaus
2025-05-18 17:18 ` Jonathan Cameron
2025-05-16 8:26 ` [PATCH v6 07/10] iio: adc: adi-axi-adc: add num lanes support Antoniu Miclaus
2025-05-16 8:26 ` [PATCH v6 08/10] dt-bindings: iio: adc: add ad4080 Antoniu Miclaus
2025-05-16 8:26 ` [PATCH v6 09/10] iio: adc: ad4080: add driver support Antoniu Miclaus
2025-05-18 17:14 ` Jonathan Cameron [this message]
2025-05-19 15:51 ` David Lechner
2025-05-20 9:24 ` Nuno Sá
2025-05-20 10:31 ` Miclaus, Antoniu
2025-05-16 8:26 ` [PATCH v6 10/10] Documetation: ABI: add sinc1 and sinc5+pf1 filter Antoniu Miclaus
2025-05-18 17:21 ` Jonathan Cameron
2025-05-18 17:23 ` [PATCH v6 00/10] Add support for AD4080 ADC Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250518181424.15a2187b@jic23-huawei \
--to=jic23@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox