* [PATCH 1/2] arm64: dts: rockchip: drop touch panel display from rockpro64
@ 2025-05-18 21:59 Peter Robinson
2025-05-18 21:59 ` [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen Peter Robinson
2025-06-09 10:23 ` [PATCH 1/2] arm64: dts: rockchip: drop touch panel display from rockpro64 Heiko Stuebner
0 siblings, 2 replies; 8+ messages in thread
From: Peter Robinson @ 2025-05-18 21:59 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
devicetree, linux-arm-kernel, linux-rockchip, Peter Geis
Cc: Peter Robinson
The touch panel display is an optional add on for the RockPro64
so this should be an DT overlay, drop the panel options in
preparation to add this as an overlay.
This effectively reverts commit b65155c786c4 so as to add an
overlay for it.
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
.../boot/dts/rockchip/rk3399-rockpro64.dtsi | 64 -------------------
1 file changed, 64 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
index 51c6aa26d8285..e848ea6efac3f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
@@ -20,15 +20,6 @@ chosen {
stdout-path = "serial2:1500000n8";
};
- /* enable for panel backlight support */
- backlight: backlight {
- compatible = "pwm-backlight";
- brightness-levels = <0 4 8 16 32 64 128 255>;
- default-brightness-level = <5>;
- pwms = <&pwm0 0 1000000 0>;
- status = "disabled";
- };
-
clkin_gmac: external-gmac-clock {
compatible = "fixed-clock";
clock-frequency = <125000000>;
@@ -116,14 +107,6 @@ dit_p0_0: endpoint {
};
};
- avdd: regulator-avdd {
- compatible = "regulator-fixed";
- regulator-name = "avdd";
- regulator-min-microvolt = <11000000>;
- regulator-max-microvolt = <11000000>;
- vin-supply = <&vcc3v3_s0>;
- };
-
vcc12v_dcin: regulator-vcc12v-dcin {
compatible = "regulator-fixed";
regulator-name = "vcc12v_dcin";
@@ -590,19 +573,6 @@ fusb0: typec-portc@22 {
vbus-supply = <&vcc5v0_typec>;
status = "okay";
};
-
- /* enable for pine64 touch screen support */
- touch: touchscreen@5d {
- compatible = "goodix,gt911";
- reg = <0x5d>;
- interrupt-parent = <&gpio4>;
- interrupts = <RK_PD5 IRQ_TYPE_EDGE_FALLING>;
- AVDD28-supply = <&vcc3v0_touch>;
- VDDIO-supply = <&vcc3v0_touch>;
- irq-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_HIGH>;
- reset-gpios = <&gpio4 RK_PD6 GPIO_ACTIVE_HIGH>;
- status = "disabled";
- };
};
&i2s0 {
@@ -638,36 +608,6 @@ &io_domains {
gpio1830-supply = <&vcc_3v0>;
};
-/* enable for pine64 panel display support */
-&mipi_dsi {
- clock-master;
- status = "disabled";
-
- ports {
- mipi_out: port@1 {
- reg = <1>;
-
- mipi_out_panel: endpoint {
- remote-endpoint = <&mipi_in_panel>;
- };
- };
- };
-
- mipi_panel: panel@0 {
- compatible = "feiyang,fy07024di26a30d";
- reg = <0>;
- avdd-supply = <&avdd>;
- backlight = <&backlight>;
- dvdd-supply = <&vcc3v3_s0>;
-
- port {
- mipi_in_panel: endpoint {
- remote-endpoint = <&mipi_out_panel>;
- };
- };
- };
-};
-
&pcie0 {
ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
num-lanes = <4>;
@@ -782,10 +722,6 @@ vcc5v0_host_en: vcc5v0-host-en {
};
};
-&pwm0 {
- status = "okay";
-};
-
&pwm1 {
status = "okay";
};
--
2.49.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen
2025-05-18 21:59 [PATCH 1/2] arm64: dts: rockchip: drop touch panel display from rockpro64 Peter Robinson
@ 2025-05-18 21:59 ` Peter Robinson
2025-06-10 10:44 ` Krzysztof Kozlowski
2025-06-10 11:33 ` Diederik de Haas
2025-06-09 10:23 ` [PATCH 1/2] arm64: dts: rockchip: drop touch panel display from rockpro64 Heiko Stuebner
1 sibling, 2 replies; 8+ messages in thread
From: Peter Robinson @ 2025-05-18 21:59 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
devicetree, linux-arm-kernel, linux-rockchip, Peter Geis
Cc: Peter Robinson
The Pine64 touch panel is a panel consisting of the Feiyang fy07024di26a30d
panel with a Goodix gt911 touch screen. Add a device tree overlay to
allow the display to be easily used on the device.
This was previously included in the main device tree but left disabled
by default which still required rebuilding the DT to use the device, now
overlays can go upstream the overlay is the best way to handle the
add on devices.
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
arch/arm64/boot/dts/rockchip/Makefile | 9 ++
.../dts/rockchip/rk3399-rockpro64-screen.dtso | 89 +++++++++++++++++++
2 files changed, 98 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64-screen.dtso
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 3e8771ef69ba1..c7b13bff3ac20 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -77,6 +77,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4c.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock960.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-v2.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtso
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire-excavator.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb
@@ -209,6 +210,14 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou-haikou-video-demo.dtb
rk3399-puma-haikou-haikou-video-demo-dtbs := rk3399-puma-haikou.dtb \
rk3399-puma-haikou-video-demo.dtbo
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtb
+rk3399-rockpro64-screen-dtbs := rk3399-rockpro64.dtb \
+ rk3399-rockpro64-screen.dtbo
+
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtb
+rk3399-rockpro64-v2-screen-dtbs := rk3399-rockpro64-v2.dtb \
+ rk3399-rockpro64-screen.dtbo
+
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-vz-2-uhd.dtb
rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb \
rk3568-wolfvision-pf5-display-vz.dtbo \
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64-screen.dtso b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64-screen.dtso
new file mode 100644
index 0000000000000..26899cd67fc9b
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64-screen.dtso
@@ -0,0 +1,89 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd.
+ * Copyright (c) 2025 Peter Robinson <pbrobinson@gmail.com>
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/pinctrl/rockchip.h>
+
+&{/} {
+ avdd: regulator-avdd {
+ compatible = "regulator-fixed";
+ regulator-name = "avdd";
+ regulator-min-microvolt = <11000000>;
+ regulator-max-microvolt = <11000000>;
+ vin-supply = <&vcc3v3_s0>;
+ };
+
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ brightness-levels = <0 4 8 16 32 64 128 255>;
+ default-brightness-level = <5>;
+ pwms = <&pwm0 0 1000000 0>;
+ status = "okay";
+ };
+};
+
+&i2c4 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ touch: touchscreen@5d {
+ compatible = "goodix,gt911";
+ reg = <0x5d>;
+ interrupt-parent = <&gpio4>;
+ interrupts = <RK_PD5 IRQ_TYPE_EDGE_FALLING>;
+ AVDD28-supply = <&vcc3v0_touch>;
+ VDDIO-supply = <&vcc3v0_touch>;
+ irq-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpio4 RK_PD6 GPIO_ACTIVE_HIGH>;
+ status = "okay";
+ };
+};
+
+&mipi_dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ clock-master;
+ status = "okay";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ mipi_out: port@1 {
+ reg = <1>;
+
+ mipi_out_panel: endpoint {
+ remote-endpoint = <&mipi_in_panel>;
+ };
+ };
+ };
+
+ mipi_panel: panel@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ compatible = "feiyang,fy07024di26a30d";
+ reg = <0>;
+ avdd-supply = <&avdd>;
+ backlight = <&backlight>;
+ dvdd-supply = <&vcc3v3_s0>;
+
+ port {
+ mipi_in_panel: endpoint {
+ remote-endpoint = <&mipi_out_panel>;
+ };
+ };
+ };
+};
+
+&pwm0 {
+ status = "okay";
+};
--
2.49.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] arm64: dts: rockchip: drop touch panel display from rockpro64
2025-05-18 21:59 [PATCH 1/2] arm64: dts: rockchip: drop touch panel display from rockpro64 Peter Robinson
2025-05-18 21:59 ` [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen Peter Robinson
@ 2025-06-09 10:23 ` Heiko Stuebner
1 sibling, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2025-06-09 10:23 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-arm-kernel, linux-rockchip, Peter Geis, Peter Robinson
Cc: Heiko Stuebner
On Sun, 18 May 2025 22:59:33 +0100, Peter Robinson wrote:
> The touch panel display is an optional add on for the RockPro64
> so this should be an DT overlay, drop the panel options in
> preparation to add this as an overlay.
>
> This effectively reverts commit b65155c786c4 so as to add an
> overlay for it.
>
> [...]
Applied, thanks!
[1/2] arm64: dts: rockchip: drop touch panel display from rockpro64
commit: d69cb63780943fc1b0765bb9b46f627573cc97d1
[2/2] arm64: dts: rockchip: add overlay for RockPro64 screen
commit: 49760b9f60528393cca3ea35c4d0719f84215a48
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen
2025-05-18 21:59 ` [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen Peter Robinson
@ 2025-06-10 10:44 ` Krzysztof Kozlowski
2025-06-10 10:48 ` Krzysztof Kozlowski
2025-06-10 11:33 ` Diederik de Haas
1 sibling, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-10 10:44 UTC (permalink / raw)
To: Peter Robinson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip,
Peter Geis
On 18/05/2025 23:59, Peter Robinson wrote:
> The Pine64 touch panel is a panel consisting of the Feiyang fy07024di26a30d
> panel with a Goodix gt911 touch screen. Add a device tree overlay to
> allow the display to be easily used on the device.
>
> This was previously included in the main device tree but left disabled
> by default which still required rebuilding the DT to use the device, now
> overlays can go upstream the overlay is the best way to handle the
> add on devices.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 9 ++
> .../dts/rockchip/rk3399-rockpro64-screen.dtso | 89 +++++++++++++++++++
> 2 files changed, 98 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64-screen.dtso
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 3e8771ef69ba1..c7b13bff3ac20 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -77,6 +77,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4c.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock960.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-v2.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtso
This was absolutely never built as reported by Naresh. You should never
sent patches which are at least built tested... although they should be
actually tested as well, but if code does not build actual testing is
impossible.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen
2025-06-10 10:44 ` Krzysztof Kozlowski
@ 2025-06-10 10:48 ` Krzysztof Kozlowski
2025-06-10 11:15 ` Heiko Stübner
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-10 10:48 UTC (permalink / raw)
To: Peter Robinson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip,
Peter Geis
On 10/06/2025 12:44, Krzysztof Kozlowski wrote:
> On 18/05/2025 23:59, Peter Robinson wrote:
>> The Pine64 touch panel is a panel consisting of the Feiyang fy07024di26a30d
>> panel with a Goodix gt911 touch screen. Add a device tree overlay to
>> allow the display to be easily used on the device.
>>
>> This was previously included in the main device tree but left disabled
>> by default which still required rebuilding the DT to use the device, now
>> overlays can go upstream the overlay is the best way to handle the
>> add on devices.
>>
>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>> ---
>> arch/arm64/boot/dts/rockchip/Makefile | 9 ++
>> .../dts/rockchip/rk3399-rockpro64-screen.dtso | 89 +++++++++++++++++++
>> 2 files changed, 98 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64-screen.dtso
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
>> index 3e8771ef69ba1..c7b13bff3ac20 100644
>> --- a/arch/arm64/boot/dts/rockchip/Makefile
>> +++ b/arch/arm64/boot/dts/rockchip/Makefile
>> @@ -77,6 +77,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4c.dtb
>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock960.dtb
>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-v2.dtb
>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb
>> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtso
>
>
> This was absolutely never built as reported by Naresh. You should never
> sent patches which are at least built tested... although they should be
> actually tested as well, but if code does not build actual testing is
> impossible.
Huh, I was wrong - this actually builds, just cannot execute install target.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen
2025-06-10 10:48 ` Krzysztof Kozlowski
@ 2025-06-10 11:15 ` Heiko Stübner
0 siblings, 0 replies; 8+ messages in thread
From: Heiko Stübner @ 2025-06-10 11:15 UTC (permalink / raw)
To: Peter Robinson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-arm-kernel, linux-rockchip, Peter Geis,
Krzysztof Kozlowski
Am Dienstag, 10. Juni 2025, 12:48:50 Mitteleuropäische Sommerzeit schrieb Krzysztof Kozlowski:
> On 10/06/2025 12:44, Krzysztof Kozlowski wrote:
> > On 18/05/2025 23:59, Peter Robinson wrote:
> >> The Pine64 touch panel is a panel consisting of the Feiyang fy07024di26a30d
> >> panel with a Goodix gt911 touch screen. Add a device tree overlay to
> >> allow the display to be easily used on the device.
> >>
> >> This was previously included in the main device tree but left disabled
> >> by default which still required rebuilding the DT to use the device, now
> >> overlays can go upstream the overlay is the best way to handle the
> >> add on devices.
> >>
> >> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> >> ---
> >> arch/arm64/boot/dts/rockchip/Makefile | 9 ++
> >> .../dts/rockchip/rk3399-rockpro64-screen.dtso | 89 +++++++++++++++++++
> >> 2 files changed, 98 insertions(+)
> >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64-screen.dtso
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> >> index 3e8771ef69ba1..c7b13bff3ac20 100644
> >> --- a/arch/arm64/boot/dts/rockchip/Makefile
> >> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> >> @@ -77,6 +77,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4c.dtb
> >> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock960.dtb
> >> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-v2.dtb
> >> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb
> >> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtso
> >
> >
> > This was absolutely never built as reported by Naresh. You should never
> > sent patches which are at least built tested... although they should be
> > actually tested as well, but if code does not build actual testing is
> > impossible.
>
> Huh, I was wrong - this actually builds, just cannot execute install target.
I did build it as well after applying - but still managed to overlook the dtso vs. dtbo
But I'm surprised that still built yesterday
I'll amend the commit for the dtso -> dtbo change.
Heiko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen
2025-05-18 21:59 ` [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen Peter Robinson
2025-06-10 10:44 ` Krzysztof Kozlowski
@ 2025-06-10 11:33 ` Diederik de Haas
2025-06-10 12:20 ` Diederik de Haas
1 sibling, 1 reply; 8+ messages in thread
From: Diederik de Haas @ 2025-06-10 11:33 UTC (permalink / raw)
To: Peter Robinson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip,
Peter Geis
[-- Attachment #1: Type: text/plain, Size: 2388 bytes --]
Hi,
On Sun May 18, 2025 at 11:59 PM CEST, Peter Robinson wrote:
> The Pine64 touch panel is a panel consisting of the Feiyang fy07024di26a30d
> panel with a Goodix gt911 touch screen. Add a device tree overlay to
> allow the display to be easily used on the device.
>
> This was previously included in the main device tree but left disabled
> by default which still required rebuilding the DT to use the device, now
> overlays can go upstream the overlay is the best way to handle the
> add on devices.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 9 ++
> .../dts/rockchip/rk3399-rockpro64-screen.dtso | 89 +++++++++++++++++++
> 2 files changed, 98 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64-screen.dtso
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 3e8771ef69ba1..c7b13bff3ac20 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -77,6 +77,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4c.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock960.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-v2.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtso
``s/rk3399-rockpro64-screen.dtso/rk3399-rockpro64-screen.dtbo``
Cheers,
Diederik
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire-excavator.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb
> @@ -209,6 +210,14 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou-haikou-video-demo.dtb
> rk3399-puma-haikou-haikou-video-demo-dtbs := rk3399-puma-haikou.dtb \
> rk3399-puma-haikou-video-demo.dtbo
>
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtb
> +rk3399-rockpro64-screen-dtbs := rk3399-rockpro64.dtb \
> + rk3399-rockpro64-screen.dtbo
> +
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtb
> +rk3399-rockpro64-v2-screen-dtbs := rk3399-rockpro64-v2.dtb \
> + rk3399-rockpro64-screen.dtbo
> +
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-vz-2-uhd.dtb
> rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb \
> rk3568-wolfvision-pf5-display-vz.dtbo \
> <snip>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen
2025-06-10 11:33 ` Diederik de Haas
@ 2025-06-10 12:20 ` Diederik de Haas
0 siblings, 0 replies; 8+ messages in thread
From: Diederik de Haas @ 2025-06-10 12:20 UTC (permalink / raw)
To: Diederik de Haas, Peter Robinson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, devicetree,
linux-arm-kernel, linux-rockchip, Peter Geis
[-- Attachment #1: Type: text/plain, Size: 2250 bytes --]
On Tue Jun 10, 2025 at 1:33 PM CEST, Diederik de Haas wrote:
> On Sun May 18, 2025 at 11:59 PM CEST, Peter Robinson wrote:
>> The Pine64 touch panel is a panel consisting of the Feiyang fy07024di26a30d
>> panel with a Goodix gt911 touch screen. Add a device tree overlay to
>> allow the display to be easily used on the device.
>> ...
>> ---
>> arch/arm64/boot/dts/rockchip/Makefile | 9 ++
>> .../dts/rockchip/rk3399-rockpro64-screen.dtso | 89 +++++++++++++++++++
>> 2 files changed, 98 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64-screen.dtso
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
>> index 3e8771ef69ba1..c7b13bff3ac20 100644
>> --- a/arch/arm64/boot/dts/rockchip/Makefile
>> +++ b/arch/arm64/boot/dts/rockchip/Makefile
>> @@ -77,6 +77,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4c.dtb
>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock960.dtb
>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-v2.dtb
>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb
>> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtso
>
> ``s/rk3399-rockpro64-screen.dtso/rk3399-rockpro64-screen.dtbo``
nvm, it was already correctly applied by Heiko.
> Cheers,
> Diederik
>
>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire.dtb
>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire-excavator.dtb
>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb
>> @@ -209,6 +210,14 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou-haikou-video-demo.dtb
>> rk3399-puma-haikou-haikou-video-demo-dtbs := rk3399-puma-haikou.dtb \
>> rk3399-puma-haikou-video-demo.dtbo
>>
>> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtb
>> +rk3399-rockpro64-screen-dtbs := rk3399-rockpro64.dtb \
>> + rk3399-rockpro64-screen.dtbo
>> +
>> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtb
>> +rk3399-rockpro64-v2-screen-dtbs := rk3399-rockpro64-v2.dtb \
>> + rk3399-rockpro64-screen.dtbo
>> +
>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-vz-2-uhd.dtb
>> rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb \
>> rk3568-wolfvision-pf5-display-vz.dtbo \
>> <snip>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-06-10 12:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-18 21:59 [PATCH 1/2] arm64: dts: rockchip: drop touch panel display from rockpro64 Peter Robinson
2025-05-18 21:59 ` [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen Peter Robinson
2025-06-10 10:44 ` Krzysztof Kozlowski
2025-06-10 10:48 ` Krzysztof Kozlowski
2025-06-10 11:15 ` Heiko Stübner
2025-06-10 11:33 ` Diederik de Haas
2025-06-10 12:20 ` Diederik de Haas
2025-06-09 10:23 ` [PATCH 1/2] arm64: dts: rockchip: drop touch panel display from rockpro64 Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).