* [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-05-19 12:15 [PATCH 0/7] archs: use proper node names for GPIO based I2C busses Wolfram Sang
@ 2025-05-19 12:15 ` Wolfram Sang
2025-05-19 13:54 ` Krzysztof Kozlowski
2025-05-19 12:15 ` [PATCH 2/7] arm64: dts: mediatek: " Wolfram Sang
` (7 subsequent siblings)
8 siblings, 1 reply; 25+ messages in thread
From: Wolfram Sang @ 2025-05-19 12:15 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Wolfram Sang, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc
There shall not be a '-' before the number.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 8f02de8480b6..197de398dd9b 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -85,7 +85,7 @@ homepage-key {
};
};
- i2c_max98504: i2c-gpio-0 {
+ i2c_max98504: i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&gpd0 1 GPIO_ACTIVE_HIGH>;
scl-gpios = <&gpd0 0 GPIO_ACTIVE_HIGH>;
--
2.47.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-05-19 12:15 ` [PATCH 1/7] arm64: dts: exynos: " Wolfram Sang
@ 2025-05-19 13:54 ` Krzysztof Kozlowski
2025-05-19 14:45 ` Wolfram Sang
0 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-19 13:54 UTC (permalink / raw)
To: Wolfram Sang, linux-renesas-soc
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
devicetree, linux-arm-kernel, linux-samsung-soc
On 19/05/2025 14:15, Wolfram Sang wrote:
> There shall not be a '-' before the number.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 8f02de8480b6..197de398dd9b 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -85,7 +85,7 @@ homepage-key {
> };
> };
>
> - i2c_max98504: i2c-gpio-0 {
> + i2c_max98504: i2c-gpio0 {
You did not paste the warning in commit msg, so I don't know the
rationale, but at first glance this is not correct. "-0" is the
preferred suffix. "0" is not.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-05-19 13:54 ` Krzysztof Kozlowski
@ 2025-05-19 14:45 ` Wolfram Sang
2025-05-19 15:05 ` Krzysztof Kozlowski
0 siblings, 1 reply; 25+ messages in thread
From: Wolfram Sang @ 2025-05-19 14:45 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-renesas-soc, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
> You did not paste the warning in commit msg, so I don't know the
> rationale, but at first glance this is not correct. "-0" is the
> preferred suffix. "0" is not.
Here is an example:
.../Kernel/linux/arch/arm/boot/dts/microchip/usb_a9g20.dtb: i2c-gpio-0 (i2c-gpio): $nodename:0: 'i2c-gpio-0' does not match '^i2c(@.+|-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-05-19 14:45 ` Wolfram Sang
@ 2025-05-19 15:05 ` Krzysztof Kozlowski
2025-05-19 15:14 ` Wolfram Sang
0 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-19 15:05 UTC (permalink / raw)
To: Wolfram Sang, linux-renesas-soc, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alim Akhtar, devicetree, linux-arm-kernel,
linux-samsung-soc
On 19/05/2025 16:45, Wolfram Sang wrote:
>
>> You did not paste the warning in commit msg, so I don't know the
>> rationale, but at first glance this is not correct. "-0" is the
>> preferred suffix. "0" is not.
>
> Here is an example:
>
> .../Kernel/linux/arch/arm/boot/dts/microchip/usb_a9g20.dtb: i2c-gpio-0 (i2c-gpio): $nodename:0: 'i2c-gpio-0' does not match '^i2c(@.+|-[a-z0-9]+)?$'
> from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#
>
... so clearly the suffix is "-foo" or "-0", as we usually prefer. This
should be replaced into i2c-X, by dropping "gpio", instead of using less
favored suffixing (one without -).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-05-19 15:05 ` Krzysztof Kozlowski
@ 2025-05-19 15:14 ` Wolfram Sang
2025-05-19 16:11 ` Krzysztof Kozlowski
0 siblings, 1 reply; 25+ messages in thread
From: Wolfram Sang @ 2025-05-19 15:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-renesas-soc, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
> ... so clearly the suffix is "-foo" or "-0", as we usually prefer. This
> should be replaced into i2c-X, by dropping "gpio", instead of using less
> favored suffixing (one without -).
Hmm, I can't automate this because it will then need to be aligned with
the bus numbering of other existing non-GPIO-busses. Which is highly
individual per board. That means we need to drop this series?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-05-19 15:14 ` Wolfram Sang
@ 2025-05-19 16:11 ` Krzysztof Kozlowski
2025-05-19 16:25 ` Wolfram Sang
2025-05-19 16:28 ` Herve Codina
0 siblings, 2 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-19 16:11 UTC (permalink / raw)
To: Wolfram Sang, linux-renesas-soc, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alim Akhtar, devicetree, linux-arm-kernel,
linux-samsung-soc, Herve Codina
On 19/05/2025 17:14, Wolfram Sang wrote:
>
>> ... so clearly the suffix is "-foo" or "-0", as we usually prefer. This
>> should be replaced into i2c-X, by dropping "gpio", instead of using less
>> favored suffixing (one without -).
>
> Hmm, I can't automate this because it will then need to be aligned with
> the bus numbering of other existing non-GPIO-busses. Which is highly
> individual per board. That means we need to drop this series?
I think either we use i2c-X or commit 57138f5b8c92 ("schemas: i2c: Avoid
extra characters in i2c nodename pattern") from Herve was not correct
and needs to be fixed.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-05-19 16:11 ` Krzysztof Kozlowski
@ 2025-05-19 16:25 ` Wolfram Sang
2025-05-19 18:50 ` Wolfram Sang
2025-05-19 16:28 ` Herve Codina
1 sibling, 1 reply; 25+ messages in thread
From: Wolfram Sang @ 2025-05-19 16:25 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-renesas-soc, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc,
Herve Codina
[-- Attachment #1: Type: text/plain, Size: 243 bytes --]
> I think either we use i2c-X or commit 57138f5b8c92 ("schemas: i2c: Avoid
> extra characters in i2c nodename pattern") from Herve was not correct
> and needs to be fixed.
I will look if I can fix dt-schema instead. Thanks for the pointer!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-05-19 16:25 ` Wolfram Sang
@ 2025-05-19 18:50 ` Wolfram Sang
2025-06-12 7:46 ` Krzysztof Kozlowski
0 siblings, 1 reply; 25+ messages in thread
From: Wolfram Sang @ 2025-05-19 18:50 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-renesas-soc, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar, devicetree,
linux-arm-kernel, linux-samsung-soc, Herve Codina
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
On Mon, May 19, 2025 at 06:25:39PM +0200, Wolfram Sang wrote:
>
> > I think either we use i2c-X or commit 57138f5b8c92 ("schemas: i2c: Avoid
> > extra characters in i2c nodename pattern") from Herve was not correct
> > and needs to be fixed.
>
> I will look if I can fix dt-schema instead. Thanks for the pointer!
Found it! Patch sent.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-05-19 18:50 ` Wolfram Sang
@ 2025-06-12 7:46 ` Krzysztof Kozlowski
2025-06-12 7:50 ` Wolfram Sang
0 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-12 7:46 UTC (permalink / raw)
To: Wolfram Sang, linux-renesas-soc, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alim Akhtar, devicetree, linux-arm-kernel,
linux-samsung-soc, Herve Codina
On 19/05/2025 20:50, Wolfram Sang wrote:
> On Mon, May 19, 2025 at 06:25:39PM +0200, Wolfram Sang wrote:
>>
>>> I think either we use i2c-X or commit 57138f5b8c92 ("schemas: i2c: Avoid
>>> extra characters in i2c nodename pattern") from Herve was not correct
>>> and needs to be fixed.
>>
>> I will look if I can fix dt-schema instead. Thanks for the pointer!
>
> Found it! Patch sent.
>
Where? I cannot find anything in my inbox and also no pull requests on
Github.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-06-12 7:46 ` Krzysztof Kozlowski
@ 2025-06-12 7:50 ` Wolfram Sang
2025-06-12 9:02 ` Krzysztof Kozlowski
2025-06-12 9:49 ` Krzysztof Kozlowski
0 siblings, 2 replies; 25+ messages in thread
From: Wolfram Sang @ 2025-06-12 7:50 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-renesas-soc, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc,
Herve Codina
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
> Where? I cannot find anything in my inbox and also no pull requests on
> Github.
https://lore.kernel.org/r/20250519184530.21845-1-wsa+renesas@sang-engineering.com
You prefer to be explicitly CCed on such mails?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-06-12 7:50 ` Wolfram Sang
@ 2025-06-12 9:02 ` Krzysztof Kozlowski
2025-06-12 9:49 ` Krzysztof Kozlowski
1 sibling, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-12 9:02 UTC (permalink / raw)
To: Wolfram Sang, linux-renesas-soc, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alim Akhtar, devicetree, linux-arm-kernel,
linux-samsung-soc, Herve Codina
On 12/06/2025 09:50, Wolfram Sang wrote:
>
>> Where? I cannot find anything in my inbox and also no pull requests on
>> Github.
>
> https://lore.kernel.org/r/20250519184530.21845-1-wsa+renesas@sang-engineering.com
Thanks
>
> You prefer to be explicitly CCed on such mails?
If you ask me for review, then yes, but if you do not then no problem. I
just could not find it since it was not cc to dt list.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-06-12 7:50 ` Wolfram Sang
2025-06-12 9:02 ` Krzysztof Kozlowski
@ 2025-06-12 9:49 ` Krzysztof Kozlowski
2025-06-12 9:54 ` Wolfram Sang
1 sibling, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-12 9:49 UTC (permalink / raw)
To: Wolfram Sang, linux-renesas-soc, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alim Akhtar, devicetree, linux-arm-kernel,
linux-samsung-soc, Herve Codina
On 12/06/2025 09:50, Wolfram Sang wrote:
>
>> Where? I cannot find anything in my inbox and also no pull requests on
>> Github.
>
> https://lore.kernel.org/r/20250519184530.21845-1-wsa+renesas@sang-engineering.com
>
> You prefer to be explicitly CCed on such mails?
I see my approach of using generic i2c-X was also preferred by Rob, so I
guess it won't get it.
I sent patch for Samsung, with reported-by credits for you (it's also
reported now by my tests and earlier by Rob's as well, though).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-06-12 9:49 ` Krzysztof Kozlowski
@ 2025-06-12 9:54 ` Wolfram Sang
0 siblings, 0 replies; 25+ messages in thread
From: Wolfram Sang @ 2025-06-12 9:54 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-renesas-soc, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc,
Herve Codina
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
> > https://lore.kernel.org/r/20250519184530.21845-1-wsa+renesas@sang-engineering.com
>
> I see my approach of using generic i2c-X was also preferred by Rob, so I
> guess it won't get it.
Okay, if you guys say so...
> I sent patch for Samsung, with reported-by credits for you (it's also
> reported now by my tests and earlier by Rob's as well, though).
I will fix the AT91-based Calao boards somewhen, and then I
consider this case closed for me. Thank you both for guidance!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
2025-05-19 16:11 ` Krzysztof Kozlowski
2025-05-19 16:25 ` Wolfram Sang
@ 2025-05-19 16:28 ` Herve Codina
1 sibling, 0 replies; 25+ messages in thread
From: Herve Codina @ 2025-05-19 16:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Wolfram Sang, linux-renesas-soc, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alim Akhtar, devicetree, linux-arm-kernel,
linux-samsung-soc
On Mon, 19 May 2025 18:11:29 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 19/05/2025 17:14, Wolfram Sang wrote:
> >
> >> ... so clearly the suffix is "-foo" or "-0", as we usually prefer. This
> >> should be replaced into i2c-X, by dropping "gpio", instead of using less
> >> favored suffixing (one without -).
> >
> > Hmm, I can't automate this because it will then need to be aligned with
> > the bus numbering of other existing non-GPIO-busses. Which is highly
> > individual per board. That means we need to drop this series?
>
> I think either we use i2c-X or commit 57138f5b8c92 ("schemas: i2c: Avoid
> extra characters in i2c nodename pattern") from Herve was not correct
> and needs to be fixed.
>
I don't know if relevant for this case but Rob did the fix
647181a ("schemas: i2c: Allow for 'i2c-.*' node names")
on top of my commit.
Best regards,
Hervé
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 2/7] arm64: dts: mediatek: use proper node names for GPIO based I2C busses
2025-05-19 12:15 [PATCH 0/7] archs: use proper node names for GPIO based I2C busses Wolfram Sang
2025-05-19 12:15 ` [PATCH 1/7] arm64: dts: exynos: " Wolfram Sang
@ 2025-05-19 12:15 ` Wolfram Sang
2025-05-19 12:15 ` [PATCH 3/7] ARM: dts: microchip: " Wolfram Sang
` (6 subsequent siblings)
8 siblings, 0 replies; 25+ messages in thread
From: Wolfram Sang @ 2025-05-19 12:15 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Wolfram Sang, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, devicetree,
linux-arm-kernel, linux-mediatek
There shall not be a '-' before the number.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
index ed79ad1ae871..d0e1d8f064c4 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
@@ -64,7 +64,7 @@ wps-key {
};
/* i2c of the left SFP cage (wan) */
- i2c_sfp1: i2c-gpio-0 {
+ i2c_sfp1: i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&pio 16 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&pio 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -74,7 +74,7 @@ i2c_sfp1: i2c-gpio-0 {
};
/* i2c of the right SFP cage (lan) */
- i2c_sfp2: i2c-gpio-1 {
+ i2c_sfp2: i2c-gpio1 {
compatible = "i2c-gpio";
sda-gpios = <&pio 18 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&pio 19 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
--
2.47.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 3/7] ARM: dts: microchip: use proper node names for GPIO based I2C busses
2025-05-19 12:15 [PATCH 0/7] archs: use proper node names for GPIO based I2C busses Wolfram Sang
2025-05-19 12:15 ` [PATCH 1/7] arm64: dts: exynos: " Wolfram Sang
2025-05-19 12:15 ` [PATCH 2/7] arm64: dts: mediatek: " Wolfram Sang
@ 2025-05-19 12:15 ` Wolfram Sang
2025-05-19 12:15 ` [PATCH 4/7] ARM: dts: samsung: " Wolfram Sang
` (5 subsequent siblings)
8 siblings, 0 replies; 25+ messages in thread
From: Wolfram Sang @ 2025-05-19 12:15 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Wolfram Sang, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, devicetree,
linux-arm-kernel
There shall not be a '-' before the number.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm/boot/dts/microchip/at91-foxg20.dts | 2 +-
arch/arm/boot/dts/microchip/at91-qil_a9260.dts | 2 +-
arch/arm/boot/dts/microchip/at91-sam9_l9260.dts | 2 +-
arch/arm/boot/dts/microchip/at91rm9200.dtsi | 2 +-
arch/arm/boot/dts/microchip/at91sam9260.dtsi | 2 +-
arch/arm/boot/dts/microchip/at91sam9260ek.dts | 2 +-
arch/arm/boot/dts/microchip/at91sam9261.dtsi | 2 +-
arch/arm/boot/dts/microchip/at91sam9263.dtsi | 2 +-
arch/arm/boot/dts/microchip/at91sam9263ek.dts | 2 +-
arch/arm/boot/dts/microchip/at91sam9g20ek_common.dtsi | 2 +-
arch/arm/boot/dts/microchip/at91sam9g45.dtsi | 2 +-
arch/arm/boot/dts/microchip/at91sam9n12.dtsi | 2 +-
arch/arm/boot/dts/microchip/at91sam9rl.dtsi | 4 ++--
arch/arm/boot/dts/microchip/at91sam9rlek.dts | 4 ++--
arch/arm/boot/dts/microchip/at91sam9x5.dtsi | 6 +++---
arch/arm/boot/dts/microchip/ethernut5.dts | 2 +-
arch/arm/boot/dts/microchip/evk-pro3.dts | 2 +-
arch/arm/boot/dts/microchip/mpa1600.dts | 2 +-
arch/arm/boot/dts/microchip/tny_a9263.dts | 2 +-
arch/arm/boot/dts/microchip/usb_a9260_common.dtsi | 2 +-
arch/arm/boot/dts/microchip/usb_a9263.dts | 2 +-
arch/arm/boot/dts/microchip/usb_a9g20_lpw.dts | 2 +-
22 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/arch/arm/boot/dts/microchip/at91-foxg20.dts b/arch/arm/boot/dts/microchip/at91-foxg20.dts
index 8e9e87665045..6b9f6afc1c0c 100644
--- a/arch/arm/boot/dts/microchip/at91-foxg20.dts
+++ b/arch/arm/boot/dts/microchip/at91-foxg20.dts
@@ -137,7 +137,7 @@ usb0: usb@500000 {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_i2c0>;
i2c-gpio,delay-us = <5>; /* ~85 kHz */
diff --git a/arch/arm/boot/dts/microchip/at91-qil_a9260.dts b/arch/arm/boot/dts/microchip/at91-qil_a9260.dts
index 892dbd8dbbed..ae14e54cca8e 100644
--- a/arch/arm/boot/dts/microchip/at91-qil_a9260.dts
+++ b/arch/arm/boot/dts/microchip/at91-qil_a9260.dts
@@ -207,7 +207,7 @@ button-user {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
status = "okay";
};
};
diff --git a/arch/arm/boot/dts/microchip/at91-sam9_l9260.dts b/arch/arm/boot/dts/microchip/at91-sam9_l9260.dts
index 49dc1a4ccb36..6fd4f5fbc0d4 100644
--- a/arch/arm/boot/dts/microchip/at91-sam9_l9260.dts
+++ b/arch/arm/boot/dts/microchip/at91-sam9_l9260.dts
@@ -111,7 +111,7 @@ usb0: usb@500000 {
};
- i2c-gpio-0 {
+ i2c-gpio0 {
status = "okay";
};
diff --git a/arch/arm/boot/dts/microchip/at91rm9200.dtsi b/arch/arm/boot/dts/microchip/at91rm9200.dtsi
index e105ad855ce8..e9f808182b6b 100644
--- a/arch/arm/boot/dts/microchip/at91rm9200.dtsi
+++ b/arch/arm/boot/dts/microchip/at91rm9200.dtsi
@@ -712,7 +712,7 @@ usb0: usb@300000 {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&pioA 25 GPIO_ACTIVE_HIGH>;
scl-gpios = <&pioA 26 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm/boot/dts/microchip/at91sam9260.dtsi b/arch/arm/boot/dts/microchip/at91sam9260.dtsi
index fc0b6a73204f..23ae36c2eef6 100644
--- a/arch/arm/boot/dts/microchip/at91sam9260.dtsi
+++ b/arch/arm/boot/dts/microchip/at91sam9260.dtsi
@@ -779,7 +779,7 @@ nand_controller: nand-controller {
};
};
- i2c_gpio0: i2c-gpio-0 {
+ i2c_gpio0: i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&pioA 23 GPIO_ACTIVE_HIGH>;
scl-gpios = <&pioA 24 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm/boot/dts/microchip/at91sam9260ek.dts b/arch/arm/boot/dts/microchip/at91sam9260ek.dts
index 8522a210b484..8373980b9bc9 100644
--- a/arch/arm/boot/dts/microchip/at91sam9260ek.dts
+++ b/arch/arm/boot/dts/microchip/at91sam9260ek.dts
@@ -162,7 +162,7 @@ button-4 {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
status = "okay";
eeprom@50 {
diff --git a/arch/arm/boot/dts/microchip/at91sam9261.dtsi b/arch/arm/boot/dts/microchip/at91sam9261.dtsi
index d1d678b77e84..9fe1918fc0b5 100644
--- a/arch/arm/boot/dts/microchip/at91sam9261.dtsi
+++ b/arch/arm/boot/dts/microchip/at91sam9261.dtsi
@@ -651,7 +651,7 @@ gpbr: syscon@fffffd50 {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_i2c_bitbang>;
diff --git a/arch/arm/boot/dts/microchip/at91sam9263.dtsi b/arch/arm/boot/dts/microchip/at91sam9263.dtsi
index a4b5d1f228f9..42949a989ec5 100644
--- a/arch/arm/boot/dts/microchip/at91sam9263.dtsi
+++ b/arch/arm/boot/dts/microchip/at91sam9263.dtsi
@@ -824,7 +824,7 @@ nand_controller1: nand-controller {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&pioB 4 GPIO_ACTIVE_HIGH>;
scl-gpios = <&pioB 5 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm/boot/dts/microchip/at91sam9263ek.dts b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
index 93c5268a0845..3dafdd02f6c0 100644
--- a/arch/arm/boot/dts/microchip/at91sam9263ek.dts
+++ b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
@@ -250,7 +250,7 @@ button-right-click {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
status = "okay";
eeprom@50 {
diff --git a/arch/arm/boot/dts/microchip/at91sam9g20ek_common.dtsi b/arch/arm/boot/dts/microchip/at91sam9g20ek_common.dtsi
index 84a7287107f8..3f4d27c3644e 100644
--- a/arch/arm/boot/dts/microchip/at91sam9g20ek_common.dtsi
+++ b/arch/arm/boot/dts/microchip/at91sam9g20ek_common.dtsi
@@ -217,7 +217,7 @@ usb0: usb@500000 {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
status = "okay";
eeprom@50 {
diff --git a/arch/arm/boot/dts/microchip/at91sam9g45.dtsi b/arch/arm/boot/dts/microchip/at91sam9g45.dtsi
index 4e00ed2d3ecd..a4de194a724f 100644
--- a/arch/arm/boot/dts/microchip/at91sam9g45.dtsi
+++ b/arch/arm/boot/dts/microchip/at91sam9g45.dtsi
@@ -1008,7 +1008,7 @@ nand_controller: nand-controller {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&pioA 20 GPIO_ACTIVE_HIGH>;
scl-gpios = <&pioA 21 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm/boot/dts/microchip/at91sam9n12.dtsi b/arch/arm/boot/dts/microchip/at91sam9n12.dtsi
index af41c3dbb4bf..e8239fcfff01 100644
--- a/arch/arm/boot/dts/microchip/at91sam9n12.dtsi
+++ b/arch/arm/boot/dts/microchip/at91sam9n12.dtsi
@@ -784,7 +784,7 @@ nand_controller: nand-controller {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&pioA 30 GPIO_ACTIVE_HIGH>;
scl-gpios = <&pioA 31 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm/boot/dts/microchip/at91sam9rl.dtsi b/arch/arm/boot/dts/microchip/at91sam9rl.dtsi
index de74cf2980a0..f1e2f383ed86 100644
--- a/arch/arm/boot/dts/microchip/at91sam9rl.dtsi
+++ b/arch/arm/boot/dts/microchip/at91sam9rl.dtsi
@@ -831,7 +831,7 @@ rtc@fffffe00 {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&pioA 23 GPIO_ACTIVE_HIGH>;
scl-gpios = <&pioA 24 GPIO_ACTIVE_HIGH>;
@@ -845,7 +845,7 @@ i2c-gpio-0 {
status = "disabled";
};
- i2c-gpio-1 {
+ i2c-gpio1 {
compatible = "i2c-gpio";
sda-gpios = <&pioD 10 GPIO_ACTIVE_HIGH>;
scl-gpios = <&pioD 11 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm/boot/dts/microchip/at91sam9rlek.dts b/arch/arm/boot/dts/microchip/at91sam9rlek.dts
index a57351270551..0ab5adebb8ff 100644
--- a/arch/arm/boot/dts/microchip/at91sam9rlek.dts
+++ b/arch/arm/boot/dts/microchip/at91sam9rlek.dts
@@ -266,11 +266,11 @@ button-left-click {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
status = "okay";
};
- i2c-gpio-1 {
+ i2c-gpio1 {
status = "okay";
};
};
diff --git a/arch/arm/boot/dts/microchip/at91sam9x5.dtsi b/arch/arm/boot/dts/microchip/at91sam9x5.dtsi
index 9070fd06995a..65044901f662 100644
--- a/arch/arm/boot/dts/microchip/at91sam9x5.dtsi
+++ b/arch/arm/boot/dts/microchip/at91sam9x5.dtsi
@@ -931,7 +931,7 @@ nand_controller: nand-controller {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&pioA 30 GPIO_ACTIVE_HIGH>;
scl-gpios = <&pioA 31 GPIO_ACTIVE_HIGH>;
@@ -945,7 +945,7 @@ i2c-gpio-0 {
status = "disabled";
};
- i2c-gpio-1 {
+ i2c-gpio1 {
compatible = "i2c-gpio";
sda-gpios = <&pioC 0 GPIO_ACTIVE_HIGH>;
scl-gpios = <&pioC 1 GPIO_ACTIVE_HIGH>;
@@ -959,7 +959,7 @@ i2c-gpio-1 {
status = "disabled";
};
- i2c-gpio-2 {
+ i2c-gpio2 {
compatible = "i2c-gpio";
sda-gpios = <&pioB 4 GPIO_ACTIVE_HIGH>;
scl-gpios = <&pioB 5 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm/boot/dts/microchip/ethernut5.dts b/arch/arm/boot/dts/microchip/ethernut5.dts
index 52ccef31b391..98ae08549362 100644
--- a/arch/arm/boot/dts/microchip/ethernut5.dts
+++ b/arch/arm/boot/dts/microchip/ethernut5.dts
@@ -107,7 +107,7 @@ usb0: usb@500000 {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
status = "okay";
pcf8563@50 {
diff --git a/arch/arm/boot/dts/microchip/evk-pro3.dts b/arch/arm/boot/dts/microchip/evk-pro3.dts
index 40c5111c2f0a..be4619191538 100644
--- a/arch/arm/boot/dts/microchip/evk-pro3.dts
+++ b/arch/arm/boot/dts/microchip/evk-pro3.dts
@@ -51,7 +51,7 @@ usb0: usb@500000 {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
status = "okay";
};
diff --git a/arch/arm/boot/dts/microchip/mpa1600.dts b/arch/arm/boot/dts/microchip/mpa1600.dts
index 2a97e2c0b894..485a76609718 100644
--- a/arch/arm/boot/dts/microchip/mpa1600.dts
+++ b/arch/arm/boot/dts/microchip/mpa1600.dts
@@ -63,7 +63,7 @@ usb0: usb@300000 {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
status = "okay";
};
diff --git a/arch/arm/boot/dts/microchip/tny_a9263.dts b/arch/arm/boot/dts/microchip/tny_a9263.dts
index fd8244b56e05..784dbafb3856 100644
--- a/arch/arm/boot/dts/microchip/tny_a9263.dts
+++ b/arch/arm/boot/dts/microchip/tny_a9263.dts
@@ -120,7 +120,7 @@ data@7ca0000 {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
status = "okay";
};
};
diff --git a/arch/arm/boot/dts/microchip/usb_a9260_common.dtsi b/arch/arm/boot/dts/microchip/usb_a9260_common.dtsi
index da32c5fdcc47..80f7262ad22a 100644
--- a/arch/arm/boot/dts/microchip/usb_a9260_common.dtsi
+++ b/arch/arm/boot/dts/microchip/usb_a9260_common.dtsi
@@ -146,7 +146,7 @@ button-user-pb {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
status = "okay";
};
};
diff --git a/arch/arm/boot/dts/microchip/usb_a9263.dts b/arch/arm/boot/dts/microchip/usb_a9263.dts
index 8e1a3fb61087..2019f0b8c44d 100644
--- a/arch/arm/boot/dts/microchip/usb_a9263.dts
+++ b/arch/arm/boot/dts/microchip/usb_a9263.dts
@@ -165,7 +165,7 @@ button-user-pb {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
status = "okay";
};
};
diff --git a/arch/arm/boot/dts/microchip/usb_a9g20_lpw.dts b/arch/arm/boot/dts/microchip/usb_a9g20_lpw.dts
index 2eda00477bc5..1f1719d5029d 100644
--- a/arch/arm/boot/dts/microchip/usb_a9g20_lpw.dts
+++ b/arch/arm/boot/dts/microchip/usb_a9g20_lpw.dts
@@ -29,7 +29,7 @@ mmc@0 {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
rtc@56 {
compatible = "microcrystal,rv3029";
reg = <0x56>;
--
2.47.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 4/7] ARM: dts: samsung: use proper node names for GPIO based I2C busses
2025-05-19 12:15 [PATCH 0/7] archs: use proper node names for GPIO based I2C busses Wolfram Sang
` (2 preceding siblings ...)
2025-05-19 12:15 ` [PATCH 3/7] ARM: dts: microchip: " Wolfram Sang
@ 2025-05-19 12:15 ` Wolfram Sang
2025-05-19 12:15 ` [PATCH 5/7] ARM: dts: stm32: " Wolfram Sang
` (4 subsequent siblings)
8 siblings, 0 replies; 25+ messages in thread
From: Wolfram Sang @ 2025-05-19 12:15 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Wolfram Sang, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc
There shall not be a '-' before the number.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm/boot/dts/samsung/exynos3250-monk.dts | 2 +-
arch/arm/boot/dts/samsung/exynos3250-rinato.dts | 2 +-
arch/arm/boot/dts/samsung/exynos4210-i9100.dts | 6 +++---
arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 10 +++++-----
.../boot/dts/samsung/exynos4412-galaxy-s3.dtsi | 4 ++--
arch/arm/boot/dts/samsung/exynos4412-midas.dtsi | 6 +++---
arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi | 8 ++++----
arch/arm/boot/dts/samsung/s5pv210-aries.dtsi | 16 ++++++++--------
arch/arm/boot/dts/samsung/s5pv210-galaxys.dts | 2 +-
9 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos3250-monk.dts b/arch/arm/boot/dts/samsung/exynos3250-monk.dts
index 2de877d4ccc5..2a95ebad94ba 100644
--- a/arch/arm/boot/dts/samsung/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/samsung/exynos3250-monk.dts
@@ -56,7 +56,7 @@ vemmc_reg: voltage-regulator-0 {
enable-active-high;
};
- i2c_max77836: i2c-gpio-0 {
+ i2c_max77836: i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&gpd0 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpd0 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
diff --git a/arch/arm/boot/dts/samsung/exynos3250-rinato.dts b/arch/arm/boot/dts/samsung/exynos3250-rinato.dts
index 88fb3e68ff02..f34b593ee933 100644
--- a/arch/arm/boot/dts/samsung/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/samsung/exynos3250-rinato.dts
@@ -58,7 +58,7 @@ wlan_pwrseq: mshc1-pwrseq {
reset-gpios = <&gpe0 4 GPIO_ACTIVE_LOW>;
};
- i2c_max77836: i2c-gpio-0 {
+ i2c_max77836: i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&gpd0 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpd0 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
diff --git a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
index 0d8495792a70..6d9afc297e7a 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
@@ -130,7 +130,7 @@ wlan_pwrseq: sdhci3-pwrseq {
reset-gpios = <&gpl1 2 GPIO_ACTIVE_LOW>;
};
- i2c_max17042_fuel: i2c-gpio-0 {
+ i2c_max17042_fuel: i2c-gpio0 {
compatible = "i2c-gpio";
#address-cells = <1>;
#size-cells = <0>;
@@ -154,7 +154,7 @@ battery@36 {
};
};
- i2c_s5k5baf: i2c-gpio-1 {
+ i2c_s5k5baf: i2c-gpio1 {
compatible = "i2c-gpio";
#address-cells = <1>;
#size-cells = <0>;
@@ -184,7 +184,7 @@ s5k5bafx_ep: endpoint {
};
};
- i2c-gpio-2 {
+ i2c-gpio2 {
compatible = "i2c-gpio";
#address-cells = <1>;
#size-cells = <0>;
diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi
index 70e3091062f9..31f73fb9dbdc 100644
--- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi
@@ -123,7 +123,7 @@ led-touchkeys {
color = <LED_COLOR_ID_WHITE>;
};
- i2c_max77693: i2c-gpio-1 {
+ i2c_max77693: i2c-gpio1 {
compatible = "i2c-gpio";
sda-gpios = <&gpm2 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpm2 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -169,7 +169,7 @@ charger {
};
};
- i2c_max77693_fuel: i2c-gpio-2 {
+ i2c_max77693_fuel: i2c-gpio2 {
compatible = "i2c-gpio";
sda-gpios = <&gpy0 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpy0 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -190,7 +190,7 @@ fuel-gauge@36 {
};
};
- i2c_magnetometer: i2c-gpio-3 {
+ i2c_magnetometer: i2c-gpio3 {
compatible = "i2c-gpio";
sda-gpios = <&gpy2 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpy2 5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -208,7 +208,7 @@ magnetometer@2e {
};
};
- i2c_lightsensor: i2c-gpio-4 {
+ i2c_lightsensor: i2c-gpio4 {
compatible = "i2c-gpio";
sda-gpios = <&gpl0 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpl0 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -220,7 +220,7 @@ i2c_lightsensor: i2c-gpio-4 {
/* WiFi model uses CM3323, 3G/LTE use CM36653 */
};
- i2c_bl: i2c-gpio-5 {
+ i2c_bl: i2c-gpio5 {
compatible = "i2c-gpio";
sda-gpios = <&gpm4 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpm4 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
diff --git a/arch/arm/boot/dts/samsung/exynos4412-galaxy-s3.dtsi b/arch/arm/boot/dts/samsung/exynos4412-galaxy-s3.dtsi
index 54e1a57ae886..29eecaad067a 100644
--- a/arch/arm/boot/dts/samsung/exynos4412-galaxy-s3.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4412-galaxy-s3.dtsi
@@ -53,7 +53,7 @@ ps_als_reg: voltage-regulator-11 {
enable-active-high;
};
- i2c_ak8975: i2c-gpio-0 {
+ i2c_ak8975: i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&gpy2 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpy2 5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -68,7 +68,7 @@ magnetometer@c {
};
};
- i2c_cm36651: i2c-gpio-2 {
+ i2c_cm36651: i2c-gpio2 {
compatible = "i2c-gpio";
sda-gpios = <&gpf0 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpf0 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
diff --git a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
index 3d5aace668dc..5d1703a67b5f 100644
--- a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
@@ -166,7 +166,7 @@ key-ok {
};
};
- i2c_max77693: i2c-gpio-1 {
+ i2c_max77693: i2c-gpio1 {
compatible = "i2c-gpio";
sda-gpios = <&gpm2 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpm2 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -246,7 +246,7 @@ charger {
};
};
- i2c_max77693_fuel: i2c-gpio-3 {
+ i2c_max77693_fuel: i2c-gpio3 {
compatible = "i2c-gpio";
sda-gpios = <&gpf1 5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpf1 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -267,7 +267,7 @@ fuel-gauge@36 {
};
};
- i2c-gpio-4 {
+ i2c-gpio4 {
compatible = "i2c-gpio";
sda-gpios = <&gpl0 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpl0 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
diff --git a/arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi b/arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi
index 28a605802733..822d4bf2dfab 100644
--- a/arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi
@@ -140,7 +140,7 @@ battery_cell: battery-cell {
constant-charge-voltage-max-microvolt = <4200000>;
};
- i2c-gpio-1 {
+ i2c-gpio1 {
compatible = "i2c-gpio";
sda-gpios = <&gpy2 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpy2 5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -158,7 +158,7 @@ magnetometer@c {
};
};
- i2c-gpio-2 {
+ i2c-gpio2 {
compatible = "i2c-gpio";
sda-gpios = <&gpy0 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpy0 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -179,7 +179,7 @@ fuel-gauge@36 {
};
};
- i2c-gpio-3 {
+ i2c-gpio3 {
compatible = "i2c-gpio";
sda-gpios = <&gpm4 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpm4 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -207,7 +207,7 @@ adc {
};
};
- i2c-gpio-4 {
+ i2c-gpio4 {
compatible = "i2c-gpio";
sda-gpios = <&gpm2 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpm2 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
diff --git a/arch/arm/boot/dts/samsung/s5pv210-aries.dtsi b/arch/arm/boot/dts/samsung/s5pv210-aries.dtsi
index 153514e80c9a..f93fe4e60c90 100644
--- a/arch/arm/boot/dts/samsung/s5pv210-aries.dtsi
+++ b/arch/arm/boot/dts/samsung/s5pv210-aries.dtsi
@@ -102,7 +102,7 @@ wifi_pwrseq: wifi-pwrseq {
power-off-delay-us = <500>;
};
- i2c_sound: i2c-gpio-0 {
+ i2c_sound: i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&mp05 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&mp05 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -150,7 +150,7 @@ wm8994: audio-codec@1a {
};
};
- i2c_accel: i2c-gpio-1 {
+ i2c_accel: i2c-gpio1 {
compatible = "i2c-gpio";
sda-gpios = <&gpj3 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpj3 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -170,7 +170,7 @@ accelerometer@38 {
};
};
- i2c_pmic: i2c-gpio-2 {
+ i2c_pmic: i2c-gpio2 {
compatible = "i2c-gpio";
sda-gpios = <&gpj4 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpj4 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -420,7 +420,7 @@ safe2_sreg: ESAFEOUT2 {
};
};
- i2c_musb: i2c-gpio-3 {
+ i2c_musb: i2c-gpio3 {
compatible = "i2c-gpio";
sda-gpios = <&gpj3 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpj3 5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -442,7 +442,7 @@ fsa9480: musb@25 {
};
};
- i2c_fuel: i2c-gpio-4 {
+ i2c_fuel: i2c-gpio4 {
compatible = "i2c-gpio";
sda-gpios = <&mp05 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&mp05 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -459,7 +459,7 @@ fg: fuelgauge@36 {
};
};
- i2c_touchkey: i2c-gpio-5 {
+ i2c_touchkey: i2c-gpio5 {
compatible = "i2c-gpio";
sda-gpios = <&gpj3 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpj3 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -485,7 +485,7 @@ touchkey@20 {
};
};
- i2c_prox: i2c-gpio-6 {
+ i2c_prox: i2c-gpio6 {
compatible = "i2c-gpio";
sda-gpios = <&gpg2 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpg0 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -513,7 +513,7 @@ light-sensor@44 {
};
};
- i2c_magnetometer: i2c-gpio-7 {
+ i2c_magnetometer: i2c-gpio7 {
compatible = "i2c-gpio";
sda-gpios = <&gpj0 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpj0 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
diff --git a/arch/arm/boot/dts/samsung/s5pv210-galaxys.dts b/arch/arm/boot/dts/samsung/s5pv210-galaxys.dts
index 879294412381..cde026524891 100644
--- a/arch/arm/boot/dts/samsung/s5pv210-galaxys.dts
+++ b/arch/arm/boot/dts/samsung/s5pv210-galaxys.dts
@@ -51,7 +51,7 @@ key-home {
};
};
- i2c_fmradio: i2c-gpio-8 {
+ i2c_fmradio: i2c-gpio8 {
compatible = "i2c-gpio";
sda-gpios = <&gpd1 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpd1 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
--
2.47.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 5/7] ARM: dts: stm32: use proper node names for GPIO based I2C busses
2025-05-19 12:15 [PATCH 0/7] archs: use proper node names for GPIO based I2C busses Wolfram Sang
` (3 preceding siblings ...)
2025-05-19 12:15 ` [PATCH 4/7] ARM: dts: samsung: " Wolfram Sang
@ 2025-05-19 12:15 ` Wolfram Sang
2025-05-19 12:15 ` [PATCH 6/7] LoongArch: dts: " Wolfram Sang
` (3 subsequent siblings)
8 siblings, 0 replies; 25+ messages in thread
From: Wolfram Sang @ 2025-05-19 12:15 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Wolfram Sang, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-kernel, devicetree
There shall not be a '-' before the number.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
.../boot/dts/st/ste-ux500-samsung-codina-tmo.dts | 8 ++++----
.../arm/boot/dts/st/ste-ux500-samsung-codina.dts | 8 ++++----
.../arm/boot/dts/st/ste-ux500-samsung-gavini.dts | 12 ++++++------
.../arm/boot/dts/st/ste-ux500-samsung-golden.dts | 8 ++++----
.../arm/boot/dts/st/ste-ux500-samsung-janice.dts | 16 ++++++++--------
arch/arm/boot/dts/st/ste-ux500-samsung-kyle.dts | 8 ++++----
.../arm/boot/dts/st/ste-ux500-samsung-skomer.dts | 8 ++++----
7 files changed, 34 insertions(+), 34 deletions(-)
diff --git a/arch/arm/boot/dts/st/ste-ux500-samsung-codina-tmo.dts b/arch/arm/boot/dts/st/ste-ux500-samsung-codina-tmo.dts
index 404d4ea9347b..7e6be26549ef 100644
--- a/arch/arm/boot/dts/st/ste-ux500-samsung-codina-tmo.dts
+++ b/arch/arm/boot/dts/st/ste-ux500-samsung-codina-tmo.dts
@@ -215,7 +215,7 @@ led {
};
/* Bit-banged I2C on GPIO143 and GPIO144 also called "SUBPMU I2C" */
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&gpio4 16 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio4 15 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -228,7 +228,7 @@ i2c-gpio-0 {
};
/* Bit-banged I2C on GPIO151 and GPIO152 also called "COMP I2C" */
- i2c-gpio-1 {
+ i2c-gpio1 {
compatible = "i2c-gpio";
sda-gpios = <&gpio4 24 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio4 23 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -690,7 +690,7 @@ codina_cfg1 {
};
};
/* GPIO-based I2C bus for subpmu */
- i2c-gpio-0 {
+ i2c-gpio0 {
i2c_gpio_0_default: i2c_gpio_0 {
codina_cfg1 {
pins = "GPIO143_D12", "GPIO144_B13";
@@ -699,7 +699,7 @@ codina_cfg1 {
};
};
/* GPIO-based I2C bus for the NFC */
- i2c-gpio-1 {
+ i2c-gpio1 {
i2c_gpio_1_default: i2c_gpio_1 {
codina_cfg1 {
pins = "GPIO151_D17", "GPIO152_D16";
diff --git a/arch/arm/boot/dts/st/ste-ux500-samsung-codina.dts b/arch/arm/boot/dts/st/ste-ux500-samsung-codina.dts
index 40b0d92dfb15..6706c31ff1a5 100644
--- a/arch/arm/boot/dts/st/ste-ux500-samsung-codina.dts
+++ b/arch/arm/boot/dts/st/ste-ux500-samsung-codina.dts
@@ -285,7 +285,7 @@ led {
};
/* Bit-banged I2C on GPIO143 and GPIO144 also called "SUBPMU I2C" */
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&gpio4 16 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio4 15 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -306,7 +306,7 @@ magnetometer@c {
};
/* Bit-banged I2C on GPIO151 and GPIO152 also called "NFC I2C" */
- i2c-gpio-1 {
+ i2c-gpio1 {
compatible = "i2c-gpio";
sda-gpios = <&gpio4 24 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio4 23 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -816,7 +816,7 @@ codina_cfg1 {
};
};
/* GPIO-based I2C bus for subpmu */
- i2c-gpio-0 {
+ i2c-gpio0 {
i2c_gpio_0_default: i2c_gpio_0 {
codina_cfg1 {
pins = "GPIO143_D12", "GPIO144_B13";
@@ -825,7 +825,7 @@ codina_cfg1 {
};
};
/* GPIO-based I2C bus for the NFC */
- i2c-gpio-1 {
+ i2c-gpio1 {
i2c_gpio_1_default: i2c_gpio_1 {
codina_cfg1 {
pins = "GPIO151_D17", "GPIO152_D16";
diff --git a/arch/arm/boot/dts/st/ste-ux500-samsung-gavini.dts b/arch/arm/boot/dts/st/ste-ux500-samsung-gavini.dts
index ad9a20ccaaeb..f9423f168f62 100644
--- a/arch/arm/boot/dts/st/ste-ux500-samsung-gavini.dts
+++ b/arch/arm/boot/dts/st/ste-ux500-samsung-gavini.dts
@@ -249,7 +249,7 @@ ktd259: backlight {
};
/* Bit-banged I2C on GPIO143 and GPIO144 also called "SUBPMU I2C" */
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&gpio4 16 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio4 15 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -321,7 +321,7 @@ panel_in: endpoint {
};
/* Bit-banged I2C on GPIO201 and GPIO202 also called "MOT_I2C" */
- i2c-gpio-2 {
+ i2c-gpio2 {
compatible = "i2c-gpio";
sda-gpios = <&gpio6 10 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio6 9 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -333,7 +333,7 @@ i2c-gpio-2 {
};
/* Bit-banged I2C on GPIO196 and GPIO197 also called "MPR_I2C" */
- i2c-gpio-3 {
+ i2c-gpio3 {
compatible = "i2c-gpio";
sda-gpios = <&gpio6 5 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio6 4 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -796,7 +796,7 @@ gavini_cfg1 {
};
};
/* GPIO-based I2C bus for magnetometer and NCP6914 */
- i2c-gpio-0 {
+ i2c-gpio0 {
i2c_gpio_0_default: i2c_gpio_0 {
gavini_cfg1 {
pins = "GPIO143_D12", "GPIO144_B13";
@@ -805,7 +805,7 @@ gavini_cfg1 {
};
};
/* GPIO-based I2C bus for the Immersion ISA1200 */
- i2c-gpio-2 {
+ i2c-gpio2 {
i2c_gpio_2_default: i2c_gpio_2 {
gavini_cfg1 {
pins = "GPIO201_AF24", "GPIO202_AF25";
@@ -814,7 +814,7 @@ gavini_cfg1 {
};
};
/* GPIO-based I2C bus for the TI DPP2601 */
- i2c-gpio-3 {
+ i2c-gpio3 {
i2c_gpio_3_default: i2c_gpio_3 {
gavini_cfg1 {
pins = "GPIO196_AG26", "GPIO197_AH24";
diff --git a/arch/arm/boot/dts/st/ste-ux500-samsung-golden.dts b/arch/arm/boot/dts/st/ste-ux500-samsung-golden.dts
index f736888474e7..fad867964a50 100644
--- a/arch/arm/boot/dts/st/ste-ux500-samsung-golden.dts
+++ b/arch/arm/boot/dts/st/ste-ux500-samsung-golden.dts
@@ -55,7 +55,7 @@ bat_therm: thermistor {
#thermal-sensor-cells = <0>;
};
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&gpio2 14 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio2 13 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -81,7 +81,7 @@ touchkey@20 {
};
};
- i2c-gpio-1 {
+ i2c-gpio1 {
compatible = "i2c-gpio";
sda-gpios = <&gpio4 24 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio4 23 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -553,7 +553,7 @@ golden_cfg1 {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
i2c_gpio_0_default: i2c_gpio_0 {
golden_cfg1 {
pins = "GPIO77", /* TOUCHKEY_SCL */
@@ -572,7 +572,7 @@ golden_cfg1 {
};
};
- i2c-gpio-1 {
+ i2c-gpio1 {
i2c_gpio_1_default: i2c_gpio_1 {
golden_cfg1 {
pins = "GPIO151", /* COMP_SCL */
diff --git a/arch/arm/boot/dts/st/ste-ux500-samsung-janice.dts b/arch/arm/boot/dts/st/ste-ux500-samsung-janice.dts
index 229f7c32103c..580a5da69187 100644
--- a/arch/arm/boot/dts/st/ste-ux500-samsung-janice.dts
+++ b/arch/arm/boot/dts/st/ste-ux500-samsung-janice.dts
@@ -239,7 +239,7 @@ led {
};
/* Bit-banged I2C on GPIO143 and GPIO144 also called "SUBPMU I2C" */
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&gpio4 16 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio4 15 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -324,7 +324,7 @@ gp2a_shunt: current-sense-shunt {
};
/* Bit-banged I2C on GPIO196 and GPIO197 also called "TOUCHKEY_I2C" */
- i2c-gpio-1 {
+ i2c-gpio1 {
compatible = "i2c-gpio";
sda-gpios = <&gpio6 5 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio6 4 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -352,7 +352,7 @@ touchkey@20 {
};
/* Bit-banged I2C on GPIO201 and GPIO202 also called "MOT_I2C" */
- i2c-gpio-2 {
+ i2c-gpio2 {
compatible = "i2c-gpio";
sda-gpios = <&gpio6 10 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio6 9 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -364,7 +364,7 @@ i2c-gpio-2 {
};
/* Bit-banged I2C on GPIO151 and GPIO152 also called "NFC_I2C" */
- i2c-gpio-3 {
+ i2c-gpio3 {
compatible = "i2c-gpio";
sda-gpios = <&gpio4 24 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio4 23 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -875,7 +875,7 @@ janice_cfg1 {
};
};
/* GPIO-based I2C bus for magnetometer and NCP6914 */
- i2c-gpio-0 {
+ i2c-gpio0 {
i2c_gpio_0_default: i2c_gpio_0 {
janice_cfg1 {
pins = "GPIO143_D12", "GPIO144_B13";
@@ -884,7 +884,7 @@ janice_cfg1 {
};
};
/* GPIO-based I2C bus for the Cypress touchkeys */
- i2c-gpio-1 {
+ i2c-gpio1 {
i2c_gpio_1_default: i2c_gpio_1 {
janice_cfg1 {
pins = "GPIO196_AG26", "GPIO197_AH24";
@@ -893,7 +893,7 @@ janice_cfg1 {
};
};
/* GPIO-based I2C bus for the Immersion ISA1200 */
- i2c-gpio-2 {
+ i2c-gpio2 {
i2c_gpio_2_default: i2c_gpio_2 {
janice_cfg1 {
pins = "GPIO201_AF24", "GPIO202_AF25";
@@ -902,7 +902,7 @@ janice_cfg1 {
};
};
/* GPIO-based I2C bus for the NFC */
- i2c-gpio-3 {
+ i2c-gpio3 {
i2c_gpio_3_default: i2c_gpio_3 {
janice_cfg1 {
pins = "GPIO151_D17", "GPIO152_D16";
diff --git a/arch/arm/boot/dts/st/ste-ux500-samsung-kyle.dts b/arch/arm/boot/dts/st/ste-ux500-samsung-kyle.dts
index cdb147dcc1db..bd8eb2b3bacd 100644
--- a/arch/arm/boot/dts/st/ste-ux500-samsung-kyle.dts
+++ b/arch/arm/boot/dts/st/ste-ux500-samsung-kyle.dts
@@ -196,7 +196,7 @@ led {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&gpio4 16 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio4 15 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -207,7 +207,7 @@ i2c-gpio-0 {
/* TODO: this should be used by the NCP6914 Camera power management unit */
};
- i2c-gpio-1 {
+ i2c-gpio1 {
compatible = "i2c-gpio";
sda-gpios = <&gpio4 24 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio4 23 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -629,7 +629,7 @@ kyle_cfg1 {
};
};
/* GPIO-based I2C bus for NCP6914 */
- i2c-gpio-0 {
+ i2c-gpio0 {
i2c_gpio_0_default: i2c_gpio_0 {
kyle_cfg1 {
pins = "GPIO143_D12", "GPIO144_B13";
@@ -638,7 +638,7 @@ kyle_cfg1 {
};
};
/* GPIO-based I2C bus for ALPS HSCD compass */
- i2c-gpio-1 {
+ i2c-gpio1 {
i2c_gpio_1_default: i2c_gpio_1 {
kyle_cfg1 {
pins = "GPIO151_B17", "GPIO152_D16";
diff --git a/arch/arm/boot/dts/st/ste-ux500-samsung-skomer.dts b/arch/arm/boot/dts/st/ste-ux500-samsung-skomer.dts
index 064d6fee8821..a8c854a82d4e 100644
--- a/arch/arm/boot/dts/st/ste-ux500-samsung-skomer.dts
+++ b/arch/arm/boot/dts/st/ste-ux500-samsung-skomer.dts
@@ -175,7 +175,7 @@ led {
};
};
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&gpio4 16 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio4 15 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -186,7 +186,7 @@ i2c-gpio-0 {
/* TODO: this should be used by the NCP6914 Camera power management unit */
};
- i2c-gpio-1 {
+ i2c-gpio1 {
compatible = "i2c-gpio";
sda-gpios = <&gpio4 24 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpio4 23 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
@@ -616,7 +616,7 @@ skomer_cfg1 {
};
};
/* GPIO-based I2C bus for NCP6914 */
- i2c-gpio-0 {
+ i2c-gpio0 {
i2c_gpio_0_default: i2c_gpio_0 {
skomer_cfg1 {
pins = "GPIO143_D12", "GPIO144_B13";
@@ -625,7 +625,7 @@ skomer_cfg1 {
};
};
/* GPIO-based I2C bus for ALPS HSCD compass */
- i2c-gpio-1 {
+ i2c-gpio1 {
i2c_gpio_1_default: i2c_gpio_1 {
skomer_cfg1 {
pins = "GPIO151_B17", "GPIO152_D16";
--
2.47.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 6/7] LoongArch: dts: use proper node names for GPIO based I2C busses
2025-05-19 12:15 [PATCH 0/7] archs: use proper node names for GPIO based I2C busses Wolfram Sang
` (4 preceding siblings ...)
2025-05-19 12:15 ` [PATCH 5/7] ARM: dts: stm32: " Wolfram Sang
@ 2025-05-19 12:15 ` Wolfram Sang
2025-05-19 12:15 ` [PATCH 7/7] riscv: dts: allwinner: " Wolfram Sang
` (2 subsequent siblings)
8 siblings, 0 replies; 25+ messages in thread
From: Wolfram Sang @ 2025-05-19 12:15 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Wolfram Sang, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Huacai Chen, WANG Xuerui, devicetree, loongarch
There shall not be a '-' before the number.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/loongarch/boot/dts/loongson-2k1000.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/loongarch/boot/dts/loongson-2k1000.dtsi b/arch/loongarch/boot/dts/loongson-2k1000.dtsi
index 1da3beb00f0e..ddf63801eef0 100644
--- a/arch/loongarch/boot/dts/loongson-2k1000.dtsi
+++ b/arch/loongarch/boot/dts/loongson-2k1000.dtsi
@@ -46,7 +46,7 @@ cpuintc: interrupt-controller {
};
/* i2c of the dvi eeprom edid */
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
scl-gpios = <&gpio0 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
sda-gpios = <&gpio0 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -57,7 +57,7 @@ i2c-gpio-0 {
};
/* i2c of the eeprom edid */
- i2c-gpio-1 {
+ i2c-gpio1 {
compatible = "i2c-gpio";
scl-gpios = <&gpio0 33 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
sda-gpios = <&gpio0 32 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
--
2.47.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 7/7] riscv: dts: allwinner: use proper node names for GPIO based I2C busses
2025-05-19 12:15 [PATCH 0/7] archs: use proper node names for GPIO based I2C busses Wolfram Sang
` (5 preceding siblings ...)
2025-05-19 12:15 ` [PATCH 6/7] LoongArch: dts: " Wolfram Sang
@ 2025-05-19 12:15 ` Wolfram Sang
2025-05-19 13:10 ` Chen-Yu Tsai
2025-05-19 12:54 ` [PATCH 0/7] archs: " Geert Uytterhoeven
2025-05-19 18:59 ` Wolfram Sang
8 siblings, 1 reply; 25+ messages in thread
From: Wolfram Sang @ 2025-05-19 12:15 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Wolfram Sang, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti, devicetree,
linux-arm-kernel, linux-sunxi, linux-riscv
There shall not be a '-' before the number.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/riscv/boot/dts/allwinner/sun20i-d1-devterm-v3.14.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/boot/dts/allwinner/sun20i-d1-devterm-v3.14.dts b/arch/riscv/boot/dts/allwinner/sun20i-d1-devterm-v3.14.dts
index bc5c84f22762..6d84efaf4b84 100644
--- a/arch/riscv/boot/dts/allwinner/sun20i-d1-devterm-v3.14.dts
+++ b/arch/riscv/boot/dts/allwinner/sun20i-d1-devterm-v3.14.dts
@@ -17,7 +17,7 @@ fan {
#cooling-cells = <2>;
};
- i2c-gpio-0 {
+ i2c-gpio0 {
compatible = "i2c-gpio";
sda-gpios = <&pio 3 14 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; /* PD14/GPIO44 */
scl-gpios = <&pio 3 15 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; /* PD15/GPIO45 */
--
2.47.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 7/7] riscv: dts: allwinner: use proper node names for GPIO based I2C busses
2025-05-19 12:15 ` [PATCH 7/7] riscv: dts: allwinner: " Wolfram Sang
@ 2025-05-19 13:10 ` Chen-Yu Tsai
0 siblings, 0 replies; 25+ messages in thread
From: Chen-Yu Tsai @ 2025-05-19 13:10 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-renesas-soc, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jernej Skrabec, Samuel Holland, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Alexandre Ghiti, devicetree, linux-arm-kernel,
linux-sunxi, linux-riscv
On Mon, May 19, 2025 at 8:15 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> There shall not be a '-' before the number.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
If you want the SoC maintainers to take it directly,
Acked-by: Chen-Yu Tsai <wens@csie.org>
Or I can take it after the upcoming merge window.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 0/7] archs: use proper node names for GPIO based I2C busses
2025-05-19 12:15 [PATCH 0/7] archs: use proper node names for GPIO based I2C busses Wolfram Sang
` (6 preceding siblings ...)
2025-05-19 12:15 ` [PATCH 7/7] riscv: dts: allwinner: " Wolfram Sang
@ 2025-05-19 12:54 ` Geert Uytterhoeven
2025-05-19 14:47 ` Wolfram Sang
2025-05-19 18:59 ` Wolfram Sang
8 siblings, 1 reply; 25+ messages in thread
From: Geert Uytterhoeven @ 2025-05-19 12:54 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-renesas-soc, Albert Ou, Alexandre Belloni, Alexandre Ghiti,
Alim Akhtar, AngeloGioacchino Del Regno, Chen-Yu Tsai,
Claudiu Beznea, Conor Dooley, devicetree, Huacai Chen,
Jernej Skrabec, Krzysztof Kozlowski, Linus Walleij,
linux-arm-kernel, linux-mediatek, linux-riscv, linux-samsung-soc,
linux-sunxi, loongarch, Matthias Brugger, Nicolas Ferre,
Palmer Dabbelt, Paul Walmsley, Rob Herring, Samuel Holland,
WANG Xuerui
Hi Wolfram,
On Mon, 19 May 2025 at 14:15, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> A lot of boards across various archs have a superfluous '-' in their
> node name for GPIO based I2C busses. 'dtbs_check' complains, so fix
> them.
>
> Based on linux-next as of 20250516. Build bots are happy. ARM patches
> depend on another cleanup series[1], the rest has no dependencies. I
> suggest that patches go via their subsystem trees.
>
> Tested on Calao USB boards using AT91 chipsets and a Renesas Lager board
> using R-Car H2.
Thanks for your series!
> arm64: dts: exynos: use proper node names for GPIO based I2C busses
> arm64: dts: mediatek: use proper node names for GPIO based I2C busses
> ARM: dts: microchip: use proper node names for GPIO based I2C busses
> ARM: dts: samsung: use proper node names for GPIO based I2C busses
> ARM: dts: stm32: use proper node names for GPIO based I2C busses
> LoongArch: dts: use proper node names for GPIO based I2C busses
> riscv: dts: allwinner: use proper node names for GPIO based I2C busses
Hmmm... which of these changes affect the R-Car board? ;-)
Am I missing something?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 0/7] archs: use proper node names for GPIO based I2C busses
2025-05-19 12:54 ` [PATCH 0/7] archs: " Geert Uytterhoeven
@ 2025-05-19 14:47 ` Wolfram Sang
0 siblings, 0 replies; 25+ messages in thread
From: Wolfram Sang @ 2025-05-19 14:47 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-renesas-soc, Albert Ou, Alexandre Belloni, Alexandre Ghiti,
Alim Akhtar, AngeloGioacchino Del Regno, Chen-Yu Tsai,
Claudiu Beznea, Conor Dooley, devicetree, Huacai Chen,
Jernej Skrabec, Krzysztof Kozlowski, Linus Walleij,
linux-arm-kernel, linux-mediatek, linux-riscv, linux-samsung-soc,
linux-sunxi, loongarch, Matthias Brugger, Nicolas Ferre,
Palmer Dabbelt, Paul Walmsley, Rob Herring, Samuel Holland,
WANG Xuerui
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
> Hmmm... which of these changes affect the R-Car board? ;-)
Right, in this series, none :)
> Am I missing something?
I tested another series on top of this series with Lager. After the
EmbeddedRecipes break, I forgot that only the next series affects Lager.
Sorry for the confusion!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 0/7] archs: use proper node names for GPIO based I2C busses
2025-05-19 12:15 [PATCH 0/7] archs: use proper node names for GPIO based I2C busses Wolfram Sang
` (7 preceding siblings ...)
2025-05-19 12:54 ` [PATCH 0/7] archs: " Geert Uytterhoeven
@ 2025-05-19 18:59 ` Wolfram Sang
8 siblings, 0 replies; 25+ messages in thread
From: Wolfram Sang @ 2025-05-19 18:59 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Albert Ou, Alexandre Belloni, Alexandre Ghiti, Alim Akhtar,
AngeloGioacchino Del Regno, Chen-Yu Tsai, Claudiu Beznea,
Conor Dooley, devicetree, Huacai Chen, Jernej Skrabec,
Krzysztof Kozlowski, Linus Walleij, linux-arm-kernel,
linux-mediatek, linux-riscv, linux-samsung-soc, linux-sunxi,
loongarch, Matthias Brugger, Nicolas Ferre, Palmer Dabbelt,
Paul Walmsley, Rob Herring, Samuel Holland, WANG Xuerui
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
On Mon, May 19, 2025 at 02:15:00PM +0200, Wolfram Sang wrote:
> A lot of boards across various archs have a superfluous '-' in their
> node name for GPIO based I2C busses. 'dtbs_check' complains, so fix
> them.
Please drop this series. We found out that upstream dt-schema is broken
instead. I sent a fix.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread