* [PATCH v1] arm64: dts: amlogic: Update USB hub power and reset properties
@ 2025-05-20 9:18 Anand Moon
2025-05-20 12:32 ` Neil Armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Anand Moon @ 2025-05-20 9:18 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Greg Kroah-Hartman,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Amlogic Meson SoC support,
open list:ARM/Amlogic Meson SoC support, open list
Cc: Anand Moon, Wayne Schroeder
Add missing reset-gpios property to the USB 2.0 hub node to
ensure proper reset handling. Also update the vdd-supply for
both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
for consistent power management.
Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index 3bca8023638d..ad959f8bc1ac 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
@@ -42,7 +42,8 @@ hub_2_0: hub@1 {
compatible = "usb5e3,610";
reg = <1>;
peer-hub = <&hub_3_0>;
- vdd-supply = <&usb_pwr_en>;
+ reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+ vdd-supply = <&hub_5v>;
};
/* 3.0 hub on port 4 */
@@ -51,7 +52,7 @@ hub_3_0: hub@2 {
reg = <2>;
peer-hub = <&hub_2_0>;
reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
- vdd-supply = <&vcc_5v>;
+ vdd-supply = <&hub_5v>;
};
};
base-commit: a5806cd506af5a7c19bcd596e4708b5c464bfd21
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] arm64: dts: amlogic: Update USB hub power and reset properties
2025-05-20 9:18 [PATCH v1] arm64: dts: amlogic: Update USB hub power and reset properties Anand Moon
@ 2025-05-20 12:32 ` Neil Armstrong
2025-05-20 14:27 ` Anand Moon
0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2025-05-20 12:32 UTC (permalink / raw)
To: Anand Moon, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Greg Kroah-Hartman,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Amlogic Meson SoC support,
open list:ARM/Amlogic Meson SoC support, open list
Cc: Wayne Schroeder
On 20/05/2025 11:18, Anand Moon wrote:
> Add missing reset-gpios property to the USB 2.0 hub node to
> ensure proper reset handling. Also update the vdd-supply for
> both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
> for consistent power management.
>
> Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> index 3bca8023638d..ad959f8bc1ac 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> @@ -42,7 +42,8 @@ hub_2_0: hub@1 {
> compatible = "usb5e3,610";
> reg = <1>;
> peer-hub = <&hub_3_0>;
> - vdd-supply = <&usb_pwr_en>;
> + reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
> + vdd-supply = <&hub_5v>;
> };
>
> /* 3.0 hub on port 4 */
> @@ -51,7 +52,7 @@ hub_3_0: hub@2 {
> reg = <2>;
> peer-hub = <&hub_2_0>;
> reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
> - vdd-supply = <&vcc_5v>;
> + vdd-supply = <&hub_5v>;
In this case, also remove the &usb2_phy1 phy-supply since now it's managed by the hub reset control.
Neil
> };
> };
>
>
> base-commit: a5806cd506af5a7c19bcd596e4708b5c464bfd21
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] arm64: dts: amlogic: Update USB hub power and reset properties
2025-05-20 12:32 ` Neil Armstrong
@ 2025-05-20 14:27 ` Anand Moon
0 siblings, 0 replies; 3+ messages in thread
From: Anand Moon @ 2025-05-20 14:27 UTC (permalink / raw)
To: Neil Armstrong
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Greg Kroah-Hartman,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Amlogic Meson SoC support,
open list:ARM/Amlogic Meson SoC support, open list,
Wayne Schroeder
Hi Neil,
On Tue, 20 May 2025 at 18:02, Neil Armstrong <neil.armstrong@linaro.org> wrote:
>
> On 20/05/2025 11:18, Anand Moon wrote:
> > Add missing reset-gpios property to the USB 2.0 hub node to
> > ensure proper reset handling. Also update the vdd-supply for
> > both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
> > for consistent power management.
> >
> > Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> > index 3bca8023638d..ad959f8bc1ac 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> > @@ -42,7 +42,8 @@ hub_2_0: hub@1 {
> > compatible = "usb5e3,610";
> > reg = <1>;
> > peer-hub = <&hub_3_0>;
> > - vdd-supply = <&usb_pwr_en>;
> > + reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
> > + vdd-supply = <&hub_5v>;
> > };
> >
> > /* 3.0 hub on port 4 */
> > @@ -51,7 +52,7 @@ hub_3_0: hub@2 {
> > reg = <2>;
> > peer-hub = <&hub_2_0>;
> > reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
> > - vdd-supply = <&vcc_5v>;
> > + vdd-supply = <&hub_5v>;
>
> In this case, also remove the &usb2_phy1 phy-supply since now it's managed by the hub reset control.
>
Ok I will update in the next version.
> Neil
>
Thank
-Anand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-20 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-20 9:18 [PATCH v1] arm64: dts: amlogic: Update USB hub power and reset properties Anand Moon
2025-05-20 12:32 ` Neil Armstrong
2025-05-20 14:27 ` Anand Moon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox