From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shradha Todi <shradha.t@samsung.com>
Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.or, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org, manivannan.sadhasivam@linaro.org,
lpieralisi@kernel.org, kw@linux.com, robh@kernel.org,
bhelgaas@google.com, jingoohan1@gmail.com, krzk+dt@kernel.org,
conor+dt@kernel.org, alim.akhtar@samsung.com, vkoul@kernel.org,
kishon@kernel.org, arnd@arndb.de, m.szyprowski@samsung.com,
jh80.chung@samsung.com,
Hrishikesh Dileep <hrishikesh.d@samsung.com>
Subject: Re: [PATCH 02/10] PCI: exynos: Remove unused MACROs in exynos PCI file
Date: Wed, 21 May 2025 11:41:24 +0200 [thread overview]
Message-ID: <20250521-succinct-roadrunner-from-avalon-f1fa4c@kuoka> (raw)
In-Reply-To: <20250518193152.63476-3-shradha.t@samsung.com>
On Mon, May 19, 2025 at 01:01:44AM GMT, Shradha Todi wrote:
> Some MACROs are defined in the exynos PCI file but are
> not used anywhere within the file. Remove such unused
> MACROs.
>
> Suggested-by: Hrishikesh Dileep <hrishikesh.d@samsung.com>
> Signed-off-by: Shradha Todi <shradha.t@samsung.com>
> ---
> drivers/pci/controller/dwc/pci-exynos.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
> index 1c70b036376d..990aaa16b132 100644
> --- a/drivers/pci/controller/dwc/pci-exynos.c
> +++ b/drivers/pci/controller/dwc/pci-exynos.c
> @@ -31,8 +31,6 @@
> #define EXYNOS_IRQ_INTB_ASSERT BIT(2)
> #define EXYNOS_IRQ_INTC_ASSERT BIT(4)
> #define EXYNOS_IRQ_INTD_ASSERT BIT(6)
> -#define EXYNOS_PCIE_IRQ_LEVEL 0x004
Fix order of patches. Why renaming something just to remove it? No
point.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-21 9:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250518193219epcas5p24b442233b3e2bc2a92f43b71a126062f@epcas5p2.samsung.com>
2025-05-18 19:31 ` [PATCH 00/10] Add PCIe support for Tesla FSD SoC Shradha Todi
[not found] ` <CGME20250518193221epcas5p3c648c773d901f18639dd32fa452fd688@epcas5p3.samsung.com>
2025-05-18 19:31 ` [PATCH 01/10] PCI: exynos: Change macro names to exynos specific Shradha Todi
[not found] ` <CGME20250518193230epcas5p3dfb178a6528556c55e9b694ca8f8ad6c@epcas5p3.samsung.com>
2025-05-18 19:31 ` [PATCH 02/10] PCI: exynos: Remove unused MACROs in exynos PCI file Shradha Todi
2025-05-21 9:41 ` Krzysztof Kozlowski [this message]
2025-05-27 10:42 ` Shradha Todi
[not found] ` <CGME20250518193235epcas5p4f0bcf581b583a3acf493a20191ad2b00@epcas5p4.samsung.com>
2025-05-18 19:31 ` [PATCH 03/10] PCI: exynos: Reorder MACROs to maintain consistency Shradha Todi
2025-05-21 9:45 ` Krzysztof Kozlowski
2025-05-27 10:42 ` Shradha Todi
[not found] ` <CGME20250518193239epcas5p4cb4112382560f38ad9708e000eb2335f@epcas5p4.samsung.com>
2025-05-18 19:31 ` [PATCH 04/10] PCI: exynos: Add platform device private data Shradha Todi
2025-05-21 9:44 ` Krzysztof Kozlowski
2025-05-27 10:43 ` Shradha Todi
2025-06-13 9:04 ` Manivannan Sadhasivam
[not found] ` <CGME20250518193244epcas5p3cacfbdc3b0e5c32f7a4dd97062a931a4@epcas5p3.samsung.com>
2025-05-18 19:31 ` [PATCH 05/10] PCI: exynos: Add structure to hold resource operations Shradha Todi
2025-05-21 9:42 ` Krzysztof Kozlowski
2025-05-27 10:44 ` Shradha Todi
[not found] ` <CGME20250518193248epcas5p2543146c715eb249ea6c2ce3c78d03b34@epcas5p2.samsung.com>
2025-05-18 19:31 ` [PATCH 06/10] dt-bindings: PCI: Add bindings support for Tesla FSD SoC Shradha Todi
2025-05-21 9:37 ` Krzysztof Kozlowski
2025-05-27 10:44 ` Shradha Todi
[not found] ` <CGME20250518193252epcas5p3e4d1d329f1e5616e842801ceb26728b6@epcas5p3.samsung.com>
2025-05-18 19:31 ` [PATCH 07/10] dt-bindings: phy: Add PHY bindings support for " Shradha Todi
2025-05-21 9:33 ` Krzysztof Kozlowski
2025-05-27 10:44 ` Shradha Todi
[not found] ` <CGME20250518193256epcas5p442e9549fd8fd810522f960df74c22e34@epcas5p4.samsung.com>
2025-05-18 19:31 ` [PATCH 08/10] phy: exynos: Add PCIe PHY " Shradha Todi
2025-05-21 9:40 ` Krzysztof Kozlowski
2025-05-27 10:45 ` Shradha Todi
2025-05-28 7:21 ` Krzysztof Kozlowski
[not found] ` <CGME20250518193300epcas5p17e954bb18de9169d65e00501b1dcd046@epcas5p1.samsung.com>
2025-05-18 19:31 ` [PATCH 09/10] PCI: exynos: Add support for Tesla " Shradha Todi
2025-05-19 10:26 ` Niklas Cassel
2025-05-21 9:48 ` Krzysztof Kozlowski
2025-05-27 10:45 ` Shradha Todi
2025-05-28 7:25 ` Krzysztof Kozlowski
2025-05-29 10:24 ` Shradha Todi
[not found] ` <CGME20250518193305epcas5p263b59196e93ef504eab8537f82c37342@epcas5p2.samsung.com>
2025-05-18 19:31 ` [PATCH 10/10] misc: pci_endpoint_test: Add driver data for FSD PCIe controllers Shradha Todi
2025-05-19 9:59 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250521-succinct-roadrunner-from-avalon-f1fa4c@kuoka \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hrishikesh.d@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.or \
--cc=lpieralisi@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=shradha.t@samsung.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).