[PATCH 1/2] arm64: dts: qcom: sm8250: enable camcc clock controller by default

[PATCH 1/2] arm64: dts: qcom: sm8250: enable camcc clock controller by default

[Vladimir Zapolskiy]

Enable camera clock controller on all Qualcomm SM8250 derived boards
by default due to the established agreement of having all clock
controllers enabled.

Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index f0d18fd37aaf..a6f9b78c5226 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -4653,7 +4653,6 @@ camcc: clock-controller@ad00000 {
 			clock-names = "iface", "bi_tcxo", "bi_tcxo_ao", "sleep_clk";
 			power-domains = <&rpmhpd RPMHPD_MMCX>;
 			required-opps = <&rpmhpd_opp_low_svs>;
-			status = "disabled";
 			#clock-cells = <1>;
 			#reset-cells = <1>;
 			#power-domain-cells = <1>;
-- 
2.45.2

[PATCH 2/2] arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: remove camcc status property

[Vladimir Zapolskiy]

After a change enabling camera clock controller for all Qualcomm SM8250
boards the explicit control of the clock controller status can be removed
from the RB5 vision mezzanine dts overlay file.

Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
 arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dtso | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dtso b/arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dtso
index 5fe331923dd3..771baf7e09e6 100644
--- a/arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dtso
+++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dtso
@@ -9,10 +9,6 @@
 #include <dt-bindings/clock/qcom,camcc-sm8250.h>
 #include <dt-bindings/gpio/gpio.h>
 
-&camcc {
-	status = "okay";
-};
-
 &camss {
 	vdda-phy-supply = <&vreg_l5a_0p88>;
 	vdda-pll-supply = <&vreg_l9a_1p2>;
-- 
2.45.2

Re: [PATCH 1/2] arm64: dts: qcom: sm8250: enable camcc clock controller by default

[Konrad Dybcio]

On 5/23/25 11:23 AM, Vladimir Zapolskiy wrote:
> Enable camera clock controller on all Qualcomm SM8250 derived boards
> by default due to the established agreement of having all clock
> controllers enabled.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---

No reason for it to be 2 patches but redoing it would be clearly
wasted time

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH 2/2] arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: remove camcc status property

[Konrad Dybcio]

On 5/23/25 11:23 AM, Vladimir Zapolskiy wrote:
> After a change enabling camera clock controller for all Qualcomm SM8250
> boards the explicit control of the clock controller status can be removed
> from the RB5 vision mezzanine dts overlay file.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH 1/2] arm64: dts: qcom: sm8250: enable camcc clock controller by default

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 12:23:12PM +0300, Vladimir Zapolskiy wrote:
> Enable camera clock controller on all Qualcomm SM8250 derived boards
> by default due to the established agreement of having all clock
> controllers enabled.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH 2/2] arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: remove camcc status property

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 12:23:13PM +0300, Vladimir Zapolskiy wrote:
> After a change enabling camera clock controller for all Qualcomm SM8250
> boards the explicit control of the clock controller status can be removed
> from the RB5 vision mezzanine dts overlay file.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dtso | 4 ----
>  1 file changed, 4 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH 1/2] arm64: dts: qcom: sm8250: enable camcc clock controller by default

[Vladimir Zapolskiy]

Hi Konrad,

On 5/23/25 13:42, Konrad Dybcio wrote:
> On 5/23/25 11:23 AM, Vladimir Zapolskiy wrote:
>> Enable camera clock controller on all Qualcomm SM8250 derived boards
>> by default due to the established agreement of having all clock
>> controllers enabled.
>>
>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>> ---
> 
> No reason for it to be 2 patches but redoing it would be clearly
> wasted time
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 

thank you for review, the reason behind two patches like here and in
some other series from me is a care about potential clean change reverts.

If something goes wrong for whatever reason (even in the untouched clock
driver), and even if there are more cc device status okay/disabled series
for any other boards, the split to a platform and a board changes allows
to revert the changes independently at any point of time in future.

--
Best wishes,
Vladimir

Re: (subset) [PATCH 1/2] arm64: dts: qcom: sm8250: enable camcc clock controller by default

[Bjorn Andersson]

On Fri, 23 May 2025 12:23:12 +0300, Vladimir Zapolskiy wrote:
> Enable camera clock controller on all Qualcomm SM8250 derived boards
> by default due to the established agreement of having all clock
> controllers enabled.
> 
> 

Applied, thanks!

[1/2] arm64: dts: qcom: sm8250: enable camcc clock controller by default
      commit: 40afa658914eaf7042ce275269336d9d698a739b
[2/2] arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: remove camcc status property
      commit: d5a6183a918cb1f2e442ab9fe68e9fbe0bd2ba3a

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>