Re: [PATCH 1/2] arm: dts: omap: Add support for BeagleBone Green Eco board

[Andreas Kemnade <andreas@kemnade.info>]

Am Fri, 23 May 2025 17:57:42 +0200
schrieb Kory Maincent <kory.maincent@bootlin.com>:

> SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
> (BBG). It has minor differences from the BBG, such as a different PMIC,
> a different Ethernet PHY, and a larger eMMC.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> The pmic binding is currently only in regulator tree. I don't know if it
> should be merged in omap tree or in regulator tree due to that binding
> dependency.

Well, the pull request for omap stuff to soc is already sent, so this
will go into 6.17 probably while the regulator stuff seems to be
scheduled for 6.16. So this issue will solve itself.

> ---
>  arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
>  arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 170 +++++++++++++++++++++
>  2 files changed, 171 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile
> index 95c68135dd0c..1aef60eef671 100644
> --- a/arch/arm/boot/dts/ti/omap/Makefile
> +++ b/arch/arm/boot/dts/ti/omap/Makefile
> @@ -93,6 +93,7 @@ dtb-$(CONFIG_SOC_AM33XX) += \
>  	am335x-boneblue.dtb \
>  	am335x-bonegreen.dtb \
>  	am335x-bonegreen-wireless.dtb \
> +	am335x-bonegreen-eco.dtb \
>  	am335x-chiliboard.dtb \
>  	am335x-cm-t335.dtb \
>  	am335x-evm.dtb \
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts
> new file mode 100644
> index 000000000000..521f92347bbe
> --- /dev/null
> +++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts
> @@ -0,0 +1,170 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2025 Bootlin
> + */
> +/dts-v1/;
> +
> +#include "am33xx.dtsi"
> +#include "am335x-bone-common.dtsi"
> +#include "am335x-bonegreen-common.dtsi"
> +#include <dt-bindings/net/ti-dp83867.h>
> +
> +/ {
> +	model = "TI AM335x BeagleBone Green Eco";
> +	compatible = "ti,am335x-bone-green-eco", "ti,am335x-bone-green",
> +		     "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
> +
these compatibles should be defined in
Documentation/devicetree/bindings/arm/ti/omap.yaml

But are that much really necessary? At least ti,am335x-bone-black looks
strange in the list, it does not look as it is derived from it.

> +	cpus {
> +		cpu@0 {
> +			cpu0-supply = <&buck1>;
> +		};
> +	};
> +
> +	sys_5v: sys-5v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "sys_5v";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		regulator-always-on;
> +	};
> +
> +	v3v3: v3v3 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "v3v3";
> +		regulator-always-on;
> +	};
> +};
> +
> +&usb0 {
> +	interrupts-extended = <&intc 18>;
> +	interrupt-names = "mc";
> +};
> +
> +&baseboard_eeprom {
> +	vcc-supply = <&v3v3>;
> +};
> +
> +&i2c0 {
> +	/delete-node/ tps@24;
> +
> +	tps65214: tps@30 {

generic node names please, so pmic@30.
And maybe while you are at it, maybe you can clean up the tps@24 stuff.

Regards,
Andreas