* [PATCH] arm64: dts: rockchip: Fix cover detection on PineNote
@ 2025-05-26 16:14 Diederik de Haas
2025-06-09 10:22 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Diederik de Haas @ 2025-05-26 16:14 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
Cc: Dragan Simic, Maximilian Weigand, Marek Kraus, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, Diederik de Haas,
hrdl, phantomas
The SW_MACHINE_COVER switch event was added to input event codes to
detect the removal of the back cover of the N900.
But on the PineNote its purpose is to detect when the front cover gets
closed, just like when a laptop lid is closed. Therefore SW_LID is the
appropriate linux code and not SW_MACHINE_COVER.
Reported-by: hrdl <git@hrdl.eu>
Helped-by: phantomas <phantomas@phantomas.xyz>
Link: https://lore.kernel.org/r/270f27c9-afd6-171d-7dce-fe1d71dd8f9a@wizzup.org/
Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
index 3613661417b2..5c6f8cc401c9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
@@ -55,7 +55,7 @@ switch-cover {
label = "cover";
gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_LOW>;
linux,input-type = <EV_SW>;
- linux,code = <SW_MACHINE_COVER>;
+ linux,code = <SW_LID>;
linux,can-disable;
wakeup-event-action = <EV_ACT_DEASSERTED>;
wakeup-source;
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix cover detection on PineNote
2025-05-26 16:14 [PATCH] arm64: dts: rockchip: Fix cover detection on PineNote Diederik de Haas
@ 2025-06-09 10:22 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2025-06-09 10:22 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Diederik de Haas
Cc: Heiko Stuebner, Dragan Simic, Maximilian Weigand, Marek Kraus,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, hrdl,
phantomas
On Mon, 26 May 2025 18:14:47 +0200, Diederik de Haas wrote:
> The SW_MACHINE_COVER switch event was added to input event codes to
> detect the removal of the back cover of the N900.
> But on the PineNote its purpose is to detect when the front cover gets
> closed, just like when a laptop lid is closed. Therefore SW_LID is the
> appropriate linux code and not SW_MACHINE_COVER.
>
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Fix cover detection on PineNote
commit: 3f391123e2bc88c570f148cc01e923e4740c5173
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-09 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-26 16:14 [PATCH] arm64: dts: rockchip: Fix cover detection on PineNote Diederik de Haas
2025-06-09 10:22 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox