From: Yixun Lan <dlan@gentoo.org>
To: "Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Guodong Xu <guodong@riscstar.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr, p.zabel@pengutronix.de,
drew@pdp7.com, inochiama@gmail.com, geert+renesas@glider.be,
heylenay@4d2.org, tglx@linutronix.de, hal.feng@starfivetech.com,
unicorn_wang@outlook.com, duje.mihanovic@skole.hr,
heikki.krogerus@linux.intel.com, elder@riscstar.com,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev
Subject: Re: [PATCH v3 4/6] riscv: dts: spacemit: add pwm14_1 pinctrl setting
Date: Mon, 26 May 2025 21:52:43 +0000 [thread overview]
Message-ID: <20250526215243-GYA53128@gentoo> (raw)
In-Reply-To: <paasmwjel652r25nxobidydtpxfjy7emerilmwqhvhtgrrtg6v@gowpzqdzvlfz>
Hi Guodong, Uwe,
On 18:54 Mon 26 May , Uwe Kleine-König wrote:
> On Tue, Apr 29, 2025 at 04:50:46PM +0800, Guodong Xu wrote:
> > diff --git a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > index 283663647a86..195eb8874f3c 100644
> > --- a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > +++ b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > @@ -20,4 +20,11 @@ uart0-2-pins {
> > drive-strength = <32>;
> > };
> > };
> > + pwm14_1_cfg: pwm14-1-cfg {
> > + pwm14-1-pins {
> > + pinmux = <K1_PADCONF(44, 4)>;
> > + bias-pull-up = <0>;
> > + drive-strength = <32>;
> > + };
> > + };
>
> There is a newline expected before the pwm14-1-cfg node, isn't there?
>
Right, I could amend this and fix it while applying this patch
(so if there is no other serious issue, no need to resend)
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2025-05-26 21:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 8:50 [PATCH v3 0/6] pwm: Update PWM_PXA driver for SpacemiT K1 Guodong Xu
2025-04-29 8:50 ` [PATCH v3 1/6] dt-bindings: pwm: marvell,pxa-pwm: Add SpacemiT K1 PWM support Guodong Xu
2025-04-29 8:50 ` [PATCH v3 2/6] pwm: pxa: add optional reset control Guodong Xu
2025-04-29 8:50 ` [PATCH v3 3/6] riscv: dts: spacemit: add PWM support for K1 SoC Guodong Xu
2025-04-29 8:50 ` [PATCH v3 4/6] riscv: dts: spacemit: add pwm14_1 pinctrl setting Guodong Xu
2025-05-26 16:54 ` Uwe Kleine-König
2025-05-26 21:52 ` Yixun Lan [this message]
2025-05-27 2:48 ` Guodong Xu
2025-05-27 3:27 ` Yixun Lan
2025-05-27 4:36 ` Guodong Xu
2025-04-29 8:50 ` [PATCH v3 5/6] pwm: Kconfig: add depends on ARCH_SPACEMIT to PWM_PXA Guodong Xu
2025-04-29 8:50 ` [PATCH v3 6/6] riscv: defconfig: Enable PWM support for SpacemiT K1 SoC Guodong Xu
2025-07-07 22:29 ` Yixun Lan
2025-07-08 16:50 ` Conor Dooley
2025-05-14 7:21 ` [PATCH v3 0/6] pwm: Update PWM_PXA driver for SpacemiT K1 Guodong Xu
2025-05-26 17:22 ` Uwe Kleine-König
2025-05-27 2:41 ` Guodong Xu
2025-05-27 9:03 ` Uwe Kleine-König
2025-07-08 14:33 ` (subset) " Yixun Lan
2025-07-09 6:37 ` Yixun Lan
2025-07-10 6:33 ` Guodong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250526215243-GYA53128@gentoo \
--to=dlan@gentoo.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drew@pdp7.com \
--cc=duje.mihanovic@skole.hr \
--cc=elder@riscstar.com \
--cc=geert+renesas@glider.be \
--cc=guodong@riscstar.com \
--cc=hal.feng@starfivetech.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=heylenay@4d2.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=ukleinek@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox