Re: [PATCH 1/1] dt-bindings: timer: Add fsl,timrot.yaml

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1775 bytes --]

On Fri, May 23, 2025 at 03:19:28PM -0400, Frank Li wrote:
> Add fsl,timrot.yaml for i.MX23/i.MX28 timer.

Same here as the icoll.

> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/timer/fsl,timrot.yaml | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/timer/fsl,timrot.yaml
> 
> diff --git a/Documentation/devicetree/bindings/timer/fsl,timrot.yaml b/Documentation/devicetree/bindings/timer/fsl,timrot.yaml
> new file mode 100644
> index 0000000000000..3c9aacc356a57
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/fsl,timrot.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/fsl,timrot.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale MXS Timer
> +
> +maintainers:
> +  - Frank Li <Frank.Li@nxp.com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - fsl,imx23-timrot
> +          - fsl,imx28-timrot
> +      - const: fsl,timrot
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 4

You should mention what the items are I think in an items list, even if
that's just timer 0 through 3.

> +
> +  clocks:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    timer: timer@80068000 {
> +        compatible = "fsl,imx28-timrot", "fsl,timrot";
> +        reg = <0x80068000 0x2000>;
> +        interrupts = <48>, <49>, <50>, <51>;
> +        clocks = <&clks 26>;
> +    };
> +
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]