From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Johan Hovold <johan@kernel.org>,
alejandroe1@geotab.com, Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: gnss: add u-blox,neo-9m compatible
Date: Tue, 27 May 2025 12:33:01 -0500 [thread overview]
Message-ID: <20250527173301.GA756121-robh@kernel.org> (raw)
In-Reply-To: <0225b57c-1240-4382-a15a-6fa16abdec14@kernel.org>
On Tue, May 27, 2025 at 01:14:54PM +0200, Krzysztof Kozlowski wrote:
> On 27/05/2025 13:02, Johan Hovold wrote:
> > On Tue, May 27, 2025 at 12:51:12PM +0200, Krzysztof Kozlowski wrote:
> >> On 27/05/2025 12:44, Johan Hovold wrote:
> >>> On Tue, May 27, 2025 at 10:35:14AM +0200, Krzysztof Kozlowski wrote:
> >>>> On 23/05/2025 13:52, Krzysztof Kozlowski wrote:
> >>>>> On 23/05/2025 13:19, Alejandro Enrique via B4 Relay wrote:
> >>>>>> From: Alejandro Enrique <alejandroe1@geotab.com>
> >>>>>>
> >>>>>> Add compatible for u-blox NEO-9M GPS module.
> >>>>>>
> >>>>>> Signed-off-by: Alejandro Enrique <alejandroe1@geotab.com>
> >>>>>> ---
> >>>>>> This series just add the compatible string for u-blox NEO-9M module,
> >>>>>> using neo-m8 as fallback. I have tested the driver with such a module
> >>>>>> and it is working fine.
> >>>>>> ---
> >>>>>
> >>>>> I assume there is a user somewhere?
> >>>>>
> >>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>>> Un-reviewed. Please drop the patch. It turns out there is no user for
> >>>> this binding. We don't take bindings for every possible device out there
> >>>> - you need users of that binding.
> >>>
> >>> No, we don't require manufacturers to upstream their machine dts.
> >>
> >> No, we don't take bindings for whatever is there. In any case, drop my
> >> review tag.
> >
> > Perhaps not for whatever, but here we have an actual user that needs
> > this binding do I'll take it.
>
> Great, I understand above that I can send you bindings for multiple
> devices I have (or had and still have interest in or my previous
> employer has interest in), which are used in downstream products, and
> you will take these bindings?
>
> That would be cool, because I have bunch of GNSS devices related to my
> pre-previous job, which I would really like to upstream.
>
> Is my understanding correct?
What's the issue here? We have a driver and that's the user. The
requirement is a driver OR .dts for the user. Are we now discouraging
having a specific compatible for a new device that's backwards
compatible with an existing device? No!
Rob
next prev parent reply other threads:[~2025-05-27 17:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 11:19 [PATCH v3] dt-bindings: gnss: add u-blox,neo-9m compatible Alejandro Enrique via B4 Relay
2025-05-23 11:52 ` Krzysztof Kozlowski
2025-05-27 6:27 ` Krzysztof Kozlowski
2025-05-27 11:54 ` Alejandro Enrique
2025-05-27 8:35 ` Krzysztof Kozlowski
2025-05-27 10:44 ` Johan Hovold
2025-05-27 10:51 ` Krzysztof Kozlowski
2025-05-27 11:02 ` Johan Hovold
2025-05-27 11:14 ` Krzysztof Kozlowski
2025-05-27 17:33 ` Rob Herring [this message]
2025-05-27 17:33 ` Rob Herring (Arm)
2025-06-24 11:30 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527173301.GA756121-robh@kernel.org \
--to=robh@kernel.org \
--cc=alejandroe1@geotab.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).