devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: iio: gyro: invensense,mpu3050: change irq maxItems
@ 2025-05-27 21:51 Rodrigo Gobbi
  2025-05-28  5:55 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Rodrigo Gobbi @ 2025-05-27 21:51 UTC (permalink / raw)
  To: linus.walleij, jic23, dlechner, nuno.sa, andy, robh, krzk+dt,
	conor+dt
  Cc: ~lkcamp/patches, linux-iio, devicetree, linux-kernel

The mpu3050 datasheet describes that this IC only supports one INT pin,
which means one item with two cells inside binding.
Change max to match this description.

Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
---
The mpu3050 supports only one INT pin as described at [1] at
"Pin Out and Signal Description" (pg 14), so maxItems could be 1 at max (one item with two cells).
Validated with dtbs_check/dt_binding_check and looks fine. There is a different case at [2],
which is using interrupts-extended but as far as I understand, it`s still max=1.
Tks and regards.

[1] https://invensense.tdk.com/wp-content/uploads/2015/02/PS-MPU-3050A-00-v2-7.pdf
[2] https://github.com/torvalds/linux/blob/015a99fa76650e7d6efa3e36f20c0f5b346fe9ce/arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts#L248
---
 .../devicetree/bindings/iio/gyroscope/invensense,mpu3050.yaml   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/gyroscope/invensense,mpu3050.yaml b/Documentation/devicetree/bindings/iio/gyroscope/invensense,mpu3050.yaml
index d1a6103fc37a..f3242dc0e7e6 100644
--- a/Documentation/devicetree/bindings/iio/gyroscope/invensense,mpu3050.yaml
+++ b/Documentation/devicetree/bindings/iio/gyroscope/invensense,mpu3050.yaml
@@ -21,7 +21,7 @@ properties:
   vlogic-supply: true
 
   interrupts:
-    minItems: 1
+    maxItems: 1
     description:
       Interrupt mapping for the trigger interrupt from the internal oscillator.
 
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: iio: gyro: invensense,mpu3050: change irq maxItems
  2025-05-27 21:51 [PATCH] dt-bindings: iio: gyro: invensense,mpu3050: change irq maxItems Rodrigo Gobbi
@ 2025-05-28  5:55 ` Krzysztof Kozlowski
  2025-05-31 17:29   ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-28  5:55 UTC (permalink / raw)
  To: Rodrigo Gobbi, linus.walleij, jic23, dlechner, nuno.sa, andy,
	robh, krzk+dt, conor+dt
  Cc: ~lkcamp/patches, linux-iio, devicetree, linux-kernel

On 27/05/2025 23:51, Rodrigo Gobbi wrote:
> The mpu3050 datasheet describes that this IC only supports one INT pin,
> which means one item with two cells inside binding.
> Change max to match this description.
Fixes: 749787477ae4 ("dt-bindings:iio:gyro:invensense,mpu3050: txt to yaml format conversion.")


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: iio: gyro: invensense,mpu3050: change irq maxItems
  2025-05-28  5:55 ` Krzysztof Kozlowski
@ 2025-05-31 17:29   ` Jonathan Cameron
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2025-05-31 17:29 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rodrigo Gobbi, linus.walleij, dlechner, nuno.sa, andy, robh,
	krzk+dt, conor+dt, ~lkcamp/patches, linux-iio, devicetree,
	linux-kernel

On Wed, 28 May 2025 07:55:40 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 27/05/2025 23:51, Rodrigo Gobbi wrote:
> > The mpu3050 datasheet describes that this IC only supports one INT pin,
> > which means one item with two cells inside binding.
> > Change max to match this description.  
> Fixes: 749787477ae4 ("dt-bindings:iio:gyro:invensense,mpu3050: txt to yaml format conversion.")
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied to the fixes-togreg-for-6.16 branch of iio.git.

> 
> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-05-31 17:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-27 21:51 [PATCH] dt-bindings: iio: gyro: invensense,mpu3050: change irq maxItems Rodrigo Gobbi
2025-05-28  5:55 ` Krzysztof Kozlowski
2025-05-31 17:29   ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).