devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jacob Pan <jacob.pan@linux.microsoft.com>
Cc: Shyam Saini <shyamsaini@linux.microsoft.com>,
	iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, virtualization@lists.linux.dev,
	will@kernel.org, eric.auger@redhat.com, code@tyhicks.com,
	eahariha@linux.microsoft.com, vijayb@linux.microsoft.com
Subject: Re: [PATCH v2 0/3] arm-smmu: select suitable IOVA
Date: Wed, 28 May 2025 21:38:26 -0300	[thread overview]
Message-ID: <20250529003826.GA192517@ziepe.ca> (raw)
In-Reply-To: <68379171.170a0220.191ee0.8d6bSMTPIN_ADDED_BROKEN@mx.google.com>

On Wed, May 28, 2025 at 03:42:55PM -0700, Jacob Pan wrote:

> > All IOVA that the platform cannot DMA from should be reported in the
> > reserved_regions file as "reserved". You must make your platform
> > achieve this.
> > 
> Just to double confirm, the expected reserved region should be marked as
> "direct" instead of "msi", right?

I don't know, it depends what is wrong with this platform.

"msi" is the SW_MSI region created by the iommu driver, ignore it.

"reserved" should be from the DT and it says "my platform is broken,
this IOVA doesn't work, don't use it"

"direct" is something entirely different, it also should come from the
DT and it says "must be mapped 1:1 (iova:physical) at all times" which
usually means some FW or other component is controlling the device and
doing DMA using that physical memory space which is unknown to the OS.

Both cases would interfere with the MSI so if the DT/ACPI declares
such regions that overlap with the SW_MSI address then Linux should
select another SW_MSI address.

From a linux perspective "reserved" just ignores those IOVA spaces
while "direct" sets up 1:1 translations there. So FW using direct
incorrectly could become a security problem.

Jason

  parent reply	other threads:[~2025-05-29  0:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10 22:50 [PATCH v2 0/3] arm-smmu: select suitable IOVA Shyam Saini
2025-04-10 22:50 ` [PATCH v2 1/3] arm-smmu: move MSI_IOVA macro definitions Shyam Saini
2025-04-11 23:28   ` kernel test robot
2025-04-12  3:17   ` kernel test robot
2025-04-10 22:50 ` [PATCH v2 2/3] dt-bindings: iommu: add "arm,smmu-faulty-msi-iova" property Shyam Saini
2025-04-10 22:50 ` [PATCH v2 3/3] arm-smmu: select suitable MSI IOVA Shyam Saini
2025-04-11 23:40   ` kernel test robot
2025-04-10 23:00 ` [PATCH v2 0/3] arm-smmu: select suitable IOVA Jason Gunthorpe
2025-04-16 18:04   ` Jacob Pan
     [not found]   ` <67fff12d.650a0220.208c7c.d69dSMTPIN_ADDED_BROKEN@mx.google.com>
2025-04-16 18:17     ` Jason Gunthorpe
2025-04-16 21:34       ` Jacob Pan
2025-05-20 22:42       ` Shyam Saini
2025-05-25 19:07         ` Jason Gunthorpe
2025-05-27 20:54           ` Shyam Saini
2025-05-28  0:04             ` Jason Gunthorpe
2025-05-28 22:42               ` Jacob Pan
     [not found]               ` <68379171.170a0220.191ee0.8d6bSMTPIN_ADDED_BROKEN@mx.google.com>
2025-05-29  0:38                 ` Jason Gunthorpe [this message]
2025-05-29 18:22               ` Shyam Saini
2025-05-29 18:38                 ` Jason Gunthorpe
2025-05-29 22:08                   ` Shyam Saini
2025-05-30 13:13                     ` Jason Gunthorpe
2025-05-30 21:30                       ` Shyam Saini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250529003826.GA192517@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=code@tyhicks.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eahariha@linux.microsoft.com \
    --cc=eric.auger@redhat.com \
    --cc=iommu@lists.linux.dev \
    --cc=jacob.pan@linux.microsoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=shyamsaini@linux.microsoft.com \
    --cc=vijayb@linux.microsoft.com \
    --cc=virtualization@lists.linux.dev \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).