* [PATCH 1/1] dt-bindings: display: convert himax,hx8357d.txt to yaml format
@ 2025-05-29 16:48 Frank Li
2025-05-29 18:27 ` Rob Herring (Arm)
2025-05-29 18:30 ` [PATCH 1/1] dt-bindings: display: convert himax, hx8357d.txt " kernel test robot
0 siblings, 2 replies; 4+ messages in thread
From: Frank Li @ 2025-05-29 16:48 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:DRM DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
Convert himax,hx8357d.txt to yaml format.
Additional changes:
- add spi parent node in examples.
- ref to spi-peripheral-props.yaml.
- change himax,hx8357a to himax,hx8357 to align driver and existed dts.
- add himax,hx8369a and fallback to himax,hx8369.
- allow gpios-reset, spi-cpha and spi-cpol to align existed dts.
- add im-gpios for interface selections.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
.../bindings/display/himax,hx8357.yaml | 77 +++++++++++++++++++
.../bindings/display/himax,hx8357d.txt | 26 -------
2 files changed, 77 insertions(+), 26 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/himax,hx8357.yaml
delete mode 100644 Documentation/devicetree/bindings/display/himax,hx8357d.txt
diff --git a/Documentation/devicetree/bindings/display/himax,hx8357.yaml b/Documentation/devicetree/bindings/display/himax,hx8357.yaml
new file mode 100644
index 0000000000000..b5e1f77c11102
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/himax,hx8357.yaml
@@ -0,0 +1,77 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/himax,hx8357.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Himax HX8357D display panel
+
+description:
+ Display panels using a Himax HX8357D controller in SPI
+ mode, such as the Adafruit 3.5" TFT for Raspberry Pi.
+
+maintainers:
+ - Frank Li <Frank.Li@nxp.com>
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - adafruit,yx350hv15
+ - himax,hx8357b
+ - const: himax,hx8357
+ - items:
+ - enum:
+ - himax,hx8369a
+ - const: himax,hx8369
+
+ reg:
+ maxItems: 1
+
+ dc-gpios:
+ maxItems: 1
+ description: D/C pin
+
+ rotation:
+ enum: [0, 90, 180, 270]
+
+ backlight:
+ description:
+ phandle of the backlight device attached to the panel
+
+ im-gpios:
+ maxItems: 3
+
+ gpios-reset: true
+
+ spi-cpha: true
+
+ spi-cpol: true
+
+required:
+ - compatible
+ - reg
+
+allOf:
+ - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ display@0 {
+ compatible = "adafruit,yx350hv15", "himax,hx8357";
+ reg = <0>;
+ spi-max-frequency = <32000000>;
+ dc-gpios = <&gpio0 25 GPIO_ACTIVE_HIGH>;
+ rotation = <90>;
+ backlight = <&backlight>;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/display/himax,hx8357d.txt b/Documentation/devicetree/bindings/display/himax,hx8357d.txt
deleted file mode 100644
index e641f664763d3..0000000000000
--- a/Documentation/devicetree/bindings/display/himax,hx8357d.txt
+++ /dev/null
@@ -1,26 +0,0 @@
-Himax HX8357D display panels
-
-This binding is for display panels using a Himax HX8357D controller in SPI
-mode, such as the Adafruit 3.5" TFT for Raspberry Pi.
-
-Required properties:
-- compatible: "adafruit,yx350hv15", "himax,hx8357d"
-- dc-gpios: D/C pin
-- reg: address of the panel on the SPI bus
-
-The node for this driver must be a child node of a SPI controller, hence
-all mandatory properties described in ../spi/spi-bus.txt must be specified.
-
-Optional properties:
-- rotation: panel rotation in degrees counter clockwise (0,90,180,270)
-- backlight: phandle of the backlight device attached to the panel
-
-Example:
- display@0{
- compatible = "adafruit,yx350hv15", "himax,hx8357d";
- reg = <0>;
- spi-max-frequency = <32000000>;
- dc-gpios = <&gpio0 25 GPIO_ACTIVE_HIGH>;
- rotation = <90>;
- backlight = <&backlight>;
- };
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] dt-bindings: display: convert himax,hx8357d.txt to yaml format
2025-05-29 16:48 [PATCH 1/1] dt-bindings: display: convert himax,hx8357d.txt to yaml format Frank Li
@ 2025-05-29 18:27 ` Rob Herring (Arm)
2025-05-30 14:02 ` Rob Herring
2025-05-29 18:30 ` [PATCH 1/1] dt-bindings: display: convert himax, hx8357d.txt " kernel test robot
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-05-29 18:27 UTC (permalink / raw)
To: Frank Li
Cc: Conor Dooley, devicetree, Thomas Zimmermann, imx, linux-kernel,
Maxime Ripard, dri-devel, Simona Vetter, David Airlie,
Krzysztof Kozlowski, Maarten Lankhorst
On Thu, 29 May 2025 12:48:21 -0400, Frank Li wrote:
> Convert himax,hx8357d.txt to yaml format.
>
> Additional changes:
> - add spi parent node in examples.
> - ref to spi-peripheral-props.yaml.
> - change himax,hx8357a to himax,hx8357 to align driver and existed dts.
> - add himax,hx8369a and fallback to himax,hx8369.
> - allow gpios-reset, spi-cpha and spi-cpol to align existed dts.
> - add im-gpios for interface selections.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../bindings/display/himax,hx8357.yaml | 77 +++++++++++++++++++
> .../bindings/display/himax,hx8357d.txt | 26 -------
> 2 files changed, 77 insertions(+), 26 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/himax,hx8357.yaml
> delete mode 100644 Documentation/devicetree/bindings/display/himax,hx8357d.txt
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/himax,hx8357.yaml: gpios-reset: missing type definition
doc reference errors (make refcheckdocs):
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/display/himax,hx8357d.txt
MAINTAINERS: Documentation/devicetree/bindings/display/himax,hx8357d.txt
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250529164822.777908-1-Frank.Li@nxp.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: display: convert himax,hx8357d.txt to yaml format
2025-05-29 18:27 ` Rob Herring (Arm)
@ 2025-05-30 14:02 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2025-05-30 14:02 UTC (permalink / raw)
To: Frank Li
Cc: Conor Dooley, devicetree, Thomas Zimmermann, imx, linux-kernel,
Maxime Ripard, dri-devel, Simona Vetter, David Airlie,
Krzysztof Kozlowski, Maarten Lankhorst
On Thu, May 29, 2025 at 01:27:38PM -0500, Rob Herring (Arm) wrote:
>
> On Thu, 29 May 2025 12:48:21 -0400, Frank Li wrote:
> > Convert himax,hx8357d.txt to yaml format.
> >
> > Additional changes:
> > - add spi parent node in examples.
> > - ref to spi-peripheral-props.yaml.
> > - change himax,hx8357a to himax,hx8357 to align driver and existed dts.
> > - add himax,hx8369a and fallback to himax,hx8369.
> > - allow gpios-reset, spi-cpha and spi-cpol to align existed dts.
Fix the .dts files and drop gpios-reset. The kernel has a work-around
and I would assume it's been in place long enough to support
reset-gpios.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: display: convert himax, hx8357d.txt to yaml format
2025-05-29 16:48 [PATCH 1/1] dt-bindings: display: convert himax,hx8357d.txt to yaml format Frank Li
2025-05-29 18:27 ` Rob Herring (Arm)
@ 2025-05-29 18:30 ` kernel test robot
1 sibling, 0 replies; 4+ messages in thread
From: kernel test robot @ 2025-05-29 18:30 UTC (permalink / raw)
To: Frank Li, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, open list:DRM DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: oe-kbuild-all, imx
Hi Frank,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.15 next-20250529]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Frank-Li/dt-bindings-display-convert-himax-hx8357d-txt-to-yaml-format/20250530-004954
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20250529164822.777908-1-Frank.Li%40nxp.com
patch subject: [PATCH 1/1] dt-bindings: display: convert himax, hx8357d.txt to yaml format
reproduce: (https://download.01.org/0day-ci/archive/20250530/202505300219.7v1CVviw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505300219.7v1CVviw-lkp@intel.com/
All warnings (new ones prefixed by >>):
Warning: Documentation/translations/zh_CN/dev-tools/gdb-kernel-debugging.rst references a file that doesn't exist: Documentation/dev-tools/gdb-kernel-debugging.rst
Warning: Documentation/translations/zh_TW/admin-guide/README.rst references a file that doesn't exist: Documentation/dev-tools/kgdb.rst
Warning: Documentation/translations/zh_TW/dev-tools/gdb-kernel-debugging.rst references a file that doesn't exist: Documentation/dev-tools/gdb-kernel-debugging.rst
Warning: Documentation/userspace-api/netlink/index.rst references a file that doesn't exist: Documentation/networking/netlink_spec/index.rst
Warning: Documentation/userspace-api/netlink/specs.rst references a file that doesn't exist: Documentation/networking/netlink_spec/index.rst
>> Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/display/himax,hx8357d.txt
Using alabaster theme
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-30 14:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-29 16:48 [PATCH 1/1] dt-bindings: display: convert himax,hx8357d.txt to yaml format Frank Li
2025-05-29 18:27 ` Rob Herring (Arm)
2025-05-30 14:02 ` Rob Herring
2025-05-29 18:30 ` [PATCH 1/1] dt-bindings: display: convert himax, hx8357d.txt " kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox