Devicetree
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	arnd@arndb.de
Subject: Re: [PATCH 2/3] misc: add sysfs control driver for ST M24LR series RFID/NFC chips
Date: Sat, 31 May 2025 10:25:15 +0200	[thread overview]
Message-ID: <2025053149-karate-stooge-8bc1@gregkh> (raw)
In-Reply-To: <20250531081159.2007319-3-abd.masalkhi@gmail.com>

On Sat, May 31, 2025 at 08:11:58AM +0000, Abd-Alrhman Masalkhi wrote:
> +	return scnprintf(buf, PAGE_SIZE, "%llx\n", val);

Please use sysfs_emit() for writing data out in sysfs show callbacks.

thanks,

greg k-h

  parent reply	other threads:[~2025-05-31  8:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-31  8:11 [PATCH 0/3] Add control driver for ST M24LR RFID/NFC EEPROM chips Abd-Alrhman Masalkhi
2025-05-31  8:11 ` [PATCH 1/3] dt-bindings: misc: Add binding for ST M24LR control interface Abd-Alrhman Masalkhi
2025-05-31  9:25   ` Rob Herring (Arm)
2025-05-31 13:37   ` Krzysztof Kozlowski
2025-06-01  7:31     ` [PATCH v2 1/3] dt-bindings: Add Device Tree " Abd-Alrhman Masalkhi
2025-05-31  8:11 ` [PATCH 2/3] misc: add sysfs control driver for ST M24LR series RFID/NFC chips Abd-Alrhman Masalkhi
2025-05-31  8:24   ` Greg KH
2025-05-31  8:25   ` Greg KH [this message]
2025-06-01  2:19   ` kernel test robot
2025-06-01  3:21   ` kernel test robot
2025-05-31  8:11 ` [PATCH 3/3] MAINTAINERS: Add entry for ST M24LR control driver Abd-Alrhman Masalkhi
2025-05-31 13:37   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025053149-karate-stooge-8bc1@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=abd.masalkhi@gmail.com \
    --cc=arnd@arndb.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox