* [PATCH v2 1/1] dt-bindings: display: convert himax,hx8357d.txt to yaml format
@ 2025-06-02 15:28 Frank Li
2025-06-06 2:13 ` Rob Herring (Arm)
0 siblings, 1 reply; 2+ messages in thread
From: Frank Li @ 2025-06-02 15:28 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:DRM DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx, wahrenst
Convert himax,hx8357d.txt to yaml format.
Additional changes:
- add spi parent node in examples.
- ref to spi-peripheral-props.yaml.
- change himax,hx8357a to himax,hx8357 to align driver and existed dts.
- add himax,hx8369a and fallback to himax,hx8369.
- allow spi-cpha and spi-cpol to align existed dts.
- add im-gpios for interface selections.
- add reset-gpios.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change in v2
- update MAINTANERS files
- replace gpios-reset with reset-gpios, kernel have quirk for it.
---
.../bindings/display/himax,hx8357.yaml | 78 +++++++++++++++++++
.../bindings/display/himax,hx8357d.txt | 26 -------
MAINTAINERS | 2 +-
3 files changed, 79 insertions(+), 27 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/himax,hx8357.yaml
delete mode 100644 Documentation/devicetree/bindings/display/himax,hx8357d.txt
diff --git a/Documentation/devicetree/bindings/display/himax,hx8357.yaml b/Documentation/devicetree/bindings/display/himax,hx8357.yaml
new file mode 100644
index 0000000000000..34c3b89bf0033
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/himax,hx8357.yaml
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/himax,hx8357.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Himax HX8357D display panel
+
+description:
+ Display panels using a Himax HX8357D controller in SPI
+ mode, such as the Adafruit 3.5" TFT for Raspberry Pi.
+
+maintainers:
+ - Frank Li <Frank.Li@nxp.com>
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - adafruit,yx350hv15
+ - himax,hx8357b
+ - const: himax,hx8357
+ - items:
+ - enum:
+ - himax,hx8369a
+ - const: himax,hx8369
+
+ reg:
+ maxItems: 1
+
+ dc-gpios:
+ maxItems: 1
+ description: D/C pin
+
+ rotation:
+ enum: [0, 90, 180, 270]
+
+ backlight:
+ description:
+ phandle of the backlight device attached to the panel
+
+ im-gpios:
+ maxItems: 3
+
+ reset-gpios:
+ maxItems: 1
+
+ spi-cpha: true
+
+ spi-cpol: true
+
+required:
+ - compatible
+ - reg
+
+allOf:
+ - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ display@0 {
+ compatible = "adafruit,yx350hv15", "himax,hx8357";
+ reg = <0>;
+ spi-max-frequency = <32000000>;
+ dc-gpios = <&gpio0 25 GPIO_ACTIVE_HIGH>;
+ rotation = <90>;
+ backlight = <&backlight>;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/display/himax,hx8357d.txt b/Documentation/devicetree/bindings/display/himax,hx8357d.txt
deleted file mode 100644
index e641f664763d3..0000000000000
--- a/Documentation/devicetree/bindings/display/himax,hx8357d.txt
+++ /dev/null
@@ -1,26 +0,0 @@
-Himax HX8357D display panels
-
-This binding is for display panels using a Himax HX8357D controller in SPI
-mode, such as the Adafruit 3.5" TFT for Raspberry Pi.
-
-Required properties:
-- compatible: "adafruit,yx350hv15", "himax,hx8357d"
-- dc-gpios: D/C pin
-- reg: address of the panel on the SPI bus
-
-The node for this driver must be a child node of a SPI controller, hence
-all mandatory properties described in ../spi/spi-bus.txt must be specified.
-
-Optional properties:
-- rotation: panel rotation in degrees counter clockwise (0,90,180,270)
-- backlight: phandle of the backlight device attached to the panel
-
-Example:
- display@0{
- compatible = "adafruit,yx350hv15", "himax,hx8357d";
- reg = <0>;
- spi-max-frequency = <32000000>;
- dc-gpios = <&gpio0 25 GPIO_ACTIVE_HIGH>;
- rotation = <90>;
- backlight = <&backlight>;
- };
diff --git a/MAINTAINERS b/MAINTAINERS
index 7761b5ef87674..c14da518a214c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7523,7 +7523,7 @@ F: drivers/gpu/drm/panel/panel-himax-hx8394.c
DRM DRIVER FOR HX8357D PANELS
S: Orphan
T: git https://gitlab.freedesktop.org/drm/misc/kernel.git
-F: Documentation/devicetree/bindings/display/himax,hx8357d.txt
+F: Documentation/devicetree/bindings/display/himax,hx8357.yaml
F: drivers/gpu/drm/tiny/hx8357d.c
DRM DRIVER FOR HYPERV SYNTHETIC VIDEO DEVICE
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: display: convert himax,hx8357d.txt to yaml format
2025-06-02 15:28 [PATCH v2 1/1] dt-bindings: display: convert himax,hx8357d.txt to yaml format Frank Li
@ 2025-06-06 2:13 ` Rob Herring (Arm)
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring (Arm) @ 2025-06-06 2:13 UTC (permalink / raw)
To: Frank Li
Cc: Maarten Lankhorst, Thomas Zimmermann, imx, linux-kernel,
Simona Vetter, dri-devel, David Airlie, wahrenst, devicetree,
Conor Dooley, Maxime Ripard, Krzysztof Kozlowski
On Mon, 02 Jun 2025 11:28:13 -0400, Frank Li wrote:
> Convert himax,hx8357d.txt to yaml format.
>
> Additional changes:
> - add spi parent node in examples.
> - ref to spi-peripheral-props.yaml.
> - change himax,hx8357a to himax,hx8357 to align driver and existed dts.
> - add himax,hx8369a and fallback to himax,hx8369.
> - allow spi-cpha and spi-cpol to align existed dts.
> - add im-gpios for interface selections.
> - add reset-gpios.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> change in v2
> - update MAINTANERS files
> - replace gpios-reset with reset-gpios, kernel have quirk for it.
> ---
> .../bindings/display/himax,hx8357.yaml | 78 +++++++++++++++++++
> .../bindings/display/himax,hx8357d.txt | 26 -------
> MAINTAINERS | 2 +-
> 3 files changed, 79 insertions(+), 27 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/himax,hx8357.yaml
> delete mode 100644 Documentation/devicetree/bindings/display/himax,hx8357d.txt
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-06 2:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-02 15:28 [PATCH v2 1/1] dt-bindings: display: convert himax,hx8357d.txt to yaml format Frank Li
2025-06-06 2:13 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).