From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 756BE256C80; Thu, 5 Jun 2025 13:34:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749130482; cv=none; b=TVms3TLlVdpiwoxu+25s10ZTMwo300xHpVIlXtzgvc0pdz7wO2HMjuZTBmzg8zznxBnfgtWQw9JDJaLInHxitvtwp1klJ4nNLXtRl43nUKXJW6Slf66X/SZEcAGCCV63QMPkq6xIY528kcsTKUc35fMWNDnUkhh8VFDekJxMW/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749130482; c=relaxed/simple; bh=T5wNBhaigilJ3oKCmgpQHNaAmsXMsPPSdnJJJThaI8E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eVDSfl0cB5RYm1joMqK6T6oDram9o3tbPw44enqB0Oit0JTOSAlggj6e8Y1H110PAILa/cryc4QpJGm55ZZrgEdkTHbQ+DL7rmEm4/Fz3zPHpi3oEGYO2g9mYV+XyCwYKoNZi40KjgmkKb1t93Kh11/bTlUAetomeufCXwrX5/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Received: from localhost (unknown [IPv6:240e:45b:7e90:d32d:3a26:ba44:aeb4:61b0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id 54FDD3430F0; Thu, 05 Jun 2025 13:34:38 +0000 (UTC) Date: Thu, 5 Jun 2025 13:34:27 +0000 From: Yixun Lan To: Ze Huang Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thinh Nguyen , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/4] usb: dwc3: add generic driver to support flattened DT Message-ID: <20250605133427.GYA18884.dlan.gentoo> References: <20250526-b4-k1-dwc3-v3-v4-0-63e4e525e5cb@whut.edu.cn> <20250526-b4-k1-dwc3-v3-v4-3-63e4e525e5cb@whut.edu.cn> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250526-b4-k1-dwc3-v3-v4-3-63e4e525e5cb@whut.edu.cn> Hi Ze, On 22:40 Mon 26 May , Ze Huang wrote: > To support flattened dwc3 dt model and drop the glue layer, introduce the > `dwc3-generic` driver. This enables direct binding of the DWC3 core driver > and offers an alternative to the existing glue driver `dwc3-of-simple`. > > Signed-off-by: Ze Huang > --- > drivers/usb/dwc3/Kconfig | 9 ++ > drivers/usb/dwc3/Makefile | 1 + > drivers/usb/dwc3/dwc3-generic-plat.c | 189 +++++++++++++++++++++++++++++++++++ > 3 files changed, 199 insertions(+) > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index 310d182e10b50b253d7e5a51674806e6ec442a2a..082627f39c9726ee4e0c5f966c5bc454f5541c9a 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -118,6 +118,15 @@ config USB_DWC3_OF_SIMPLE > Currently supports Xilinx and Qualcomm DWC USB3 IP. > Say 'Y' or 'M' if you have one such device. > > +config USB_DWC3_GENERIC_PLAT > + tristate "DWC3 Generic Platform Driver" > + depends on OF && COMMON_CLK > + default USB_DWC3 > + help > + Support USB3 functionality in simple SoC integrations. > + Currently supports SpacemiT DWC USB3 IP. > + Say 'Y' or 'M' if you have one such device. > + > config USB_DWC3_ST > tristate "STMicroelectronics Platforms" > depends on (ARCH_STI || COMPILE_TEST) && OF > diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile > index 830e6c9e5fe073c1f662ce34b6a4a2da34c407a2..96469e48ff9d189cc8d0b65e65424eae2158bcfe 100644 > --- a/drivers/usb/dwc3/Makefile > +++ b/drivers/usb/dwc3/Makefile > @@ -57,3 +57,4 @@ obj-$(CONFIG_USB_DWC3_IMX8MP) += dwc3-imx8mp.o > obj-$(CONFIG_USB_DWC3_XILINX) += dwc3-xilinx.o > obj-$(CONFIG_USB_DWC3_OCTEON) += dwc3-octeon.o > obj-$(CONFIG_USB_DWC3_RTK) += dwc3-rtk.o > +obj-$(CONFIG_USB_DWC3_GENERIC_PLAT) += dwc3-generic-plat.o > diff --git a/drivers/usb/dwc3/dwc3-generic-plat.c b/drivers/usb/dwc3/dwc3-generic-plat.c > new file mode 100644 > index 0000000000000000000000000000000000000000..8ff4626d324c40ecb52e115832c803fed7d38354 > --- /dev/null > +++ b/drivers/usb/dwc3/dwc3-generic-plat.c > @@ -0,0 +1,189 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * dwc3-generic-plat.c - DesignWare USB3 generic platform driver > + * > + * Copyright (C) 2025 Ze Huang > + * > + * Inspired by dwc3-qcom.c and dwc3-of-simple.c > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include "glue.h" > + > +struct dwc3_generic { > + struct device *dev; > + struct dwc3 dwc; > + struct clk_bulk_data *clks; > + int num_clocks; > + struct reset_control *resets; > +}; > + > +static int dwc3_generic_probe(struct platform_device *pdev) > +{ > + struct dwc3_probe_data probe_data = {}; > + struct device *dev = &pdev->dev; > + struct dwc3_generic *dwc3; > + struct resource *res; > + int ret; > + > + dwc3 = devm_kzalloc(dev, sizeof(*dwc3), GFP_KERNEL); > + if (!dwc3) > + return -ENOMEM; > + > + dwc3->dev = dev; > + > + platform_set_drvdata(pdev, dwc3); > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) { > + dev_err(&pdev->dev, "missing memory resource\n"); > + return -ENODEV; > + } > + > + dwc3->resets = of_reset_control_array_get_optional_exclusive(dev->of_node); > + if (IS_ERR(dwc3->resets)) > + return dev_err_probe(dev, PTR_ERR(dwc3->resets), "failed to get reset\n"); > + > + ret = reset_control_assert(dwc3->resets); > + if (ret) > + return dev_err_probe(dev, ret, "failed to assert reset\n"); > + > + usleep_range(10, 1000); > + > + ret = reset_control_deassert(dwc3->resets); > + if (ret) { > + dev_err(dev, "failed to deassert reset\n"); > + goto reset_assert; > + } > + > + ret = clk_bulk_get_all(dwc3->dev, &dwc3->clks); can you check if able to use devres api for reset/clock here? (functions start devm_ prefix) > + if (ret < 0) { > + dev_err(dev, "failed to get clocks\nt"); > + goto reset_assert; > + } > + > + dwc3->num_clocks = ret; > + > + ret = clk_bulk_prepare_enable(dwc3->num_clocks, dwc3->clks); > + if (ret) { > + dev_err(dev, "failed to enable clocks\n"); > + goto reset_assert; > + } > + > + dwc3->dwc.dev = dev; > + probe_data.dwc = &dwc3->dwc; > + probe_data.res = res; > + probe_data.ignore_clocks_and_resets = true; > + ret = dwc3_core_probe(&probe_data); > + if (ret) { > + dev_err(dev, "failed to register DWC3 Core\n"); > + goto clk_disable; > + } > + > + return 0; > + > +clk_disable: > + clk_bulk_disable_unprepare(dwc3->num_clocks, dwc3->clks); > + clk_bulk_put_all(dwc3->num_clocks, dwc3->clks); > + > +reset_assert: > + reset_control_assert(dwc3->resets); > + > + return ret; > +} > + > +static void dwc3_generic_remove(struct platform_device *pdev) > +{ > + struct dwc3_generic *dwc3 = platform_get_drvdata(pdev); > + > + dwc3_core_remove(&dwc3->dwc); > + > + clk_bulk_disable_unprepare(dwc3->num_clocks, dwc3->clks); > + clk_bulk_put_all(dwc3->num_clocks, dwc3->clks); > + > + reset_control_assert(dwc3->resets); > +} > + > +static int __maybe_unused dwc3_generic_suspend(struct device *dev) > +{ > + struct dwc3_generic *dwc3 = dev_get_drvdata(dev); > + int ret; > + > + ret = dwc3_pm_suspend(&dwc3->dwc); > + if (ret) > + return ret; > + > + clk_bulk_disable_unprepare(dwc3->num_clocks, dwc3->clks); > + > + return 0; > +} > + > +static int __maybe_unused dwc3_generic_resume(struct device *dev) > +{ > + struct dwc3_generic *dwc3 = dev_get_drvdata(dev); > + int ret; > + > + ret = clk_bulk_prepare_enable(dwc3->num_clocks, dwc3->clks); > + if (ret) > + return ret; > + > + ret = dwc3_pm_resume(&dwc3->dwc); > + if (ret) > + return ret; > + > + return 0; > +} > + > +static int __maybe_unused dwc3_generic_runtime_suspend(struct device *dev) > +{ > + struct dwc3_generic *dwc3 = dev_get_drvdata(dev); > + > + return dwc3_runtime_suspend(&dwc3->dwc); > +} > + > +static int __maybe_unused dwc3_generic_runtime_resume(struct device *dev) > +{ > + struct dwc3_generic *dwc3 = dev_get_drvdata(dev); > + > + return dwc3_runtime_resume(&dwc3->dwc); > +} > + > +static int __maybe_unused dwc3_generic_runtime_idle(struct device *dev) > +{ > + struct dwc3_generic *dwc3 = dev_get_drvdata(dev); > + > + return dwc3_runtime_idle(&dwc3->dwc); > +} > + > +static const struct dev_pm_ops dwc3_generic_dev_pm_ops = { > + SET_SYSTEM_SLEEP_PM_OPS(dwc3_generic_suspend, dwc3_generic_resume) > + SET_RUNTIME_PM_OPS(dwc3_generic_runtime_suspend, dwc3_generic_runtime_resume, > + dwc3_generic_runtime_idle) > +}; > + > +static const struct of_device_id dwc3_generic_of_match[] = { > + { .compatible = "spacemit,k1-dwc3", }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, dwc3_generic_of_match); > + > +static struct platform_driver dwc3_generic_driver = { > + .probe = dwc3_generic_probe, > + .remove = dwc3_generic_remove, > + .driver = { > + .name = "dwc3-generic-plat", > + .of_match_table = dwc3_generic_of_match, > +#ifdef CONFIG_PM_SLEEP > + .pm = &dwc3_generic_dev_pm_ops, > +#endif /* CONFIG_PM_SLEEP */ > + }, > +}; > +module_platform_driver(dwc3_generic_driver); > + > +MODULE_LICENSE("GPL"); > +MODULE_DESCRIPTION("DesignWare USB3 generic platform driver"); > > -- > 2.49.0 > -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55