From: Conor Dooley <conor@kernel.org>
To: marius.cristea@microchip.com
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, broonie@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: adc: adding support for PAC194X
Date: Fri, 6 Jun 2025 17:24:36 +0100 [thread overview]
Message-ID: <20250606-olympics-limeade-fcf2421950d0@spud> (raw)
In-Reply-To: <20250606093929.100118-2-marius.cristea@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
On Fri, Jun 06, 2025 at 12:39:28PM +0300, marius.cristea@microchip.com wrote:
David had a bunch of comments, so much to say, but..
> + interrupt-names:
> + description:
> + alert1 indicates a HIGH or LOW limit was exceeded.
> + alert2 indicates a THERM limit was exceeded.
You should be able to merge this description into the items list,
> + items:
> + - const: alert1
by adding description: into these
> + - const: alert2
e.g.
items:
- const: sdmmc-3v3
description: pad configuration for 3.3 V
- const: sdmmc-1v8
description: pad configuration for 1.8 V
- const: sdmmc-3v3-drv
description: pull-up/down configuration for 3.3 V
- const: sdmmc-1v8-drv
description: pull-up/down configuration for 1.8 V
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-06-06 16:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 9:39 [PATCH v3 0/2] adding support for Microchip PAC194X Power Monitor marius.cristea
2025-06-06 9:39 ` [PATCH v3 1/2] dt-bindings: iio: adc: adding support for PAC194X marius.cristea
2025-06-06 15:53 ` David Lechner
2025-06-10 14:46 ` Marius.Cristea
2025-06-10 15:22 ` David Lechner
2025-06-10 16:04 ` Marius.Cristea
2025-06-10 16:35 ` David Lechner
2025-06-17 15:21 ` Marius.Cristea
2025-06-06 16:24 ` Conor Dooley [this message]
2025-06-06 9:39 ` [PATCH v3 2/2] " marius.cristea
2025-06-06 17:02 ` David Lechner
2025-06-10 15:07 ` Marius.Cristea
2025-06-10 16:11 ` David Lechner
2025-06-11 15:59 ` Jonathan Cameron
2025-06-10 20:20 ` Andy Shevchenko
2025-06-07 15:27 ` Jonathan Cameron
2025-06-10 15:58 ` Marius.Cristea
2025-06-11 16:12 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606-olympics-limeade-fcf2421950d0@spud \
--to=conor@kernel.org \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.cristea@microchip.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox