From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Igor Korotin <igor.korotin.linux@gmail.com>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
"Igor Korotin" <igor.korotin@yahoo.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Saravana Kannan" <saravanak@google.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>, "Len Brown" <lenb@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Alex Hung" <alex.hung@amd.com>,
"Tamir Duberstein" <tamird@gmail.com>,
"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
"Xiangfei Ding" <dingxiangfei2009@gmail.com>
Subject: Re: [PATCH v2 3/5] rust: driver: Add ACPI id table support to Adapter trait
Date: Fri, 6 Jun 2025 17:29:13 +0200 [thread overview]
Message-ID: <2025060635-unleveled-drowsily-a192@gregkh> (raw)
In-Reply-To: <CAG7QV91AWpOk7VUcE-B1MLkEQPDB0Y=zsBOBf6MhHVYh1aEGQA@mail.gmail.com>
On Fri, Jun 06, 2025 at 03:26:13PM +0100, Igor Korotin wrote:
> On Fri, Jun 6, 2025 at 2:50 PM Danilo Krummrich <dakr@kernel.org> wrote:
> > However, I don't understand why we need this and the subsequent
> > is_acpi_device_node() and is_of_node() checks.
>
> The idea is to avoid unnecessary table lookups when both OF and ACPI
> match tables are present. If we already know the fwnode type, these
> simple pointer comparisons (is_acpi_device_node() / is_of_node()) let
> us skip the irrelevant match function.
>
> Those checks are cheap (just pointer comparisons), while
> acpi_match_device() and of_match_device() iterate over tables.
>
> So yeah, it’s a bit ugly, but it can save some CPU cycles during enumeration.
You have loads of CPU cycles during enumeration, keep things simple
first, only attempt to optimize things later on if it is actually
measureable.
thanks,
greg k-h
next prev parent reply other threads:[~2025-06-06 15:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 16:19 [PATCH v2 0/5] rust: Add ACPI match table support for Rust drivers Igor Korotin
2025-06-05 16:23 ` [PATCH v2 1/5] rust: acpi: add `acpi::DeviceId` abstraction Igor Korotin
2025-06-06 1:17 ` kernel test robot
2025-06-05 16:24 ` [PATCH v2 2/5] rust: helpers: Add `is_of_node` helper function Igor Korotin
2025-06-05 16:27 ` [PATCH v2 3/5] rust: driver: Add ACPI id table support to Adapter trait Igor Korotin
2025-06-06 13:50 ` Danilo Krummrich
2025-06-06 14:26 ` Igor Korotin
2025-06-06 14:32 ` Danilo Krummrich
2025-06-06 14:58 ` Igor Korotin
2025-06-06 15:14 ` Danilo Krummrich
2025-06-06 15:29 ` Greg Kroah-Hartman [this message]
2025-06-06 15:38 ` Danilo Krummrich
2025-06-06 15:59 ` Igor Korotin
2025-06-05 16:51 ` Igor Korotin
2025-06-06 1:50 ` kernel test robot
2025-06-05 16:51 ` [PATCH v2 4/5] rust: platform: Add ACPI match table support to `Driver` trait Igor Korotin
2025-06-05 16:52 ` [PATCH v2 5/5] samples: rust: add ACPI match table example to platform driver Igor Korotin
2025-06-06 13:58 ` Danilo Krummrich
2025-06-06 13:26 ` [PATCH v2 0/5] rust: Add ACPI match table support for Rust drivers Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025060635-unleveled-drowsily-a192@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=alex.hung@amd.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dingxiangfei2009@gmail.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=igor.korotin.linux@gmail.com \
--cc=igor.korotin@yahoo.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=saravanak@google.com \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).