devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Harsh Jain <h.jain@amd.com>
To: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<linux-crypto@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<mounika.botcha@amd.com>, <sarat.chand.savitala@amd.com>,
	<mohan.dhanawade@amd.com>, <michal.simek@amd.com>
Cc: Harsh Jain <h.jain@amd.com>, kernel test robot <lkp@intel.com>,
	"Dan Carpenter" <dan.carpenter@linaro.org>
Subject: [PATCH v2 5/6] crypto: xilinx: Fix missing goto in probe
Date: Mon, 9 Jun 2025 10:21:09 +0530	[thread overview]
Message-ID: <20250609045110.1786634-6-h.jain@amd.com> (raw)
In-Reply-To: <20250609045110.1786634-1-h.jain@amd.com>

Add goto to clean up allocated cipher on reseed failure.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202505311325.22fIOcCt-lkp@intel.com/
Signed-off-by: Harsh Jain <h.jain@amd.com>
---
 drivers/crypto/xilinx/xilinx-trng.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/xilinx/xilinx-trng.c b/drivers/crypto/xilinx/xilinx-trng.c
index adaf69c58647..8ec0f83b53f1 100644
--- a/drivers/crypto/xilinx/xilinx-trng.c
+++ b/drivers/crypto/xilinx/xilinx-trng.c
@@ -365,7 +365,7 @@ static int xtrng_probe(struct platform_device *pdev)
 	ret = xtrng_reseed_internal(rng);
 	if (ret) {
 		dev_err(&pdev->dev, "TRNG Seed fail\n");
-		return ret;
+		goto cipher_cleanup;
 	}
 
 	xilinx_rng_dev = rng;
-- 
2.34.1


  parent reply	other threads:[~2025-06-09  4:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09  4:51 [PATCH v2 0/6] Add Versal TRNG driver Harsh Jain
2025-06-09  4:51 ` [PATCH v2 1/6] dt-bindings: crypto: Add node for True Random Number Generator Harsh Jain
2025-06-09  6:37   ` Rob Herring (Arm)
2025-06-09 13:15   ` Rob Herring
2025-06-11  4:23     ` Jain, Harsh (AECG-SSW)
2025-06-09  4:51 ` [PATCH v2 2/6] crypto: xilinx: Add TRNG driver for Versal Harsh Jain
2025-06-09  4:51 ` [PATCH v2 3/6] crypto: drbg: Export CTR DRBG DF functions Harsh Jain
2025-06-09  4:51 ` [PATCH v2 4/6] crypto: xilinx: Select dependant Kconfig option for CRYPTO_DRBG_CTR Harsh Jain
2025-06-10  6:17   ` Krzysztof Kozlowski
2025-06-10  6:25     ` Jain, Harsh (AECG-SSW)
2025-06-09  4:51 ` Harsh Jain [this message]
2025-06-10  6:18   ` [PATCH v2 5/6] crypto: xilinx: Fix missing goto in probe Krzysztof Kozlowski
2025-06-10  6:28     ` Jain, Harsh (AECG-SSW)
2025-06-10  8:00       ` Dan Carpenter
2025-06-09  4:51 ` [PATCH v2 6/6] crypto: xilinx: Use min_t macro to compare value Harsh Jain
2025-06-10  6:18   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250609045110.1786634-6-h.jain@amd.com \
    --to=h.jain@amd.com \
    --cc=dan.carpenter@linaro.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=michal.simek@amd.com \
    --cc=mohan.dhanawade@amd.com \
    --cc=mounika.botcha@amd.com \
    --cc=sarat.chand.savitala@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).