From: Bjorn Helgaas <helgaas@kernel.org>
To: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
quic_vbadigan@quicinc.com, quic_mrana@quicinc.com,
Sherry Sun <sherry.sun@nxp.com>
Subject: Re: [PATCH v3 2/2] PCI/portdrv: Add support for PCIe wake interrupt
Date: Mon, 9 Jun 2025 11:29:30 -0500 [thread overview]
Message-ID: <20250609162930.GA749610@bhelgaas> (raw)
In-Reply-To: <7b91b725-6b47-bf8f-e6e5-e4584f274ec4@oss.qualcomm.com>
On Mon, Jun 09, 2025 at 11:27:49AM +0530, Krishna Chaitanya Chundru wrote:
> On 6/6/2025 1:56 AM, Bjorn Helgaas wrote:
> > On Thu, Jun 05, 2025 at 10:54:45AM +0530, Krishna Chaitanya Chundru wrote:
> > > PCIe wake interrupt is needed for bringing back PCIe device state
> > > from D3cold to D0.
> > > + wake = devm_fwnode_gpiod_get(&pdev->dev, of_fwnode_handle(dn),
> > > + "wake", GPIOD_IN, NULL);
> >
> > I guess this finds "wake-gpio" or "wake-gpios", as used in
> > Documentation/devicetree/bindings/pci/qcom,pcie.yaml,
> > qcom,pcie-sa8775p.yaml, etc? Are these names specified in any generic
> > place, e.g.,
> > https://github.com/devicetree-org/dt-schema/tree/main/dtschema/schemas/pci?
> >
> I created a patch to add them in common schemas:
> https://lore.kernel.org/all/20250515090517.3506772-1-krishna.chundru@oss.qualcomm.com/
Thanks. I think it will help other DT writers if we can include a
link to the relevant dtschema commit in this commit log.
next prev parent reply other threads:[~2025-06-09 16:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 5:24 [PATCH v3 0/2] PCI: Add support for PCIe wake interrupt Krishna Chaitanya Chundru
2025-06-05 5:24 ` [PATCH v3 1/2] arm64: dts: qcom: sc7280: Add wake GPIO Krishna Chaitanya Chundru
2025-06-05 17:56 ` Konrad Dybcio
2025-06-05 5:24 ` [PATCH v3 2/2] PCI/portdrv: Add support for PCIe wake interrupt Krishna Chaitanya Chundru
2025-06-05 20:26 ` Bjorn Helgaas
2025-06-09 5:57 ` Krishna Chaitanya Chundru
2025-06-09 11:59 ` Manivannan Sadhasivam
2025-06-09 22:34 ` Bjorn Helgaas
2025-06-10 4:30 ` Krishna Chaitanya Chundru
2025-06-10 16:41 ` Bjorn Helgaas
2025-07-03 10:51 ` Krishna Chaitanya Chundru
2025-08-12 16:10 ` Manivannan Sadhasivam
2025-06-09 16:29 ` Bjorn Helgaas [this message]
2025-06-10 4:32 ` Krishna Chaitanya Chundru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250609162930.GA749610@bhelgaas \
--to=helgaas@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=quic_mrana@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh@kernel.org \
--cc=sherry.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).