devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Tony Lindgren <tony@atomide.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Kevin Hilman <khilman@baylibre.com>,
	Roger Quadros <rogerq@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Bajjuri Praneeth <praneeth@ti.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/5] arm: dts: omap: Remove incorrect compatible strings from device trees
Date: Mon, 9 Jun 2025 22:08:09 +0200	[thread overview]
Message-ID: <20250609220809.3a488972@akair> (raw)
In-Reply-To: <20250609-bbg-v2-1-5278026b7498@bootlin.com>

Am Mon, 09 Jun 2025 17:43:51 +0200
schrieb Kory Maincent <kory.maincent@bootlin.com>:

> Several device trees incorrectly included ti,am335x-bone-black or
> ti,am335x-bone in their compatible lists without including the
> corresponding bone-black-common or bone-common device tree files.
> Remove these incompatible strings to fix the inconsistency.
> 
thanks for cleaning up some mess.

> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Change in v2:
> - New patch
> ---
>  arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts | 2 +-
>  arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts          | 2 +-
>  arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts     | 2 +-
>  arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts       | 2 +-
>  arch/arm/boot/dts/ti/omap/am335x-shc.dts                | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
> index a4f5b5262645..fb88eebb8c5d 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
> @@ -11,7 +11,7 @@
>  
>  / {
>  	model = "TI AM335x BeagleBone Green Wireless";
> -	compatible = "ti,am335x-bone-green-wireless", "ti,am335x-bone-green", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
> +	compatible = "ti,am335x-bone-green-wireless", "ti,am335x-bone", "ti,am33xx";
>  
this looks like too much cleanup, also according your omap.yaml stuff,
ti,am335x-bone-green should still be included.

Regards,
Andreas

  reply	other threads:[~2025-06-09 20:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 15:43 [PATCH v2 0/5] Add support for BeagleBone Green Eco board Kory Maincent
2025-06-09 15:43 ` [PATCH v2 1/5] arm: dts: omap: Remove incorrect compatible strings from device trees Kory Maincent
2025-06-09 20:08   ` Andreas Kemnade [this message]
2025-06-09 20:35     ` Kory Maincent
2025-06-09 15:43 ` [PATCH v2 2/5] binding: omap: Add lots of missing omap AM33 compatibles Kory Maincent
2025-06-09 17:03   ` Conor Dooley
2025-06-09 19:50     ` Andreas Kemnade
2025-06-10 15:29       ` Conor Dooley
2025-06-10 12:48     ` Jason Kridner
2025-06-09 23:34   ` Andrew Davis
2025-06-10  8:05     ` Kory Maincent
2025-06-25 19:44       ` Rob Herring
2025-06-16 10:03     ` Andreas Kemnade
2025-06-11  9:06   ` Krzysztof Kozlowski
2025-06-09 15:43 ` [PATCH v2 3/5] arm: dts: omap: am335x-bone-common: Rename tps to generic pmic node Kory Maincent
2025-06-09 15:43 ` [PATCH v2 4/5] arm: dts: omap: Add support for BeagleBone Green Eco board Kory Maincent
2025-06-09 17:04   ` Conor Dooley
2025-06-09 20:45     ` Kory Maincent
2025-06-09 21:23       ` Andreas Kemnade
2025-06-10 15:26       ` Conor Dooley
2025-06-17  8:18       ` Krzysztof Kozlowski
2025-06-09 15:43 ` [PATCH v2 5/5] arm: omap2plus_defconfig: Enable TPS65219 regulator Kory Maincent
2025-06-11 21:13   ` Andrew Davis
2025-06-12  6:12     ` Andreas Kemnade
2025-06-12 13:09       ` Andrew Davis
2025-06-12 13:19         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250609220809.3a488972@akair \
    --to=andreas@kemnade.info \
    --cc=aaro.koskinen@iki.fi \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=kory.maincent@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=praneeth@ti.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).