[PATCH v2 1/3] dt-bindings: power: Add SiFive Domain Management controllers

[PATCH v2 1/3] dt-bindings: power: Add SiFive Domain Management controllers

[Nick Hu]

SiFive Domain Management controller includes the following components
- SiFive Tile Management Controller
- SiFive Cluster Management Controller
- SiFive Core Complex Management Controller

These controllers control the clock and power domain of the
corresponding domain.

However, Since we don't have a SoC specific compatible string yet, so
add '- {}' for the first entry [1][2].

Links:
- [1] https://lore.kernel.org/lkml/20250311195953.GA14239-robh@kernel.org/
- [2] https://lore.kernel.org/lkml/CAKddAkAzDGL-7MbroRqQnZzPXOquUMKNuGGppqB-d_XZXbcvBA@mail.gmail.com/T/#t

Signed-off-by: Nick Hu <nick.hu@sifive.com>
Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
---
 .../devicetree/bindings/power/sifive,tmc.yaml | 70 +++++++++++++++++++
 1 file changed, 70 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/sifive,tmc.yaml

diff --git a/Documentation/devicetree/bindings/power/sifive,tmc.yaml b/Documentation/devicetree/bindings/power/sifive,tmc.yaml
new file mode 100644
index 000000000000..4567d51148e1
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/sifive,tmc.yaml
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/sifive,tmc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: SiFive Domain Management Controller
+
+maintainers:
+  - Cyan Yang <cyan.yang@sifive.com>
+  - Nick Hu <nick.hu@sifive.com>
+  - Samuel Holland <samuel.holland@sifive.com>
+
+description: |
+  SiFive Domain Management Controllers includes the following components
+    - Tile Management Controller (TMC)
+    - Cluster Management Controller (CMC)
+    - Subsystem Management Controller (SMC)
+  These controllers manage both the clock and power domains of the
+  associated components. They support the SiFive Quiet Interface Protocol
+  (SQIP) starting from Version 1. The control method differs from Version
+  0, making them incompatible.
+
+allOf:
+  - $ref: power-domain.yaml#
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - {} # Leave a empty for future SoC specific compatible string
+          - const: sifive,cmc3
+          - const: sifive,cmc2
+      - items:
+          - {} # Leave a empty for future SoC specific compatible string
+          - const: sifive,cmc2
+      - items:
+          - {} # Leave a empty for future SoC specific compatible string
+          - const: sifive,smc0
+      - items:
+          - {} # Leave a empty for future SoC specific compatible string
+          - const: sifive,smc1
+      - items:
+          - {} # Leave a empty for future SoC specific compatible string
+          - const: sifive,smc3
+          - const: sifive,smc1
+      - items:
+          - {} # Leave a empty for future SoC specific compatible string
+          - const: sifive,tmc0
+      - items:
+          - {} # Leave a empty for future SoC specific compatible string
+          - const: sifive,tmc1
+      - items:
+          - {} # Leave a empty for future SoC specific compatible string
+          - const: sifive,tmc3
+          - const: sifive,tmc1
+
+  reg:
+    maxItems: 1
+
+  "#power-domain-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+# The example will be added once the SoC specific compatible string is available
-- 
2.17.1

Re: [PATCH v2 1/3] dt-bindings: power: Add SiFive Domain Management controllers

[Krzysztof Kozlowski]

On 11/06/2025 05:10, Nick Hu wrote:
> SiFive Domain Management controller includes the following components
> - SiFive Tile Management Controller
> - SiFive Cluster Management Controller
> - SiFive Core Complex Management Controller
> 
> These controllers control the clock and power domain of the
> corresponding domain.
> 
> However, Since we don't have a SoC specific compatible string yet, so
> add '- {}' for the first entry [1][2].


But you must have Soc specific compatible strings. See previous discussion.

Best regards,
Krzysztof

Re: [PATCH v2 1/3] dt-bindings: power: Add SiFive Domain Management controllers

[Nick Hu]

On Wed, Jun 11, 2025 at 2:57 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 11/06/2025 05:10, Nick Hu wrote:
> > SiFive Domain Management controller includes the following components
> > - SiFive Tile Management Controller
> > - SiFive Cluster Management Controller
> > - SiFive Core Complex Management Controller
> >
> > These controllers control the clock and power domain of the
> > corresponding domain.
> >
> > However, Since we don't have a SoC specific compatible string yet, so
> > add '- {}' for the first entry [1][2].
>
>
> But you must have Soc specific compatible strings. See previous discussion.
>
Maybe I'm missing something, but since we don't have a SoC-specific compatible
string yet, I thought we agreed to include a `- {}` as the first
entry, along with an
explanation in both the commit message and comments [1].

Links:
- [1] https://lore.kernel.org/linux-riscv/c91d99c9-0ecb-4dcd-9beb-5a1e9fadc619@kernel.org/

> Best regards,
> Krzysztof

Re: [PATCH v2 1/3] dt-bindings: power: Add SiFive Domain Management controllers

[Krzysztof Kozlowski]

On 11/06/2025 09:15, Nick Hu wrote:
> On Wed, Jun 11, 2025 at 2:57 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 11/06/2025 05:10, Nick Hu wrote:
>>> SiFive Domain Management controller includes the following components
>>> - SiFive Tile Management Controller
>>> - SiFive Cluster Management Controller
>>> - SiFive Core Complex Management Controller
>>>
>>> These controllers control the clock and power domain of the
>>> corresponding domain.
>>>
>>> However, Since we don't have a SoC specific compatible string yet, so
>>> add '- {}' for the first entry [1][2].
>>
>>
>> But you must have Soc specific compatible strings. See previous discussion.
>>
> Maybe I'm missing something, but since we don't have a SoC-specific compatible
> string yet, I thought we agreed to include a `- {}` as the first
> entry, along with an
> explanation in both the commit message and comments [1].
But your commit msg does not explain. You need to explain why you do not
have SoC specific compatibles. Saying "I do not have a SoC specific
compatible" is not an argument explaining why you do not have SoC
specific compatible.

Best regards,
Krzysztof

Re: [PATCH v2 1/3] dt-bindings: power: Add SiFive Domain Management controllers

[Nick Hu]

On Wed, Jun 11, 2025 at 3:20 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 11/06/2025 09:15, Nick Hu wrote:
> > On Wed, Jun 11, 2025 at 2:57 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>
> >> On 11/06/2025 05:10, Nick Hu wrote:
> >>> SiFive Domain Management controller includes the following components
> >>> - SiFive Tile Management Controller
> >>> - SiFive Cluster Management Controller
> >>> - SiFive Core Complex Management Controller
> >>>
> >>> These controllers control the clock and power domain of the
> >>> corresponding domain.
> >>>
> >>> However, Since we don't have a SoC specific compatible string yet, so
> >>> add '- {}' for the first entry [1][2].
> >>
> >>
> >> But you must have Soc specific compatible strings. See previous discussion.
> >>
> > Maybe I'm missing something, but since we don't have a SoC-specific compatible
> > string yet, I thought we agreed to include a `- {}` as the first
> > entry, along with an
> > explanation in both the commit message and comments [1].
> But your commit msg does not explain. You need to explain why you do not
> have SoC specific compatibles. Saying "I do not have a SoC specific
> compatible" is not an argument explaining why you do not have SoC
> specific compatible.
>
You're right. How about updating the commit msg to "When the SoCs are
ready, we will add the SoC compatible string at that time" ?

Best regards,
Nick