From: Michael Walle <mwalle@kernel.org>
To: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Julien Panis <jpanis@baylibre.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, Michael Walle <mwalle@kernel.org>
Subject: [PATCH v1 5/5] regulator: tps6594-regulator: Add TI TPS652G1 PMIC regulators
Date: Wed, 11 Jun 2025 15:31:37 +0200 [thread overview]
Message-ID: <20250611133137.1686183-6-mwalle@kernel.org> (raw)
In-Reply-To: <20250611133137.1686183-1-mwalle@kernel.org>
The TI TPS652G1 is a stripped down version of the TPS65224 PMIC. It
doesn't feature the multiphase buck converter nor any voltage
monitoring. Due to the latter there are no interrupts serviced. In case
of the TPS652G1 any interrupt related setup is just skipped.
Signed-off-by: Michael Walle <mwalle@kernel.org>
---
drivers/regulator/tps6594-regulator.c | 41 +++++++++++++++++++++------
1 file changed, 33 insertions(+), 8 deletions(-)
diff --git a/drivers/regulator/tps6594-regulator.c b/drivers/regulator/tps6594-regulator.c
index 51264c869aa0..401bc9ca4cd6 100644
--- a/drivers/regulator/tps6594-regulator.c
+++ b/drivers/regulator/tps6594-regulator.c
@@ -578,6 +578,7 @@ static int tps6594_regulator_probe(struct platform_device *pdev)
const struct tps6594_regulator_irq_type **ldos_irq_types;
const struct regulator_desc *ldo_regs;
size_t interrupt_count;
+ const struct regulator_desc *buck_cfg;
if (tps->chip_id == TPS65224) {
bucks_irq_types = tps65224_bucks_irq_types;
@@ -586,6 +587,12 @@ static int tps6594_regulator_probe(struct platform_device *pdev)
ldos_irq_types = tps65224_ldos_irq_types;
ldo_regs = tps65224_ldo_regs;
multi_phase_cnt = ARRAY_SIZE(tps65224_multi_regs);
+ buck_cfg = tps65224_buck_regs;
+ } else if (tps->chip_id == TPS652G1) {
+ ldo_regs = tps65224_ldo_regs;
+ /* TPS652G1 doesn't have multi phase buck converters */
+ multi_phase_cnt = 0;
+ buck_cfg = tps65224_buck_regs;
} else {
bucks_irq_types = tps6594_bucks_irq_types;
interrupt_count = ARRAY_SIZE(tps6594_buck1_irq_types);
@@ -593,6 +600,7 @@ static int tps6594_regulator_probe(struct platform_device *pdev)
ldos_irq_types = tps6594_ldos_irq_types;
ldo_regs = tps6594_ldo_regs;
multi_phase_cnt = ARRAY_SIZE(tps6594_multi_regs);
+ buck_cfg = buck_regs;
}
enum {
@@ -657,18 +665,24 @@ static int tps6594_regulator_probe(struct platform_device *pdev)
nr_buck = ARRAY_SIZE(tps65224_buck_regs);
nr_ldo = ARRAY_SIZE(tps65224_ldo_regs);
nr_types = TPS65224_REGS_INT_NB;
+ } else if (tps->chip_id == TPS652G1) {
+ nr_buck = ARRAY_SIZE(tps65224_buck_regs);
+ nr_ldo = ARRAY_SIZE(tps65224_ldo_regs);
} else {
nr_buck = ARRAY_SIZE(buck_regs);
nr_ldo = (tps->chip_id == LP8764) ? 0 : ARRAY_SIZE(tps6594_ldo_regs);
nr_types = REGS_INT_NB;
}
- reg_irq_nb = nr_types * (nr_buck + nr_ldo);
+ if (tps->chip_id != TPS652G1) {
+ reg_irq_nb = nr_types * (nr_buck + nr_ldo);
- irq_data = devm_kmalloc_array(tps->dev, reg_irq_nb,
- sizeof(struct tps6594_regulator_irq_data), GFP_KERNEL);
- if (!irq_data)
- return -ENOMEM;
+ irq_data = devm_kmalloc_array(tps->dev, reg_irq_nb,
+ sizeof(struct tps6594_regulator_irq_data),
+ GFP_KERNEL);
+ if (!irq_data)
+ return -ENOMEM;
+ }
for (i = 0; i < multi_phase_cnt; i++) {
if (!buck_multi[i])
@@ -680,6 +694,10 @@ static int tps6594_regulator_probe(struct platform_device *pdev)
"failed to register %s regulator\n",
pdev->name);
+ /* skip interrupts */
+ if (tps->chip_id == TPS652G1)
+ continue;
+
/* config multiphase buck12+buck34 */
if (i == MULTI_BUCK12_34)
buck_idx = 2;
@@ -718,14 +736,15 @@ static int tps6594_regulator_probe(struct platform_device *pdev)
if (buck_configured[i])
continue;
- const struct regulator_desc *buck_cfg = (tps->chip_id == TPS65224) ?
- tps65224_buck_regs : buck_regs;
-
rdev = devm_regulator_register(&pdev->dev, &buck_cfg[i], &config);
if (IS_ERR(rdev))
return dev_err_probe(tps->dev, PTR_ERR(rdev),
"failed to register %s regulator\n", pdev->name);
+ /* skip interrupts */
+ if (tps->chip_id == TPS652G1)
+ continue;
+
error = tps6594_request_reg_irqs(pdev, rdev, irq_data,
bucks_irq_types[i], interrupt_count, &irq_idx);
if (error)
@@ -741,6 +760,10 @@ static int tps6594_regulator_probe(struct platform_device *pdev)
"failed to register %s regulator\n",
pdev->name);
+ /* skip interrupts */
+ if (tps->chip_id == TPS652G1)
+ continue;
+
error = tps6594_request_reg_irqs(pdev, rdev, irq_data,
ldos_irq_types[i], interrupt_count,
&irq_idx);
@@ -752,6 +775,8 @@ static int tps6594_regulator_probe(struct platform_device *pdev)
if (tps->chip_id == TPS65224) {
irq_types = tps65224_ext_regulator_irq_types;
irq_count = ARRAY_SIZE(tps65224_ext_regulator_irq_types);
+ } else if (tps->chip_id == TPS652G1) {
+ irq_count = 0;
} else {
irq_types = tps6594_ext_regulator_irq_types;
if (tps->chip_id == LP8764)
--
2.39.5
next prev parent reply other threads:[~2025-06-11 13:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 13:31 [PATCH v1 0/5] mfd: tps6594: Add TI TPS652G1 support Michael Walle
2025-06-11 13:31 ` [PATCH v1 1/5] dt-bindings: mfd: ti,tps6594: Add TI TPS652G1 PMIC Michael Walle
2025-06-11 16:25 ` Conor Dooley
2025-06-11 13:31 ` [PATCH v1 2/5] mfd: tps6594: Add TI TPS652G1 support Michael Walle
2025-06-11 13:31 ` [PATCH v1 3/5] misc: tps6594-pfsm: Add TI TPS652G1 PMIC PFSM Michael Walle
2025-06-11 13:31 ` [PATCH v1 4/5] pinctrl: pinctrl-tps6594: Add TPS652G1 PMIC pinctrl and GPIO Michael Walle
2025-06-11 13:31 ` Michael Walle [this message]
2025-06-11 13:38 ` [PATCH v1 5/5] regulator: tps6594-regulator: Add TI TPS652G1 PMIC regulators Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611133137.1686183-6-mwalle@kernel.org \
--to=mwalle@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jpanis@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox