Re: [PATCH 2/3] dt-bindings: trivial-devices: Document Argon40 Fan HAT

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]

On Wed, Jun 11, 2025 at 12:07:26AM +0200, Marek Vasut wrote:
> Document trivial PWM on Argon40 Fan HAT, which is a RaspberryPi
> blower fan hat which can be controlled over I2C.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

I don't see how a pwm controller, with a fan connected to it, is a
trivial device, sorry.
PWM fans have their own pwm consumer binding too, so it feels wrong on
two levels.

> ---
> Cc: "Uwe Kleine-König" <ukleinek@kernel.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-pwm@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 27930708ccd5..b8f1ee6e63dd 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -45,6 +45,8 @@ properties:
>            - adi,lt7182s
>              # AMS iAQ-Core VOC Sensor
>            - ams,iaq-core
> +            # Argon40 Fan HAT PWM controller
> +          - argon40,fan-hat
>              # Temperature monitoring of Astera Labs PT5161L PCIe retimer
>            - asteralabs,pt5161l
>              # i2c h/w elliptic curve crypto module
> -- 
> 2.47.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]