devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nuno Sá via B4 Relay" <devnull+nuno.sa.analog.com@kernel.org>
To: linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-input@vger.kernel.org
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Uwe Kleine-König" <ukleinek@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Liu Ying" <victor.liu@nxp.com>
Subject: [PATCH v5 20/20] mfd: adp5585: add support for a reset pin
Date: Sat, 14 Jun 2025 15:36:11 +0100	[thread overview]
Message-ID: <20250614-dev-adp5589-fw-v5-20-7e9d84906268@analog.com> (raw)
In-Reply-To: <20250614-dev-adp5589-fw-v5-0-7e9d84906268@analog.com>

From: Nuno Sá <nuno.sa@analog.com>

Make sure to perform an Hardware reset during probe  if the pin is given
in FW.

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 drivers/mfd/adp5585.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/mfd/adp5585.c b/drivers/mfd/adp5585.c
index e4a725b9e1475be03cd26898faa7a7bb8de4319b..f6dcdb632667120f4c6ce54812dc18083ca5d15f 100644
--- a/drivers/mfd/adp5585.c
+++ b/drivers/mfd/adp5585.c
@@ -12,6 +12,7 @@
 #include <linux/device.h>
 #include <linux/err.h>
 #include <linux/i2c.h>
+#include <linux/gpio/consumer.h>
 #include <linux/mfd/adp5585.h>
 #include <linux/mfd/core.h>
 #include <linux/mod_devicetable.h>
@@ -691,6 +692,7 @@ static int adp5585_i2c_probe(struct i2c_client *i2c)
 {
 	struct regmap_config *regmap_config;
 	struct adp5585_dev *adp5585;
+	struct gpio_desc *gpio;
 	unsigned int id;
 	int ret;
 
@@ -715,6 +717,20 @@ static int adp5585_i2c_probe(struct i2c_client *i2c)
 	if (ret)
 		return ret;
 
+	gpio = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_HIGH);
+	if (IS_ERR(gpio))
+		return PTR_ERR(gpio);
+
+	/*
+	 * Note the timings are not documented anywhere in the datasheet. They are just
+	 * reasonable values that work.
+	 */
+	if (gpio) {
+		fsleep(30);
+		gpiod_set_value_cansleep(gpio, 0);
+		fsleep(60);
+	}
+
 	adp5585->regmap = devm_regmap_init_i2c(i2c, regmap_config);
 	if (IS_ERR(adp5585->regmap))
 		return dev_err_probe(&i2c->dev, PTR_ERR(adp5585->regmap),

-- 
2.49.0



  parent reply	other threads:[~2025-06-14 14:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-14 14:35 [PATCH v5 00/20] mfd: adp5585: support keymap events and drop legacy Input driver Nuno Sá via B4 Relay
2025-06-14 14:35 ` [PATCH v5 01/20] dt-bindings: mfd: adp5585: ease on the required properties Nuno Sá via B4 Relay
2025-06-14 14:35 ` [PATCH v5 02/20] mfd: adp5585: only add devices given in FW Nuno Sá via B4 Relay
2025-06-14 14:35 ` [PATCH v5 03/20] mfd: adp5585: enable oscilator during probe Nuno Sá via B4 Relay
2025-06-18 17:41   ` Uwe Kleine-König
2025-06-14 14:35 ` [PATCH v5 04/20] mfd: adp5585: make use of MFD_CELL_NAME() Nuno Sá via B4 Relay
2025-06-14 14:35 ` [PATCH v5 05/20] dt-bindings: mfd: adp5585: document adp5589 I/O expander Nuno Sá via B4 Relay
2025-06-14 14:35 ` [PATCH v5 06/20] mfd: adp5585: refactor how regmap defaults are handled Nuno Sá via B4 Relay
2025-06-19 14:19   ` Lee Jones
2025-06-14 14:35 ` [PATCH v5 07/20] mfd: adp5585: add support for adp5589 Nuno Sá via B4 Relay
2025-06-14 14:35 ` [PATCH v5 08/20] mfd: adp5585: add a per chip reg struture Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 09/20] gpio: adp5585: add support for the adp5589 expander Nuno Sá via B4 Relay
2025-06-16  7:57   ` Bartosz Golaszewski
2025-06-14 14:36 ` [PATCH v5 10/20] pwm: adp5585: add support for adp5589 Nuno Sá via B4 Relay
2025-06-18 17:42   ` Uwe Kleine-König
2025-06-14 14:36 ` [PATCH v5 11/20] dt-bindings: mfd: adp5585: add properties for input events Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 12/20] mfd: adp5585: add support for event handling Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 13/20] mfd: adp5585: support reset and unlock events Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 14/20] mfd: adp5585: add support for input devices Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 15/20] gpio: adp5585: support gpi events Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 16/20] Input: adp5585: Add Analog Devices ADP5585/89 support Nuno Sá via B4 Relay
2025-06-17 21:10   ` Dmitry Torokhov
2025-06-14 14:36 ` [PATCH v5 17/20] Input: adp5589: remove the driver Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 18/20] mfd: adp5585: support getting vdd regulator Nuno Sá via B4 Relay
2025-06-19 14:22   ` Lee Jones
2025-06-14 14:36 ` [PATCH v5 19/20] dt-bindings: mfd: adp5585: document reset gpio Nuno Sá via B4 Relay
2025-06-14 14:36 ` Nuno Sá via B4 Relay [this message]
2025-06-19 13:38 ` [PATCH v5 00/20] mfd: adp5585: support keymap events and drop legacy Input driver Lee Jones
2025-06-27 15:46   ` Nuno Sá
2025-07-01 11:05     ` Lee Jones
2025-07-01 11:09       ` Nuno Sá
2025-07-01 11:15         ` Krzysztof Kozlowski
2025-07-01 11:19         ` Laurent Pinchart
2025-07-01 13:37           ` Lee Jones
2025-07-01 13:42             ` Nuno Sá
2025-06-19 14:23 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250614-dev-adp5589-fw-v5-20-7e9d84906268@analog.com \
    --to=devnull+nuno.sa.analog.com@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=ukleinek@kernel.org \
    --cc=victor.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).